[gdb/testsuite] Reset errcnt and warncnt in default_gdb_init

Say we do:
...
$ make check RUNTESTFLAGS="gdb.dap/ada-nested.exp gdb.dap/pause.exp"
...
and add a perror at the end of pause.exp:
...
 dap_shutdown
+
+perror "foo"
...

We run into:
...
UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
...

This happens because the perror increases the errcnt, which is not reset at
the end of the test-case, and consequently the first pass in the following
test-case is changed into an unresolved.

Version 1.6.3 of dejagnu contains a fix which produces an unresolved at the
end of the test-case, which does reset the errcnt, but this is with version
1.6.1.

Furthermore, we reset the errcnt in clean_restart, but the pass is produced
before, so that doesn't help either.

Fix this by resetting errcnt and warncnt in default_gdb_init.

Tested on x86_64-linux.

Approved-By: Tom Tromey <tom@tromey.com>

PR testsuite/31351
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31351
This commit is contained in:
Tom de Vries 2024-02-27 16:24:15 +01:00
parent 0dbca2abb9
commit 50c6682d74

View File

@ -6859,6 +6859,15 @@ proc default_gdb_init { test_file_name } {
return [uplevel 1 ::gdb_tcl_unknown $args]
}
}
# Dejagnu version 1.6.3 and later produce an unresolved at the end of a
# testcase if an error triggered, resetting errcnt and warncnt to 0, in
# order to avoid errors in one test-case influencing the following
# test-case. Do this manually here, to support older versions.
global errcnt
global warncnt
set errcnt 0
set warncnt 0
}
# Return a path using GDB_PARALLEL.