mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 12:03:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix for PR gdb/15995

Browse Source 
This patch fixes PR gdb/15995.

The bug here is that gdb's printf command does not flush the output
stream.  This makes a printf that is not newline-terminated interleave
incorrectly with other forms of output, such as that generated via a
call to an external program using "shell".

I note that the "output" command already does this flushing.

The fix is to call gdb_flush in printf_command.

Built and regtested on x86-64 Fedora 18.
New test case included.

	PR gdb/15995:
	* printcmd.c (printcmd): Call gdb_flush.

	* gdb.base/printcmds.exp (test_printf): Test printf flushing.
This commit is contained in:
Tom Tromey 2013-10-17 18:29:28 +00:00
parent 5c4c8a5911
commit 50b34a18ed
4 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2013-10-17 Tom Tromey <tromey@redhat.com>
PR gdb/15995:
* printcmd.c (printcmd): Call gdb_flush.
2013-10-17 Tom Tromey <tromey@redhat.com> 2013-10-17 Tom Tromey <tromey@redhat.com>
* elfread.c (struct elfinfo) <stabindexsect>: Remove. * elfread.c (struct elfinfo) <stabindexsect>: Remove.

1
gdb/printcmd.c
View File

@ -2458,6 +2458,7 @@ static void
printf_command (char *arg, int from_tty) printf_command (char *arg, int from_tty)
{ {
ui_printf (arg, gdb_stdout); ui_printf (arg, gdb_stdout);
gdb_flush (gdb_stdout);
} }
/* Implement the "eval" command. */ /* Implement the "eval" command. */

4
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2013-10-17 Tom Tromey <tromey@redhat.com>
* gdb.base/printcmds.exp (test_printf): Test printf flushing.
2013-10-14 Tom Tromey <tromey@redhat.com> 2013-10-14 Tom Tromey <tromey@redhat.com>
* gdb.dwarf2/dwzbuildid.exp (write_dwarf_file): Pass explicit test * gdb.dwarf2/dwzbuildid.exp (write_dwarf_file): Pass explicit test

6
gdb/testsuite/gdb.base/printcmds.exp
View File

@ -740,6 +740,12 @@ proc test_printf {} {
gdb_test "printf \"% p\", 0" "Inappropriate modifiers to format specifier 'p' in printf" gdb_test "printf \"% p\", 0" "Inappropriate modifiers to format specifier 'p' in printf"
gdb_test "printf \"%0p\", 0" "Inappropriate modifiers to format specifier 'p' in printf" gdb_test "printf \"%0p\", 0" "Inappropriate modifiers to format specifier 'p' in printf"
gdb_test "printf \"%+p\", 0" "Inappropriate modifiers to format specifier 'p' in printf" gdb_test "printf \"%+p\", 0" "Inappropriate modifiers to format specifier 'p' in printf"
gdb_test "define hibob\nprintf \"hi bob \"\nshell echo zzz\nprintf \"y\\n\"\nend" \
"" \
"create hibob command"
gdb_test "hibob" "hi bob zzz.*y" "run hibob command"
} }
#Test printing DFP values with printf #Test printing DFP values with printf