2008-06-25 Cary Coutant <ccoutant@google.com>

* fileread.cc (File_read::make_view): Assert on zero-length view.
	* object.cc (Sized_relobj::do_read_symbols): Don't try to read
	symbol table when there are no symbols to read.
This commit is contained in:
Cary Coutant 2008-06-25 17:10:08 +00:00
parent c8187e1509
commit 3f2e6a2da5
3 changed files with 14 additions and 0 deletions

View File

@ -1,3 +1,9 @@
2008-06-25 Cary Coutant <ccoutant@google.com>
* fileread.cc (File_read::make_view): Assert on zero-length view.
* object.cc (Sized_relobj::do_read_symbols): Don't try to read
symbol table when there are no symbols to read.
2008-06-23 Craig Silverstein <csilvers@google.com>
* version.cc (version_string): Bump to 1.7

View File

@ -327,6 +327,8 @@ File_read::View*
File_read::make_view(off_t start, section_size_type size,
unsigned int byteshift, bool cache)
{
gold_assert(size > 0);
off_t poff = File_read::page_offset(start);
section_size_type psize = File_read::pages(size + (start - poff));

View File

@ -452,6 +452,12 @@ Sized_relobj<size, big_endian>::do_read_symbols(Read_symbols_data* sd)
off_t readoff = this->has_eh_frame_ ? dataoff : extoff;
section_size_type readsize = this->has_eh_frame_ ? datasize : extsize;
if (readsize == 0)
{
// No external symbols. Also weird but also legal.
return;
}
File_view* fvsymtab = this->get_lasting_view(readoff, readsize, true, false);
// Read the section header for the symbol names.