mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 03:54:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

gdb: Move read_dbx_symtab to stabsread, and rename to read_stabs_symtab

Browse Source 
Despite the name, read_dbx_symtab is not only used for the dbx file
format (also called the aout format). It is used by elf and coff
implicitly as well. So I think it makes more sense to have this function
in the generic stabsread file, so that reading elf files or coff files
depends less on GDB's ability to read dbx files.

There were 11 static functions in dbxread that were onlyl helper
functions, they were moved and kept as static in stabsread.c. Notably,
dbx_read_symtab - which is installed as a callback on legacy_psymtab
for aout, elf and coff at least - has been moved to stabsread.c and
renamed as well; the function that is specific to aout is
dbx_symfile_read, and that hasn't been moved.

Some macros had to be moved as well, but since they are still used
in dbxread, they were moved to the .h file that the struct symloc
is declared, so anyone can properly use the struct.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Guinevere Larsen 2024-09-17 10:16:30 -03:00
parent 64a1f185b3
commit 3cd1748a7d
3 changed files with 1538 additions and 1557 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1556
gdb/dbxread.c
View File

File diff suppressed because it is too large Load Diff

1510
gdb/stabsread.c
View File

File diff suppressed because it is too large Load Diff

29
gdb/stabsread.h
View File

@ -1,5 +1,5 @@
/* Include file for stabs debugging format support functions.
Copyright (C) 1986-2024 Free Software Foundation, Inc.
/* Include file for stabs debugging format support functions.
Copyright (C) 1986-2024 Free Software Foundation, Inc.
This file is part of GDB.
@ -185,6 +185,13 @@ extern void process_one_symbol (int, int, CORE_ADDR, const char *,
const section_offsets &,
struct objfile *, enum language);
/* Setup partial_symtab's describing each source file for which
debugging information is available. */
void
read_stabs_symtab (minimal_symbol_reader &,
psymtab_storage *, struct objfile *);
extern void elfstab_build_psymtabs (struct objfile *objfile,
asection *stabsect,
file_ptr stabstroffset,
@ -253,6 +260,24 @@ process_one_symbol (int, int, CORE_ADDR, const char *,
#define LDSYMOFF(p) (((struct symloc *)((p)->read_symtab_private))->ldsymoff)
#define LDSYMLEN(p) (((struct symloc *)((p)->read_symtab_private))->ldsymlen)
#define SYMLOC(p) ((struct symloc *)((p)->read_symtab_private))
#define SYMBOL_SIZE(p) (SYMLOC(p)->symbol_size)
#define SYMBOL_OFFSET(p) (SYMLOC(p)->symbol_offset)
#define STRING_OFFSET(p) (SYMLOC(p)->string_offset)
#define FILE_STRING_OFFSET(p) (SYMLOC(p)->file_string_offset)
#define PST_LANGUAGE(p) (SYMLOC(p)->pst_language)
#define INTERNALIZE_SYMBOL(intern, extern, abfd) \
{ \
(intern).n_strx = bfd_h_get_32 (abfd, (extern)->e_strx); \
(intern).n_type = bfd_h_get_8 (abfd, (extern)->e_type); \
(intern).n_other = 0; \
(intern).n_desc = bfd_h_get_16 (abfd, (extern)->e_desc); \
if (bfd_get_sign_extend_vma (abfd)) \
(intern).n_value = bfd_h_get_signed_32 (abfd, (extern)->e_value); \
else \
(intern).n_value = bfd_h_get_32 (abfd, (extern)->e_value); \
}
/* We put a pointer to this structure in the read_symtab_private field
of the psymtab. */