Skip tests that use cd for remote hosts

Several GDB tests change directory before compiling the test program
in order to test source file names that include directories.  This
doesn't work on a remote host because default_target_compile in
DejaGnu's target.exp copies each source file with
"[remote_download host $x]" which uses "[file tail $file] to strip
off the directory of each file.  If the source directory is remote
mounted on the host, this also leaves copied files in the source
directory.

A similar skip is already used in gdb.test/fullname.exp:

    # We rely on being able to copy things around.

    if { [is_remote host] } {
	untested "setting breakpoints by full path"
	return -1
    }

This patch causes three GDB tests that use "cd" to be skipped for a
remote host.  For gdb.base/fullpath-expand.exp this eliminates two
failures and prevents the test from leaving files fullpath-expand.c
and fullpath-expand-func.c in gdb/testsuite.  For
gdb.base/realname-expand.exp it eliminates two failures.  For
gdb.linespec/macro-relative.exp it prevents file macro-relative.c
from being left in gdb/testsuite/gdb.linespec/base/two.

gdb/testsuite/

	* gdb.base/fullpath-expand.exp: Skip for a remote host.
	* gdb.base/realname-expand.exp: Likewise.
	* gdb.linespec/macro-relative.exp: Likewise.
This commit is contained in:
Luis Machado 2014-10-30 09:48:10 -02:00
parent 62cf91a31e
commit 3bdff46b67
4 changed files with 21 additions and 0 deletions

View File

@ -1,3 +1,9 @@
2014-10-30 Janis Johnson <janisjo@codesourcery.com>
* gdb.base/fullpath-expand.exp: Skip for a remote host.
* gdb.base/realname-expand.exp: Likewise.
* gdb.linespec/macro-relative.exp: Likewise.
2014-10-29 Pedro Alves <palves@redhat.com> 2014-10-29 Pedro Alves <palves@redhat.com>
PR gdb/17408 PR gdb/17408

View File

@ -15,6 +15,11 @@
standard_testfile .c fullpath-expand-func.c standard_testfile .c fullpath-expand-func.c
if [is_remote host] {
unsupported "Compiling on a remote host does not support a filename with directory."
return 0
}
if { [file pathtype $objdir] != "absolute" } { if { [file pathtype $objdir] != "absolute" } {
untested "objdir $objdir is not absolute" untested "objdir $objdir is not absolute"
return -1 return -1

View File

@ -15,6 +15,11 @@
standard_testfile .c realname-expand-real.c standard_testfile .c realname-expand-real.c
if [is_remote host] {
unsupported "Compiling on a remote host does not support a filename with directory."
return 0
}
set srcdirabs [file join [pwd] $srcdir] set srcdirabs [file join [pwd] $srcdir]
set srcfilelink [standard_output_file realname-expand-link.c] set srcfilelink [standard_output_file realname-expand-link.c]

View File

@ -21,6 +21,11 @@ if [using_fission] {
return -1 return -1
} }
if [is_remote host] {
unsupported "Compiling on a remote host does not support a filename with directory."
return 0
}
set opts {debug additional_flags=-I.} set opts {debug additional_flags=-I.}
get_compiler_info get_compiler_info