mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-27 12:03:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace unworkable code in HPPA relocs handelr with an assertion.

Browse Source 
* elf64-hppa.c (elf_hppa_final_link_relocate): Replace unworkable
	code with an assertion.
This commit is contained in:
Nick Clifton 2018-08-23 13:34:14 +01:00
parent 334d4ced42
commit 38cf70ca4d
2 changed files with 11 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2018-08-23 Nick Clifton <nickc@redhat.com>
* elf64-hppa.c (elf_hppa_final_link_relocate): Replace unworkable
code with an assertion.
2018-08-23 Nick Clifton <nickc@redhat.com>
PR 23061

33
bfd/elf64-hppa.c
View File

@ -3556,33 +3556,12 @@ elf_hppa_final_link_relocate (Elf_Internal_Rela *rel,
case R_PARISC_LTOFF_FPTR32:
{
/* We may still need to create the FPTR itself if it was for
a local symbol. */
if (hh == NULL)
{
/* The first two words of an .opd entry are zero. */
memset (hppa_info->opd_sec->contents + hh->opd_offset, 0, 16);
/* The next word is the address of the function. */
bfd_put_64 (hppa_info->opd_sec->owner, value + addend,
(hppa_info->opd_sec->contents
+ hh->opd_offset + 16));
/* The last word is our local __gp value. */
value = _bfd_get_gp_value
(hppa_info->opd_sec->output_section->owner);
bfd_put_64 (hppa_info->opd_sec->owner, value,
hppa_info->opd_sec->contents + hh->opd_offset + 24);
/* The DLT value is the address of the .opd entry. */
value = (hh->opd_offset
+ hppa_info->opd_sec->output_offset
+ hppa_info->opd_sec->output_section->vma);
bfd_put_64 (hppa_info->dlt_sec->owner,
value,
hppa_info->dlt_sec->contents + hh->dlt_offset);
}
/* FIXME: There used to be code here to create the FPTR itself if
the relocation was against a local symbol. But the code could
never have worked. If the assert below is ever triggered then
the code will need to be reinstated and fixed so that it does
what is needed. */
BFD_ASSERT (hh != NULL);
/* We want the value of the DLT offset for this symbol, not
the symbol's actual address. Note that __gp may not point