mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-18 14:53:32 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

ld testsuite function pointer comparisons vs. hppa

Browse Source 
ld/testsuite/ld-elf/check-ptr-eq.c fails for hppa, since function
pointers may point at plabels.  It isn't valid to cast two function
pointers to void* and then compare the void pointers.

	* testsuite/ld-elf/check-ptr-eq.c (check_ptr_eq): Change params
	from void pointers to function pointers.
	* testsuite/ld-elf/pr18718.c: Update to suit.
	* testsuite/ld-elf/pr18720a.c: Update to suit.
This commit is contained in:
Alan Modra 2017-02-16 22:19:10 +10:30
parent a8c75b765e
commit 37d7d56cae
4 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ld/ChangeLog
View File

@ -1,3 +1,10 @@
2017-02-16 Alan Modra <amodra@gmail.com>
* testsuite/ld-elf/check-ptr-eq.c (check_ptr_eq): Change params
from void pointers to function pointers.
* testsuite/ld-elf/pr18718.c: Update to suit.
* testsuite/ld-elf/pr18720a.c: Update to suit.
2017-02-16 Alan Modra <amodra@gmail.com>
PR 21000

6
ld/testsuite/ld-elf/check-ptr-eq.c
View File

@ -2,11 +2,11 @@ extern void abort (void);
/* Since GCC 5 folds symbol address comparison, assuming each symbol has
different address, &foo == &bar is always false for GCC 5. Use
check_ptr_eq to check if 2 addresses are the same. */
check_ptr_eq to check if two functions are the same. */
void
check_ptr_eq (void *p1, void *p2)
check_ptr_eq (void (*f1) (void), void (*f2) (void))
{
if (p1 != p2)
if (f1 != f2)
abort ();
}

2
ld/testsuite/ld-elf/pr18718.c
View File

@ -2,7 +2,7 @@
#include <bfd_stdint.h>
extern void foo (void);
extern void check_ptr_eq (void *, void *);
extern void check_ptr_eq (void (*) (void), void (*) (void));
void
new_foo (void)

2
ld/testsuite/ld-elf/pr18720a.c
View File

@ -3,7 +3,7 @@
extern void bar (void);
extern void foo (void);
extern void foo_alias (void);
extern void check_ptr_eq (void *, void *);
extern void check_ptr_eq (void (*) (void), void (*) (void));
#if defined(__GNUC__) && (__GNUC__ * 1000 + __GNUC_MINOR__) >= 4005
__attribute__ ((noinline, noclone))