mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-24 02:24:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[testsuite] gdb.base/dlmopen: Fix test name and use gdb_attach

Browse Source 
One test name in gdb.base/dlmopen.exp changes from run to run
since it includes a process id:

    PASS: gdb.base/dlmopen.exp: attach 3442682

This is not convenient do diff gdb.sum files to compare test runs.

Fix by using gdb_attach helper function to handle attaching to the
process as it produce a constant test name.

While at it also check gdb_attach's return value to only run the
rest of the test if the attach was successful.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Lancelot SIX 2022-11-04 15:36:21 +00:00
parent 45830439ce
commit 36354a49b6
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/testsuite/gdb.base/dlmopen.exp
View File

@ -159,7 +159,9 @@ set test_spawn_id [spawn_wait_for_attach $binfile]
set testpid [spawn_id_get_pid $test_spawn_id]
# Attach.
gdb_test "attach $testpid" "Attaching to program.*, process $testpid.*"
if { ![gdb_attach $testpid] } {
return
}
with_test_prefix "attach" {
# Remove the pause. We no longer need it.