mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-18 06:43:36 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Issue error on erroneous expression

Browse Source 
A while back I discovered that this does not issue an error:

    (gdb) p $x = (void * ) 57
    $3 = (void *) 0x39
    (gdb) p $x + 7 = 3
    $6 = (void *) 0x3

This patch fixes the bug.
Regression tested on x86-64 Fedora 36.

Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19312
This commit is contained in:
Tom Tromey 2023-02-17 19:55:50 -05:00
parent 4c9066e322
commit 3592bebbbf
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/testsuite/gdb.base/gdbvars.exp
View File

@ -66,6 +66,14 @@ proc test_convenience_variables {} {
gdb_test "print \$arr = {0, 1, 2, 3}" \
" = \\{0, 1, 2, 3\\}" \
"Set convenience variable to different array value"
gdb_test "print \$ptr = (void *) 7" \
" = \\(void \\*\\) 0x7" \
"set convenience variable to pointer value"
# This used to "succeed".
gdb_test "print \$ptr + 23 = 97" \
"Left operand of assignment is not an lvalue." \
"reject invalid assignment"
}
proc test_convenience_functions {} {

2
gdb/valarith.c
View File

@ -93,7 +93,7 @@ value_ptradd (struct value *arg1, LONGEST arg2)
result = value_from_pointer (valptrtype,
value_as_address (arg1) + sz * arg2);
if (result->lval () != lval_internalvar)
if (arg1->lval () != lval_internalvar)
result->set_component_location (arg1);
return result;
}