mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-23 18:14:13 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Check asprintf return value

Browse Source 
git a31b8bd9a0 introduced a warning (depending on your system
headers).

	PR 24225
	* elf32-nios2.c (nios2_elf32_relocate_section): Check asprintf
	return value.
This commit is contained in:
Alan Modra 2019-02-20 18:54:41 +10:30
parent c22b42ce30
commit 34d75fb5c4
2 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2019-02-20 Alan Modra <amodra@gmail.com>
PR 24225
* elf32-nios2.c (nios2_elf32_relocate_section): Check asprintf
return value.
2019-02-20 Michael Roitzsch <reactorcontrol@icloud.com> 2019-02-20 Michael Roitzsch <reactorcontrol@icloud.com>
* configure.ac (SHARED_LIBADD): Add -liberty -lintl for all * configure.ac (SHARED_LIBADD): Add -liberty -lintl for all

11
bfd/elf32-nios2.c
View File

@ -3821,7 +3821,9 @@ nios2_elf32_relocate_section (bfd *output_bfd,
format = _("global pointer relative relocation at address " format = _("global pointer relative relocation at address "
"%#" PRIx64 " when _gp not defined\n"); "%#" PRIx64 " when _gp not defined\n");
asprintf (&msgbuf, format, (uint64_t) reloc_address); if (asprintf (&msgbuf, format,
(uint64_t) reloc_address) == -1)
msgbuf = NULL;
msg = msgbuf; msg = msgbuf;
r = bfd_reloc_dangerous; r = bfd_reloc_dangerous;
} }
@ -3851,9 +3853,10 @@ nios2_elf32_relocate_section (bfd *output_bfd,
"the global pointer (at %#" PRIx64 ") " "the global pointer (at %#" PRIx64 ") "
"because the offset (%" PRId64 ") is out of " "because the offset (%" PRId64 ") is out of "
"the allowed range, -32678 to 32767\n" ); "the allowed range, -32678 to 32767\n" );
asprintf (&msgbuf, format, name, if (asprintf (&msgbuf, format, name,
(uint64_t) symbol_address, (uint64_t) gp, (uint64_t) symbol_address, (uint64_t) gp,
(int64_t) relocation); (int64_t) relocation) == -1)
msgbuf = NULL;
msg = msgbuf; msg = msgbuf;
r = bfd_reloc_outofrange; r = bfd_reloc_outofrange;
} }