mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-25 02:53:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

PR tdep/14222

Browse Source 
* i386-tdep.c (i386_push_dummy_call): Unconditionally align the
        stack on a 16-byte boundary.
This commit is contained in:
Mark Kettenis 2012-06-13 21:21:25 +00:00
parent 2535757a2b
commit 284c5a60c3
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2012-06-13 Mark Kettenis <kettenis@gnu.org>
Jan Kratochvil <jan.kratochvil@redhat.com>
PR tdep/14222
* i386-tdep.c (i386_push_dummy_call): Unconditionally align the
stack on a 16-byte boundary.
2012-06-13 Kaushik Srenevasan <kaushik@twitter.com> 2012-06-13 Kaushik Srenevasan <kaushik@twitter.com>
* jit.c (finalize_symtab): Set function's return type to 'void' by * jit.c (finalize_symtab): Set function's return type to 'void' by

14
gdb/i386-tdep.c
View File

@ -2351,7 +2351,6 @@ i386_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
for (write_pass = 0; write_pass < 2; write_pass++) for (write_pass = 0; write_pass < 2; write_pass++)
{ {
int args_space_used = 0; int args_space_used = 0;
int have_16_byte_aligned_arg = 0;
if (struct_return) if (struct_return)
{ {
@ -2389,19 +2388,20 @@ i386_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
else else
{ {
if (i386_16_byte_align_p (value_enclosing_type (args[i]))) if (i386_16_byte_align_p (value_enclosing_type (args[i])))
{ args_space = align_up (args_space, 16);
args_space = align_up (args_space, 16);
have_16_byte_aligned_arg = 1;
}
args_space += align_up (len, 4); args_space += align_up (len, 4);
} }
} }
if (!write_pass) if (!write_pass)
{ {
if (have_16_byte_aligned_arg)
args_space = align_up (args_space, 16);
sp -= args_space; sp -= args_space;
/* The original System V ABI only requires word alignment,
but modern incarnations need 16-byte alignment in order
to support SSE. Since wasting a few bytes here isn't
harmful we unconditionally enforce 16-byte alignment. */
sp &= ~0xf;
} }
} }