mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-29 13:04:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

sim: ppc: collapse is_valid switch table more

Browse Source 
Instead of writing:
  case 1:
    return 1;
  case 2:
    return 1;
  ...etc...

Output a single return so we get:
  case 1:
  case 2:
  case ...
    return 1;

This saves ~100 lines of code.  Hopefully the compiler was already
smart enough to optimize to the same code, but if not, this probably
helps there too :).
This commit is contained in:
Mike Frysinger 2022-11-10 02:15:34 +07:00
parent 99961e814f
commit 1eff12f75a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sim/ppc/dgen.c
View File

@ -240,7 +240,7 @@ gen_spreg_c(spreg_table *table, lf *file)
for (entry = table->sprs; entry != NULL; entry = entry->next) {
lf_printf(file, " case %d:\n", entry->spreg_nr);
if (strcmp(*attribute, "is_valid") == 0)
lf_printf(file, " return 1;\n");
/* No return -- see below. */;
else if (strcmp(*attribute, "is_readonly") == 0)
lf_printf(file, " return %d;\n", entry->is_readonly);
else if (strcmp(*attribute, "length") == 0)
@ -248,6 +248,9 @@ gen_spreg_c(spreg_table *table, lf *file)
else
ASSERT(0);
}
/* Output a single return for is_valid. */
if (strcmp(*attribute, "is_valid") == 0)
lf_printf(file, " return 1;\n");
lf_printf(file, " }\n");
lf_printf(file, " return 0;\n");
}