mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-23 10:03:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Prevent the linker from overestimating the alignment requirement of common symbols on targets with octets that are larger than one byte.

Browse Source 
PR 26543
	* linker.c (bfd_generic_define_common_symbol): Force the alignment
	to 1 if the section has now alignment requirement.
This commit is contained in:
Tuckker 2020-08-28 13:27:16 +01:00 committed by Nick Clifton
parent 626d23209f
commit 1e597a8997
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2020-08-28 Tuckker <tuckkern+sourceware@gmail.com>
PR 26543
* linker.c (bfd_generic_define_common_symbol): Force the alignment
to 1 if the section has now alignment requirement.
2020-08-28 Cooper Qu <cooper.qu@linux.alibaba.com>
* elf32-csky.c (csky_archs): Fix arch names.

9
bfd/linker.c
View File

@ -3095,8 +3095,13 @@ bfd_generic_define_common_symbol (bfd *output_bfd,
section = h->u.c.p->section;
/* Increase the size of the section to align the common symbol.
The alignment must be a power of two. */
alignment = bfd_octets_per_byte (output_bfd, section) << power_of_two;
The alignment must be a power of two. But if the section does
not have any alignment requirement then do not increase the
alignment unnecessarily. */
if (power_of_two)
alignment = bfd_octets_per_byte (output_bfd, section) << power_of_two;
else
alignment = 1;
BFD_ASSERT (alignment != 0 && (alignment & -alignment) == alignment);
section->size += alignment - 1;
section->size &= -alignment;