mirrors/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-24 10:35:12 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add extra linker warning message about discrepancies between normal and common symbols.

Browse Source 
PR 30499
  bfd * elflink.c (elf_link_add_object_symbols): Add a message indicating that alignment and size discrepancies between the definition of common symbols and normal symbols are serious and should be investigated.
  ld  * testsuite/ld-elfcomm/elfcomm.exp: Update regexps to match new output from the linker.
This commit is contained in:
Nick Clifton 2023-06-07 14:30:13 +01:00
parent dcb1634645
commit 064ad3ea5e
4 changed files with 35 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bfd/ChangeLog
View File

@ -1,3 +1,11 @@
2023-06-07 Nick Clifton <nickc@redhat.com>
PR 30499
* elflink.c (elf_link_add_object_symbols): Add a message
indicating that alignment and size discrepancies between the
definition of common symbols and normal symbols are serious and
should be investigated.
2023-05-31 Tristan Gingold <tgingold@free.fr>
PR 30444

26
bfd/elflink.c
View File

@ -5302,10 +5302,14 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info)
else
_bfd_error_handler
/* xgettext:c-format */
(_("warning: alignment %u of symbol `%s' in %pB"
" is smaller than %u in %pB"),
(_("warning: alignment %u of normal symbol `%s' in %pB"
" is smaller than %u used by the common definition in %pB"),
1 << normal_align, name, normal_bfd,
1 << common_align, common_bfd);
/* PR 30499: make sure that users understand that this warning is serious. */
_bfd_error_handler
(_("warning: NOTE: alignment discrepancies can cause real problems. Investigation is advised."));
}
}
@ -5317,12 +5321,18 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info)
if (h->size != 0
&& h->size != isym->st_size
&& ! size_change_ok)
_bfd_error_handler
/* xgettext:c-format */
(_("warning: size of symbol `%s' changed"
" from %" PRIu64 " in %pB to %" PRIu64 " in %pB"),
name, (uint64_t) h->size, old_bfd,
(uint64_t) isym->st_size, abfd);
{
_bfd_error_handler
/* xgettext:c-format */
(_("warning: size of symbol `%s' changed"
" from %" PRIu64 " in %pB to %" PRIu64 " in %pB"),
name, (uint64_t) h->size, old_bfd,
(uint64_t) isym->st_size, abfd);
/* PR 30499: make sure that users understand that this warning is serious. */
_bfd_error_handler
(_("warning: NOTE: size discrepancies can cause real problems. Investigation is advised."));
}
h->size = isym->st_size;
}

6
ld/ChangeLog
View File

@ -1,3 +1,9 @@
2023-06-07 Nick Clifton <nickc@redhat.com>
PR 30499
* testsuite/ld-elfcomm/elfcomm.exp: Update regexps to match new
output from the linker.
2023-05-17 Luca Bacci <luca.bacci@outlook.com>
PR 30421

6
ld/testsuite/ld-elfcomm/elfcomm.exp
View File

@ -186,13 +186,13 @@ if { [ld_link $ld tmpdir/common1.o $options] } {
# This test fails on MIPS because the backend sets type_change_ok.
# The size change warning is suppressed. Same on hppa64.
if {[istarget mips*-*-*] || [istarget hppa*64*-*-*]} {
if { ![regexp "warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
if { ![regexp "warning: alignment (\[0-9\]+) of normal symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 used by the common definition in tmpdir/common1a.o" $link_output] } {
fail $test1w1
} else {
pass $test1w1
}
} else {
if { ![regexp "warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output]
if { ![regexp "warning: alignment (\[0-9\]+) of normal symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 used by the common definition in tmpdir/common1a.o" $link_output]
|| ![regexp "warning: size of symbol \`_?foo1\' changed from 2 in tmpdir/common1a.o to 21 in tmpdir/common1b.o" $link_output] } {
fail $test1w1
} else {
@ -211,7 +211,7 @@ if { [ld_link $ld tmpdir/common1.o $options] } {
return
}
if { ![regexp "warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
if { ![regexp "warning: alignment (\[0-9\]+) of normal symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 used by the common definition in tmpdir/common1a.o" $link_output] } {
fail $test1w2
} else {
pass $test1w2