mirrors/binutils-gdb
0
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-11-30 13:33:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Change program_space_empty_p to method on program_space

Browse Source 
This changes program_space_empty_p to be a method on program_space.
It also changes it to return bool.  I removed the "_p" suffix because
"empty" is a "well-known" C++ method name.

gdb/ChangeLog
2020-10-29  Tom Tromey  <tom@tromey.com>

	* inferior.c (delete_inferior): Update.
	* progspace.c (program_space::empty): Rename from
	program_space_empty_p.  Return bool.
	* progspace.h (struct program_space) <empty>: New method.
	(program_space_empty_p): Don't declare.
This commit is contained in:
Tom Tromey 2020-10-29 15:04:33 -06:00
parent e39fb97114
commit 004eecfdc7
4 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2020-10-29 Tom Tromey <tom@tromey.com>
* inferior.c (delete_inferior): Update.
* progspace.c (program_space::empty): Rename from
program_space_empty_p. Return bool.
* progspace.h (struct program_space) <empty>: New method.
(program_space_empty_p): Don't declare.
2020-10-29 Tom Tromey <tom@tromey.com>
* progspace.c (program_space::~program_space): Don't call

2
gdb/inferior.c
View File

@ -175,7 +175,7 @@ delete_inferior (struct inferior *todel)
gdb::observers::inferior_removed.notify (inf);
/* If this program space is rendered useless, remove it. */
if (program_space_empty_p (inf->pspace))
if (inf->pspace->empty ())
delete inf->pspace;
delete inf;

9
gdb/progspace.c
View File

@ -280,13 +280,10 @@ set_current_program_space (struct program_space *pspace)
/* Returns true iff there's no inferior bound to PSPACE. */
int
program_space_empty_p (struct program_space *pspace)
bool
program_space::empty ()
{
if (find_inferior_for_program_space (pspace) != NULL)
return 0;
return 1;
return find_inferior_for_program_space (this) == nullptr;
}
/* Prints the list of program spaces and their details on UIOUT. If

7
gdb/progspace.h
View File

@ -293,6 +293,10 @@ struct program_space
later be printed. */
void clear_solib_cache ();
/* Returns true iff there's no inferior bound to this program
space. */
bool empty ();
/* Unique ID number. */
int num = 0;
@ -383,9 +387,6 @@ extern std::vector<struct program_space *>program_spaces;
/* The current program space. This is always non-null. */
extern struct program_space *current_program_space;
/* Returns true iff there's no inferior bound to PSPACE. */
extern int program_space_empty_p (struct program_space *pspace);
/* Copies program space SRC to DEST. Copies the main executable file,
and the main symbol file. Returns DEST. */
extern struct program_space *clone_program_space (struct program_space *dest,