* tuiWin.c, tuiWin.h, tui.c, tui.h, tuiCommand.c: Add FSF copyright.
tuiCommand.h, tuiIO.c, tuiIO.h, tuiData.h, tuiData.c: Likewise.
tuiDataWin.c, tuiDataWin.h, tuiDisassem.c, tuiDisassem.h: Likewise.
tuiGeneralWin.c, tuiGeneralWin.h, tuiLayout.c, tuiLayout.h: Likewise.
tuiRegs.c, tuiRegs.h, tuiSource.c, tuiSource.h: Likewise.
tuiSouceWin.c, tuiSourceWin.h, tuiStack.c, tuiStack.h: Likewise.
2001-07-15 03:01:25 +08:00
|
|
|
/* Disassembly display.
|
2004-01-21 05:56:22 +08:00
|
|
|
|
2024-01-12 23:30:44 +08:00
|
|
|
Copyright (C) 1998-2024 Free Software Foundation, Inc.
|
2004-01-21 05:56:22 +08:00
|
|
|
|
* tuiWin.c, tuiWin.h, tui.c, tui.h, tuiCommand.c: Add FSF copyright.
tuiCommand.h, tuiIO.c, tuiIO.h, tuiData.h, tuiData.c: Likewise.
tuiDataWin.c, tuiDataWin.h, tuiDisassem.c, tuiDisassem.h: Likewise.
tuiGeneralWin.c, tuiGeneralWin.h, tuiLayout.c, tuiLayout.h: Likewise.
tuiRegs.c, tuiRegs.h, tuiSource.c, tuiSource.h: Likewise.
tuiSouceWin.c, tuiSourceWin.h, tuiStack.c, tuiStack.h: Likewise.
2001-07-15 03:01:25 +08:00
|
|
|
Contributed by Hewlett-Packard Company.
|
|
|
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
|
it under the terms of the GNU General Public License as published by
|
2007-08-24 02:08:50 +08:00
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
* tuiWin.c, tuiWin.h, tui.c, tui.h, tuiCommand.c: Add FSF copyright.
tuiCommand.h, tuiIO.c, tuiIO.h, tuiData.h, tuiData.c: Likewise.
tuiDataWin.c, tuiDataWin.h, tuiDisassem.c, tuiDisassem.h: Likewise.
tuiGeneralWin.c, tuiGeneralWin.h, tuiLayout.c, tuiLayout.h: Likewise.
tuiRegs.c, tuiRegs.h, tuiSource.c, tuiSource.h: Likewise.
tuiSouceWin.c, tuiSourceWin.h, tuiStack.c, tuiStack.h: Likewise.
2001-07-15 03:01:25 +08:00
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
2007-08-24 02:08:50 +08:00
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
* tuiWin.c, tuiWin.h, tui.c, tui.h, tuiCommand.c: Add FSF copyright.
tuiCommand.h, tuiIO.c, tuiIO.h, tuiData.h, tuiData.c: Likewise.
tuiDataWin.c, tuiDataWin.h, tuiDisassem.c, tuiDisassem.h: Likewise.
tuiGeneralWin.c, tuiGeneralWin.h, tuiLayout.c, tuiLayout.h: Likewise.
tuiRegs.c, tuiRegs.h, tuiSource.c, tuiSource.h: Likewise.
tuiSouceWin.c, tuiSourceWin.h, tuiStack.c, tuiStack.h: Likewise.
2001-07-15 03:01:25 +08:00
|
|
|
|
2019-01-28 03:51:36 +08:00
|
|
|
#ifndef TUI_TUI_DISASM_H
|
|
|
|
|
#define TUI_TUI_DISASM_H
|
1999-04-16 09:35:26 +08:00
|
|
|
|
2019-07-03 05:54:08 +08:00
|
|
|
#include "tui/tui.h"
|
|
|
|
|
#include "tui/tui-data.h"
|
2019-07-03 07:07:02 +08:00
|
|
|
#include "tui-winsource.h"
|
2019-07-03 05:54:08 +08:00
|
|
|
|
|
|
|
|
/* A TUI disassembly window. */
|
|
|
|
|
|
|
|
|
|
struct tui_disasm_window : public tui_source_window_base
|
|
|
|
|
{
|
2020-02-23 02:48:26 +08:00
|
|
|
tui_disasm_window () = default;
|
2019-07-03 05:54:08 +08:00
|
|
|
|
|
|
|
|
DISABLE_COPY_AND_ASSIGN (tui_disasm_window);
|
|
|
|
|
|
|
|
|
|
const char *name () const override
|
|
|
|
|
{
|
|
|
|
|
return DISASSEM_NAME;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool location_matches_p (struct bp_location *loc, int line_no) override;
|
|
|
|
|
|
gdb: pass frames as `const frame_info_ptr &`
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
2024-02-20 02:07:47 +08:00
|
|
|
void maybe_update (const frame_info_ptr &fi, symtab_and_line sal) override;
|
2019-07-07 05:04:12 +08:00
|
|
|
|
2019-07-07 05:57:53 +08:00
|
|
|
void erase_source_content () override
|
|
|
|
|
{
|
2019-07-14 05:45:14 +08:00
|
|
|
do_erase_source_content (_("[ No Assembly Available ]"));
|
2019-07-07 05:57:53 +08:00
|
|
|
}
|
|
|
|
|
|
2020-02-23 02:48:26 +08:00
|
|
|
void display_start_addr (struct gdbarch **gdbarch_p,
|
|
|
|
|
CORE_ADDR *addr_p) override;
|
|
|
|
|
|
2019-07-03 05:54:08 +08:00
|
|
|
protected:
|
|
|
|
|
|
|
|
|
|
void do_scroll_vertical (int num_to_scroll) override;
|
2019-07-07 05:06:47 +08:00
|
|
|
|
2019-11-13 08:26:50 +08:00
|
|
|
bool set_contents (struct gdbarch *gdbarch,
|
Use symtab_and_line when updating TUI windows
This changes a few TUI source window methods to take a symtab_and_line
rather than separate symtab and tui_line_or_address parameters. A
symtab_and_line already incorporates the same information, so this
seemed simpler. Also, it helps avoid the problem that the source and
disassembly windows need different information -- both forms are
present in the SAL.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)
<set_contents, update_source_window_as_is, update_source_window>:
Take a sal, not a separate symtab and tui_line_or_address.
* tui/tui-winsource.c (tui_source_window_base::update_source_window)
(tui_source_window_base::update_source_window_as_is): Take a sal,
not a separate symtab and tui_line_or_address.
(tui_update_source_windows_with_addr)
(tui_update_source_windows_with_line)
(tui_source_window_base::rerender)
(tui_source_window_base::refill): Update.
* tui/tui-source.h (struct tui_source_window) <set_contents>: Take
a sal, not a separate symtab and tui_line_or_address.
* tui/tui-source.c (tui_source_window::set_contents): Take a sal,
not a separate symtab and tui_line_or_address.
(tui_source_window::maybe_update): Update.
* tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
a sal, not a separate symtab and tui_line_or_address.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
not a separate symtab and tui_line_or_address.
(tui_disasm_window::do_scroll_vertical)
(tui_disasm_window::maybe_update): Update.
Change-Id: I6974a03589930a0f910c657ef50b7f6f7397c87d
2019-11-13 08:56:42 +08:00
|
|
|
const struct symtab_and_line &sal) override;
|
2019-07-12 08:42:20 +08:00
|
|
|
|
2019-07-07 05:06:47 +08:00
|
|
|
private:
|
|
|
|
|
/* Answer whether a particular line number or address is displayed
|
|
|
|
|
in the current source window. */
|
|
|
|
|
bool addr_is_displayed (CORE_ADDR addr) const;
|
2019-07-03 05:54:08 +08:00
|
|
|
};
|
1999-04-16 09:35:26 +08:00
|
|
|
|
2009-07-03 01:17:42 +08:00
|
|
|
extern void tui_get_begin_asm_address (struct gdbarch **, CORE_ADDR *);
|
1999-04-16 09:35:26 +08:00
|
|
|
|
2019-01-28 03:51:36 +08:00
|
|
|
#endif /* TUI_TUI_DISASM_H */
|
