gdb/arm: add support for bare-metal core dumps
This commit adds support for bare metal core dumps on the ARM target,
and is based off of this patch submitted to the mailing list:
https://sourceware.org/pipermail/gdb-patches/2020-October/172845.html
Compared to the version linked above this version is updated to take
account of recent changes to the core dump infrastructure in GDB,
there is now more shared infrastructure for core dumping within GDB,
and also some common bare metal core dumping infrastructure. As a
result this patch is smaller than the original proposed patch.
Further, the original patch included some unrelated changes to the
simulator that have been removed from this version.
I have written a ChangeLog entry as the original patch was missing
one.
I have done absolutely no testing of this patch. It is based on the
original submitted patch, which I assume was tested, but after my
modifications things might have been broken, however, the original
patch author has tested this version and reported it as being good:
https://sourceware.org/pipermail/gdb-patches/2021-May/178900.html
The core dump format is based around generating an ELF containing
sections for the writable regions of memory that a user could be
using. Which regions are dumped rely on GDB's existing common core
dumping code, GDB will attempt to figure out the stack and heap as
well as copying out writable data sections as identified by the
original ELF.
Register information is added to the core dump using notes, just as it
is for Linux of FreeBSD core dumps. The note types used consist of
the 2 basic types you would expect in a OS based core dump,
NT_PRPSINFO, NT_PRSTATUS, along with the architecture specific
NT_ARM_VFP note.
The data layouts for each note type are described below, in all cases,
all padding fields should be set to zero.
Note NT_PRPSINFO is optional. Its data layout is:
struct prpsinfo_t
{
uint8_t padding[28];
char fname[16];
char psargs[80];
}
Field 'fname' - null terminated string consisting of the basename of
(up to the fist 15 characters of) the executable. Any additional
space should be set to zero. If there's no executable name then
this field can be set to all zero.
Field 'psargs' - a null terminated string up to 80 characters in
length. Any additional space should be filled with zero. This
field contains the full executable path and any arguments passed
to the executable. If there's nothing sensible to write in this
field then fill it with zero.
Note NT_PRSTATUS is required, its data layout is:
struct prstatus_t
{
uint8_t padding_1[12];
uint16_t sig;
uint8_t padding_2[10];
uint32_t thread_id;
uint8_t padding_3[44];
uint32_t gregs[18];
}
Field 'sig' - the signal that stopped this thread. It's implementation
defined what this field actually means. Within GDB this will be
the signal number that the remote target reports as the stop
reason for this thread.
Field 'thread_is' - the thread id for this thread. It's implementation
defined what this field actually means. Within GDB this will be
thread thread-id that is assigned to each remote thread.
Field 'gregs' - holds the general purpose registers $a1 through to $pc
at indices 0 to 15. At index 16 the program status register.
Index 17 should be set to zero.
Note NT_ARM_VFP is optional, its data layout is:
armvfp_t
{
uint64_t regs[32];
uint32_t fpscr;
}
Field 'regs' - holds the 32 d-registers 0 to 31 in order.
Field 'fpscr' - holds the fpscr register.
The rules for ordering the notes is the same as for Linux. The
NT_PRSTATUS note must come before any other notes about additional
register sets. And for multi-threaded targets all registers for a
single thread should be grouped together. This is because only
NT_PRSTATUS includes a thread-id, all additional register notes after
a NT_PRSTATUS are assumed to belong to the same thread until a
different NT_PRSTATUS is seen.
gdb/ChangeLog:
PR gdb/14383
* Makefile.in (ALL_TARGET_OBS): Add arm-none-tdep.o.
(ALLDEPFILES): Add arm-none-tdep.c
* arm-none-tdep.c: New file.
* configure.tgt (arm*-*-*): Add arm-none-tdep.o to cpu_obs.
2021-01-20 23:13:16 +08:00
|
|
|
/* none on ARM target support.
|
|
|
|
|
|
2024-01-12 23:30:44 +08:00
|
|
|
Copyright (C) 2020-2024 Free Software Foundation, Inc.
|
gdb/arm: add support for bare-metal core dumps
This commit adds support for bare metal core dumps on the ARM target,
and is based off of this patch submitted to the mailing list:
https://sourceware.org/pipermail/gdb-patches/2020-October/172845.html
Compared to the version linked above this version is updated to take
account of recent changes to the core dump infrastructure in GDB,
there is now more shared infrastructure for core dumping within GDB,
and also some common bare metal core dumping infrastructure. As a
result this patch is smaller than the original proposed patch.
Further, the original patch included some unrelated changes to the
simulator that have been removed from this version.
I have written a ChangeLog entry as the original patch was missing
one.
I have done absolutely no testing of this patch. It is based on the
original submitted patch, which I assume was tested, but after my
modifications things might have been broken, however, the original
patch author has tested this version and reported it as being good:
https://sourceware.org/pipermail/gdb-patches/2021-May/178900.html
The core dump format is based around generating an ELF containing
sections for the writable regions of memory that a user could be
using. Which regions are dumped rely on GDB's existing common core
dumping code, GDB will attempt to figure out the stack and heap as
well as copying out writable data sections as identified by the
original ELF.
Register information is added to the core dump using notes, just as it
is for Linux of FreeBSD core dumps. The note types used consist of
the 2 basic types you would expect in a OS based core dump,
NT_PRPSINFO, NT_PRSTATUS, along with the architecture specific
NT_ARM_VFP note.
The data layouts for each note type are described below, in all cases,
all padding fields should be set to zero.
Note NT_PRPSINFO is optional. Its data layout is:
struct prpsinfo_t
{
uint8_t padding[28];
char fname[16];
char psargs[80];
}
Field 'fname' - null terminated string consisting of the basename of
(up to the fist 15 characters of) the executable. Any additional
space should be set to zero. If there's no executable name then
this field can be set to all zero.
Field 'psargs' - a null terminated string up to 80 characters in
length. Any additional space should be filled with zero. This
field contains the full executable path and any arguments passed
to the executable. If there's nothing sensible to write in this
field then fill it with zero.
Note NT_PRSTATUS is required, its data layout is:
struct prstatus_t
{
uint8_t padding_1[12];
uint16_t sig;
uint8_t padding_2[10];
uint32_t thread_id;
uint8_t padding_3[44];
uint32_t gregs[18];
}
Field 'sig' - the signal that stopped this thread. It's implementation
defined what this field actually means. Within GDB this will be
the signal number that the remote target reports as the stop
reason for this thread.
Field 'thread_is' - the thread id for this thread. It's implementation
defined what this field actually means. Within GDB this will be
thread thread-id that is assigned to each remote thread.
Field 'gregs' - holds the general purpose registers $a1 through to $pc
at indices 0 to 15. At index 16 the program status register.
Index 17 should be set to zero.
Note NT_ARM_VFP is optional, its data layout is:
armvfp_t
{
uint64_t regs[32];
uint32_t fpscr;
}
Field 'regs' - holds the 32 d-registers 0 to 31 in order.
Field 'fpscr' - holds the fpscr register.
The rules for ordering the notes is the same as for Linux. The
NT_PRSTATUS note must come before any other notes about additional
register sets. And for multi-threaded targets all registers for a
single thread should be grouped together. This is because only
NT_PRSTATUS includes a thread-id, all additional register notes after
a NT_PRSTATUS are assumed to belong to the same thread until a
different NT_PRSTATUS is seen.
gdb/ChangeLog:
PR gdb/14383
* Makefile.in (ALL_TARGET_OBS): Add arm-none-tdep.o.
(ALLDEPFILES): Add arm-none-tdep.c
* arm-none-tdep.c: New file.
* configure.tgt (arm*-*-*): Add arm-none-tdep.o to cpu_obs.
2021-01-20 23:13:16 +08:00
|
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
|
|
#include "arm-tdep.h"
|
|
|
|
|
#include "arch-utils.h"
|
2024-04-23 04:10:14 +08:00
|
|
|
#include "extract-store-integer.h"
|
gdb/arm: add support for bare-metal core dumps
This commit adds support for bare metal core dumps on the ARM target,
and is based off of this patch submitted to the mailing list:
https://sourceware.org/pipermail/gdb-patches/2020-October/172845.html
Compared to the version linked above this version is updated to take
account of recent changes to the core dump infrastructure in GDB,
there is now more shared infrastructure for core dumping within GDB,
and also some common bare metal core dumping infrastructure. As a
result this patch is smaller than the original proposed patch.
Further, the original patch included some unrelated changes to the
simulator that have been removed from this version.
I have written a ChangeLog entry as the original patch was missing
one.
I have done absolutely no testing of this patch. It is based on the
original submitted patch, which I assume was tested, but after my
modifications things might have been broken, however, the original
patch author has tested this version and reported it as being good:
https://sourceware.org/pipermail/gdb-patches/2021-May/178900.html
The core dump format is based around generating an ELF containing
sections for the writable regions of memory that a user could be
using. Which regions are dumped rely on GDB's existing common core
dumping code, GDB will attempt to figure out the stack and heap as
well as copying out writable data sections as identified by the
original ELF.
Register information is added to the core dump using notes, just as it
is for Linux of FreeBSD core dumps. The note types used consist of
the 2 basic types you would expect in a OS based core dump,
NT_PRPSINFO, NT_PRSTATUS, along with the architecture specific
NT_ARM_VFP note.
The data layouts for each note type are described below, in all cases,
all padding fields should be set to zero.
Note NT_PRPSINFO is optional. Its data layout is:
struct prpsinfo_t
{
uint8_t padding[28];
char fname[16];
char psargs[80];
}
Field 'fname' - null terminated string consisting of the basename of
(up to the fist 15 characters of) the executable. Any additional
space should be set to zero. If there's no executable name then
this field can be set to all zero.
Field 'psargs' - a null terminated string up to 80 characters in
length. Any additional space should be filled with zero. This
field contains the full executable path and any arguments passed
to the executable. If there's nothing sensible to write in this
field then fill it with zero.
Note NT_PRSTATUS is required, its data layout is:
struct prstatus_t
{
uint8_t padding_1[12];
uint16_t sig;
uint8_t padding_2[10];
uint32_t thread_id;
uint8_t padding_3[44];
uint32_t gregs[18];
}
Field 'sig' - the signal that stopped this thread. It's implementation
defined what this field actually means. Within GDB this will be
the signal number that the remote target reports as the stop
reason for this thread.
Field 'thread_is' - the thread id for this thread. It's implementation
defined what this field actually means. Within GDB this will be
thread thread-id that is assigned to each remote thread.
Field 'gregs' - holds the general purpose registers $a1 through to $pc
at indices 0 to 15. At index 16 the program status register.
Index 17 should be set to zero.
Note NT_ARM_VFP is optional, its data layout is:
armvfp_t
{
uint64_t regs[32];
uint32_t fpscr;
}
Field 'regs' - holds the 32 d-registers 0 to 31 in order.
Field 'fpscr' - holds the fpscr register.
The rules for ordering the notes is the same as for Linux. The
NT_PRSTATUS note must come before any other notes about additional
register sets. And for multi-threaded targets all registers for a
single thread should be grouped together. This is because only
NT_PRSTATUS includes a thread-id, all additional register notes after
a NT_PRSTATUS are assumed to belong to the same thread until a
different NT_PRSTATUS is seen.
gdb/ChangeLog:
PR gdb/14383
* Makefile.in (ALL_TARGET_OBS): Add arm-none-tdep.o.
(ALLDEPFILES): Add arm-none-tdep.c
* arm-none-tdep.c: New file.
* configure.tgt (arm*-*-*): Add arm-none-tdep.o to cpu_obs.
2021-01-20 23:13:16 +08:00
|
|
|
#include "regcache.h"
|
|
|
|
|
#include "elf-bfd.h"
|
|
|
|
|
#include "regset.h"
|
|
|
|
|
#include "user-regs.h"
|
|
|
|
|
|
|
|
|
|
#ifdef HAVE_ELF
|
|
|
|
|
#include "elf-none-tdep.h"
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
/* Core file and register set support. */
|
|
|
|
|
#define ARM_NONE_SIZEOF_GREGSET (18 * ARM_INT_REGISTER_SIZE)
|
|
|
|
|
|
|
|
|
|
/* Support VFP register format. */
|
|
|
|
|
#define ARM_NONE_SIZEOF_VFP (32 * 8 + 4)
|
|
|
|
|
|
|
|
|
|
/* The index to access CPSR in user_regs as defined in GLIBC. */
|
|
|
|
|
#define ARM_NONE_CPSR_GREGNUM 16
|
|
|
|
|
|
|
|
|
|
/* Supply register REGNUM from buffer GREGS_BUF (length LEN bytes) into
|
|
|
|
|
REGCACHE. If REGNUM is -1 then supply all registers. The set of
|
|
|
|
|
registers that this function will supply is limited to the general
|
|
|
|
|
purpose registers.
|
|
|
|
|
|
|
|
|
|
The layout of the registers here is based on the ARM GNU/Linux
|
|
|
|
|
layout. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
arm_none_supply_gregset (const struct regset *regset,
|
|
|
|
|
struct regcache *regcache,
|
|
|
|
|
int regnum, const void *gregs_buf, size_t len)
|
|
|
|
|
{
|
|
|
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
|
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
|
|
|
const gdb_byte *gregs = (const gdb_byte *) gregs_buf;
|
|
|
|
|
|
|
|
|
|
for (int regno = ARM_A1_REGNUM; regno < ARM_PC_REGNUM; regno++)
|
|
|
|
|
if (regnum == -1 || regnum == regno)
|
|
|
|
|
regcache->raw_supply (regno, gregs + ARM_INT_REGISTER_SIZE * regno);
|
|
|
|
|
|
|
|
|
|
if (regnum == ARM_PS_REGNUM || regnum == -1)
|
|
|
|
|
{
|
|
|
|
|
if (arm_apcs_32)
|
|
|
|
|
regcache->raw_supply (ARM_PS_REGNUM,
|
|
|
|
|
gregs + ARM_INT_REGISTER_SIZE
|
|
|
|
|
* ARM_NONE_CPSR_GREGNUM);
|
|
|
|
|
else
|
|
|
|
|
regcache->raw_supply (ARM_PS_REGNUM,
|
|
|
|
|
gregs + ARM_INT_REGISTER_SIZE * ARM_PC_REGNUM);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (regnum == ARM_PC_REGNUM || regnum == -1)
|
|
|
|
|
{
|
|
|
|
|
gdb_byte pc_buf[ARM_INT_REGISTER_SIZE];
|
|
|
|
|
|
|
|
|
|
CORE_ADDR reg_pc
|
|
|
|
|
= extract_unsigned_integer (gregs + ARM_INT_REGISTER_SIZE
|
|
|
|
|
* ARM_PC_REGNUM,
|
|
|
|
|
ARM_INT_REGISTER_SIZE, byte_order);
|
|
|
|
|
reg_pc = gdbarch_addr_bits_remove (gdbarch, reg_pc);
|
|
|
|
|
store_unsigned_integer (pc_buf, ARM_INT_REGISTER_SIZE, byte_order,
|
|
|
|
|
reg_pc);
|
|
|
|
|
regcache->raw_supply (ARM_PC_REGNUM, pc_buf);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Collect register REGNUM from REGCACHE and place it into buffer GREGS_BUF
|
|
|
|
|
(length LEN bytes). If REGNUM is -1 then collect all registers. The
|
|
|
|
|
set of registers that this function will collect is limited to the
|
|
|
|
|
general purpose registers.
|
|
|
|
|
|
|
|
|
|
The layout of the registers here is based on the ARM GNU/Linux
|
|
|
|
|
layout. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
arm_none_collect_gregset (const struct regset *regset,
|
|
|
|
|
const struct regcache *regcache,
|
|
|
|
|
int regnum, void *gregs_buf, size_t len)
|
|
|
|
|
{
|
|
|
|
|
gdb_byte *gregs = (gdb_byte *) gregs_buf;
|
|
|
|
|
|
|
|
|
|
for (int regno = ARM_A1_REGNUM; regno < ARM_PC_REGNUM; regno++)
|
|
|
|
|
if (regnum == -1 || regnum == regno)
|
|
|
|
|
regcache->raw_collect (regno,
|
|
|
|
|
gregs + ARM_INT_REGISTER_SIZE * regno);
|
|
|
|
|
|
|
|
|
|
if (regnum == ARM_PS_REGNUM || regnum == -1)
|
|
|
|
|
{
|
|
|
|
|
if (arm_apcs_32)
|
|
|
|
|
regcache->raw_collect (ARM_PS_REGNUM,
|
|
|
|
|
gregs + ARM_INT_REGISTER_SIZE
|
|
|
|
|
* ARM_NONE_CPSR_GREGNUM);
|
|
|
|
|
else
|
|
|
|
|
regcache->raw_collect (ARM_PS_REGNUM,
|
|
|
|
|
gregs + ARM_INT_REGISTER_SIZE * ARM_PC_REGNUM);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (regnum == ARM_PC_REGNUM || regnum == -1)
|
|
|
|
|
regcache->raw_collect (ARM_PC_REGNUM,
|
|
|
|
|
gregs + ARM_INT_REGISTER_SIZE * ARM_PC_REGNUM);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Supply VFP registers from REGS_BUF into REGCACHE. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
arm_none_supply_vfp (const struct regset *regset,
|
|
|
|
|
struct regcache *regcache,
|
|
|
|
|
int regnum, const void *regs_buf, size_t len)
|
|
|
|
|
{
|
|
|
|
|
const gdb_byte *regs = (const gdb_byte *) regs_buf;
|
|
|
|
|
|
|
|
|
|
if (regnum == ARM_FPSCR_REGNUM || regnum == -1)
|
|
|
|
|
regcache->raw_supply (ARM_FPSCR_REGNUM, regs + 32 * 8);
|
|
|
|
|
|
|
|
|
|
for (int regno = ARM_D0_REGNUM; regno <= ARM_D31_REGNUM; regno++)
|
|
|
|
|
if (regnum == -1 || regnum == regno)
|
|
|
|
|
regcache->raw_supply (regno, regs + (regno - ARM_D0_REGNUM) * 8);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Collect VFP registers from REGCACHE into REGS_BUF. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
arm_none_collect_vfp (const struct regset *regset,
|
|
|
|
|
const struct regcache *regcache,
|
|
|
|
|
int regnum, void *regs_buf, size_t len)
|
|
|
|
|
{
|
|
|
|
|
gdb_byte *regs = (gdb_byte *) regs_buf;
|
|
|
|
|
|
|
|
|
|
if (regnum == ARM_FPSCR_REGNUM || regnum == -1)
|
|
|
|
|
regcache->raw_collect (ARM_FPSCR_REGNUM, regs + 32 * 8);
|
|
|
|
|
|
|
|
|
|
for (int regno = ARM_D0_REGNUM; regno <= ARM_D31_REGNUM; regno++)
|
|
|
|
|
if (regnum == -1 || regnum == regno)
|
|
|
|
|
regcache->raw_collect (regno, regs + (regno - ARM_D0_REGNUM) * 8);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* The general purpose register set. */
|
|
|
|
|
|
|
|
|
|
static const struct regset arm_none_gregset =
|
|
|
|
|
{
|
|
|
|
|
nullptr, arm_none_supply_gregset, arm_none_collect_gregset
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* The VFP register set. */
|
|
|
|
|
|
|
|
|
|
static const struct regset arm_none_vfpregset =
|
|
|
|
|
{
|
|
|
|
|
nullptr, arm_none_supply_vfp, arm_none_collect_vfp
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* Iterate over core file register note sections. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
arm_none_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
|
|
|
|
iterate_over_regset_sections_cb *cb,
|
|
|
|
|
void *cb_data,
|
|
|
|
|
const struct regcache *regcache)
|
|
|
|
|
{
|
gdb: move the type cast into gdbarch_tdep
I built GDB for all targets on a x86-64/GNU-Linux system, and
then (accidentally) passed GDB a RISC-V binary, and asked GDB to "run"
the binary on the native target. I got this error:
(gdb) show architecture
The target architecture is set to "auto" (currently "i386").
(gdb) file /tmp/hello.rv32.exe
Reading symbols from /tmp/hello.rv32.exe...
(gdb) show architecture
The target architecture is set to "auto" (currently "riscv:rv32").
(gdb) run
Starting program: /tmp/hello.rv32.exe
../../src/gdb/i387-tdep.c:596: internal-error: i387_supply_fxsave: Assertion `tdep->st0_regnum >= I386_ST0_REGNUM' failed.
What's going on here is this; initially the architecture is i386, this
is based on the default architecture, which is set based on the native
target. After loading the RISC-V executable the architecture of the
current inferior is updated based on the architecture of the
executable.
When we "run", GDB does a fork & exec, with the inferior being
controlled through ptrace. GDB sees an initial stop from the inferior
as soon as the inferior comes to life. In response to this stop GDB
ends up calling save_stop_reason (linux-nat.c), which ends up trying
to read register from the inferior, to do this we end up calling
target_ops::fetch_registers, which, for the x86-64 native target,
calls amd64_linux_nat_target::fetch_registers.
After this I eventually end up in i387_supply_fxsave, different x86
based targets will end in different functions to fetch registers, but
it doesn't really matter which function we end up in, the problem is
this line, which is repeated in many places:
i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
The problem here is that the ARCH in this line comes from the current
inferior, which, as we discussed above, will be a RISC-V gdbarch, the
tdep field will actually be of type riscv_gdbarch_tdep, not
i386_gdbarch_tdep. After this cast we are relying on undefined
behaviour, in my case I happen to trigger an assert, but this might
not always be the case.
The thing I tried that exposed this problem was of course, trying to
start an executable of the wrong architecture on a native target. I
don't think that the correct solution for this problem is to detect,
at the point of cast, that the gdbarch_tdep object is of the wrong
type, but, I did wonder, is there a way that we could protect
ourselves from incorrectly casting the gdbarch_tdep object?
I think that there is something we can do here, and this commit is the
first step in that direction, though no actual check is added by this
commit.
This commit can be split into two parts:
(1) In gdbarch.h and arch-utils.c. In these files I have modified
gdbarch_tdep (the function) so that it now takes a template argument,
like this:
template<typename TDepType>
static inline TDepType *
gdbarch_tdep (struct gdbarch *gdbarch)
{
struct gdbarch_tdep *tdep = gdbarch_tdep_1 (gdbarch);
return static_cast<TDepType *> (tdep);
}
After this change we are no better protected, but the cast is now
done within the gdbarch_tdep function rather than at the call sites,
this leads to the second, much larger change in this commit,
(2) Everywhere gdbarch_tdep is called, we make changes like this:
- i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
+ i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (arch);
There should be no functional change after this commit.
In the next commit I will build on this change to add an assertion in
gdbarch_tdep that checks we are casting to the correct type.
2022-05-19 20:20:17 +08:00
|
|
|
arm_gdbarch_tdep *tdep = gdbarch_tdep<arm_gdbarch_tdep> (gdbarch);
|
gdb/arm: add support for bare-metal core dumps
This commit adds support for bare metal core dumps on the ARM target,
and is based off of this patch submitted to the mailing list:
https://sourceware.org/pipermail/gdb-patches/2020-October/172845.html
Compared to the version linked above this version is updated to take
account of recent changes to the core dump infrastructure in GDB,
there is now more shared infrastructure for core dumping within GDB,
and also some common bare metal core dumping infrastructure. As a
result this patch is smaller than the original proposed patch.
Further, the original patch included some unrelated changes to the
simulator that have been removed from this version.
I have written a ChangeLog entry as the original patch was missing
one.
I have done absolutely no testing of this patch. It is based on the
original submitted patch, which I assume was tested, but after my
modifications things might have been broken, however, the original
patch author has tested this version and reported it as being good:
https://sourceware.org/pipermail/gdb-patches/2021-May/178900.html
The core dump format is based around generating an ELF containing
sections for the writable regions of memory that a user could be
using. Which regions are dumped rely on GDB's existing common core
dumping code, GDB will attempt to figure out the stack and heap as
well as copying out writable data sections as identified by the
original ELF.
Register information is added to the core dump using notes, just as it
is for Linux of FreeBSD core dumps. The note types used consist of
the 2 basic types you would expect in a OS based core dump,
NT_PRPSINFO, NT_PRSTATUS, along with the architecture specific
NT_ARM_VFP note.
The data layouts for each note type are described below, in all cases,
all padding fields should be set to zero.
Note NT_PRPSINFO is optional. Its data layout is:
struct prpsinfo_t
{
uint8_t padding[28];
char fname[16];
char psargs[80];
}
Field 'fname' - null terminated string consisting of the basename of
(up to the fist 15 characters of) the executable. Any additional
space should be set to zero. If there's no executable name then
this field can be set to all zero.
Field 'psargs' - a null terminated string up to 80 characters in
length. Any additional space should be filled with zero. This
field contains the full executable path and any arguments passed
to the executable. If there's nothing sensible to write in this
field then fill it with zero.
Note NT_PRSTATUS is required, its data layout is:
struct prstatus_t
{
uint8_t padding_1[12];
uint16_t sig;
uint8_t padding_2[10];
uint32_t thread_id;
uint8_t padding_3[44];
uint32_t gregs[18];
}
Field 'sig' - the signal that stopped this thread. It's implementation
defined what this field actually means. Within GDB this will be
the signal number that the remote target reports as the stop
reason for this thread.
Field 'thread_is' - the thread id for this thread. It's implementation
defined what this field actually means. Within GDB this will be
thread thread-id that is assigned to each remote thread.
Field 'gregs' - holds the general purpose registers $a1 through to $pc
at indices 0 to 15. At index 16 the program status register.
Index 17 should be set to zero.
Note NT_ARM_VFP is optional, its data layout is:
armvfp_t
{
uint64_t regs[32];
uint32_t fpscr;
}
Field 'regs' - holds the 32 d-registers 0 to 31 in order.
Field 'fpscr' - holds the fpscr register.
The rules for ordering the notes is the same as for Linux. The
NT_PRSTATUS note must come before any other notes about additional
register sets. And for multi-threaded targets all registers for a
single thread should be grouped together. This is because only
NT_PRSTATUS includes a thread-id, all additional register notes after
a NT_PRSTATUS are assumed to belong to the same thread until a
different NT_PRSTATUS is seen.
gdb/ChangeLog:
PR gdb/14383
* Makefile.in (ALL_TARGET_OBS): Add arm-none-tdep.o.
(ALLDEPFILES): Add arm-none-tdep.c
* arm-none-tdep.c: New file.
* configure.tgt (arm*-*-*): Add arm-none-tdep.o to cpu_obs.
2021-01-20 23:13:16 +08:00
|
|
|
|
|
|
|
|
cb (".reg", ARM_NONE_SIZEOF_GREGSET, ARM_NONE_SIZEOF_GREGSET,
|
|
|
|
|
&arm_none_gregset, nullptr, cb_data);
|
|
|
|
|
|
|
|
|
|
if (tdep->vfp_register_count > 0)
|
|
|
|
|
cb (".reg-arm-vfp", ARM_NONE_SIZEOF_VFP, ARM_NONE_SIZEOF_VFP,
|
|
|
|
|
&arm_none_vfpregset, "VFP floating-point", cb_data);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Initialize ARM bare-metal ABI info. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
arm_none_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
|
|
|
{
|
|
|
|
|
#ifdef HAVE_ELF
|
|
|
|
|
elf_none_init_abi (gdbarch);
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
/* Iterate over registers for reading and writing bare metal ARM core
|
|
|
|
|
files. */
|
|
|
|
|
set_gdbarch_iterate_over_regset_sections
|
|
|
|
|
(gdbarch, arm_none_iterate_over_regset_sections);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Initialize ARM bare-metal target support. */
|
|
|
|
|
|
|
|
|
|
void _initialize_arm_none_tdep ();
|
|
|
|
|
void
|
|
|
|
|
_initialize_arm_none_tdep ()
|
|
|
|
|
{
|
|
|
|
|
gdbarch_register_osabi (bfd_arch_arm, 0, GDB_OSABI_NONE,
|
|
|
|
|
arm_none_init_abi);
|
|
|
|
|
}
|
