Commit Graph

44 Commits

Author SHA1 Message Date
xtqqczze
358db74479
Enable CA1816: Dispose methods should call SuppressFinalize (#14074)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816
2020-11-24 09:29:15 +05:00
xtqqczze
fa8b94e6e9
Fix SA1122: Use string.Empty for empty strings (#14218)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1122.md
2020-11-23 14:09:20 +05:00
xtqqczze
60643e27df
Enable CA1012: Abstract types should not have public constructors (#13940)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1012
2020-11-21 20:07:28 +05:00
xtqqczze
8f659a2e31
Enable SA1212: Property accessors should follow order (#14051)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1202.md
2020-11-21 20:01:33 +05:00
xtqqczze
7dee446324
Enable SA1006: Preprocessor keywords should not be preceded by space (#14052)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1006.md
2020-11-21 20:00:23 +05:00
xtqqczze
8691607143
Enable CA2216: Disposable types should declare finalizer (#14089)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2216
2020-11-21 19:48:21 +05:00
xtqqczze
83688be8a4
Enable SA1002: Semicolons should be spaced correctly (#14197)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1002.md
2020-11-21 19:30:59 +05:00
xtqqczze
cba73e724f
Enable SA1106: Code should not contain empty statements (#13964)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1106.md
2020-11-21 19:26:44 +05:00
xtqqczze
fa657ef86d
Enable SA1517: Code should not contain blank lines at start of file (#14131)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1517.md
2020-11-20 17:33:23 +05:00
xtqqczze
99a49e0eab
Enable SA1131: Use readable conditions (#14132)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md
2020-11-20 17:26:46 +05:00
xtqqczze
d92984106a
Enable SA1507: Code should not contain multiple blank lines in a row (#14136)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1507.md
2020-11-20 16:17:45 +05:00
xtqqczze
f14c76aab9
Enable SA1516: Elements should be separated by blank line (#14137)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1516.md
2020-11-20 16:11:36 +05:00
xtqqczze
9e285298c0
Enable IDE0031: Null check can be simplified (#13548)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0031
2020-11-20 11:42:51 +05:00
xtqqczze
b5902a6e9f
Enable CA1065: Do not raise exceptions in unexpected locations (#14117) 2020-11-19 12:12:12 -08:00
xtqqczze
567724962e
Enable CA1000: Do not declare static members on generic types (#14097) 2020-11-19 12:10:09 -08:00
xtqqczze
d358c1c797
Enable SA1007: Operator keyword should be followed by space (#14130)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1007.md
2020-11-19 11:08:52 +05:00
xtqqczze
44a701fb51
Add StyleCop.Analyzers package (#13963)
* Add StyleCop.Analyzers with all rules disabled

* Downgrade to 1.2.0-beta.205

* Enable SA1518: Use line endings correctly at end of file

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1518.md
2020-11-18 23:13:09 +05:00
xtqqczze
a0e9d7b040
Enable IDE0041: UseIsNullCheck (#14041)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0041
2020-11-16 19:57:48 +05:00
xtqqczze
006fe4d2dd
Enable IDE0082: ConvertTypeOfToNameOf (#14042)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0082
2020-11-16 19:56:07 +05:00
xtqqczze
1dc0ba4a69
Enable IDE0062: MakeLocalFunctionStatic (#14044)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0062
2020-11-13 09:12:38 +05:00
xtqqczze
774d7d7891
Enable CA2207: Initialize value type static fields inline (#14068)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2207
2020-11-13 08:53:39 +05:00
xtqqczze
5c874207ec
Enable CA1837: Use 'Environment.ProcessId' (#14063)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1837
2020-11-13 08:47:23 +05:00
xtqqczze
bac51217d6
Enable CA1829: Use Length/Count property instead of Count() (#13925)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1829
2020-11-11 11:55:39 +05:00
xtqqczze
39205ca4de
Enable CA1827: Do not use Count() or LongCount() when Any() can be used (#13923)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1827
2020-11-11 11:53:30 +05:00
xtqqczze
23deb41f49
Enable IDE0040: AddAccessibilityModifiers (#13962)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040
2020-11-09 09:37:25 +05:00
xtqqczze
2e24380b8c
Fix CA1003: Use generic event handler instances (#13937)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1003
2020-11-07 16:30:19 +05:00
xtqqczze
3ba61069b8
Enable IDE0054: Use compound assignment (#13546)
* Autofix IDE0054
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074
2020-11-05 09:48:13 +05:00
xtqqczze
47c92090db
Enable CA1068: CancellationToken parameters must come last (#13867)
* Enable CA1068: CancellationToken parameters must come last
2020-11-05 09:08:28 +05:00
xtqqczze
91e49d42d4
Enable CA10XX rules with suggestion severity (#13870)
CA1016: Mark assemblies with assembly version
CA1018: Mark attributes with AttributeUsageAttribute
CA1041: Provide ObsoleteAttribute message
CA1047: Do not declare protected member in sealed type
CA1061: Do not hide base class methods
CA1070: Do not declare event fields as virtual
2020-11-05 09:05:41 +05:00
xtqqczze
679a3a6bff
Enable CA20XX rules with suggestion severity (#13928)
* CA2009: Do not call ToImmutableCollection on an ImmutableCollection value
* CA2011: Avoid infinite recursion
* CA2012: Use ValueTasks correctly
2020-11-05 08:52:14 +05:00
xtqqczze
07887993b8
Enable IDE0064: MakeStructFieldsWritable (#13945)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0064
2020-11-05 08:46:17 +05:00
xtqqczze
1c99dcb47b
Enable CA18XX rules with suggestion severity (#13924) 2020-11-04 18:59:13 -08:00
xtqqczze
1d7a93c2e0
Enable CA1825: Avoid zero-length array allocations (#13961) 2020-11-04 08:56:26 +05:00
xtqqczze
329d6b43d2
Add IDE analyzer rule IDs to comments (#13960) 2020-11-02 11:54:05 +05:00
xtqqczze
4b9f9dc457
Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder (#13926)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830
2020-11-02 08:46:40 +05:00
xtqqczze
fc15daaccb
Enable IDE0036: OrderModifiers (#13958)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036
2020-11-02 08:27:23 +05:00
xtqqczze
ea4cf93749
Enforce code style in build (#13957)
* Enable EnforceCodeStyleInBuild

* Disable rules breaking build
2020-11-01 12:33:18 +05:00
xtqqczze
2c1546cd47
Enable CA1836: Prefer IsEmpty over Count when available (#13877)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1836
2020-10-30 12:15:29 +05:00
xtqqczze
af8558b065
Enable CA1834: Consider using 'StringBuilder.Append(char)' when applicable (#13878)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834
2020-10-30 12:07:18 +05:00
xtqqczze
83a3f532f1
Enable IDE0048: AddRequiredParentheses (#13896)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048
2020-10-29 15:55:32 +05:00
xtqqczze
20401c9583
Enable IDE1005: InvokeDelegateWithConditionalAccess (#13911)
* Enable IDE1005: InvokeDelegateWithConditionalAccess

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide1005
2020-10-28 22:35:51 +05:00
xtqqczze
432dd56ea8
Enable IDE0036: OrderModifiers (#13881)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036
2020-10-28 16:01:45 +05:00
xtqqczze
9932560841
Enable CA1050: Declare types in namespaces (#13872) 2020-10-26 22:34:26 +05:00
xtqqczze
ab378f6236
Add global AnalyzerConfig with default configuration (#13835)
* Add default global AnalyzerConfig

Add `microsoft.codeanalysis.netanalyzers\5.0.0-rtm.20502.2\editorconfig\AllRulesDefault\.editorconfig`

* Disable diagnostics for Microsoft.Management.UI.Internal

* Add IDE diagnostics to AnalyzerConfig

Copied from:
<3b6600cbef/eng/CodeAnalysis.ruleset> and converted using `RulesetToEditorconfigConverter.exe`
2020-10-26 21:11:09 +05:00