mirrors/PowerShell
0
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell.git synced 2024-11-23 17:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix $? to not be $false when native command writes to stderr (#13395)

Browse Source
This commit is contained in:
Steve Lee 2020-08-19 09:31:38 -07:00 committed by GitHub
parent 1a0a5db069
commit d67649c300
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/System.Management.Automation/engine/MshCommandRuntime.cs
View File

@ -2825,7 +2825,6 @@ namespace System.Management.Automation
Severity.Warning);
}
this.PipelineProcessor.ExecutionFailed = true;
if (LogPipelineExecutionDetail)
{
this.PipelineProcessor.LogExecutionError(_thisCommand.MyInvocation, errorRecord);
@ -2833,6 +2832,8 @@ namespace System.Management.Automation
if (!(ExperimentalFeature.IsEnabled("PSNotApplyErrorActionToStderr") && isNativeError))
{
this.PipelineProcessor.ExecutionFailed = true;
ActionPreference preference = ErrorAction;
if (actionPreference.HasValue)
{

2
test/powershell/Language/Scripting/NativeExecution/NativeCommandProcessor.Tests.ps1
View File

@ -142,7 +142,7 @@ Describe "Native Command Processor" -tags "Feature" {
}
It '$ErrorActionPreference does not apply to redirected stderr output' -Skip:(!$EnabledExperimentalFeatures.Contains('PSNotApplyErrorActionToStderr')) {
pwsh -noprofile -command '$ErrorActionPreference = ''Stop''; testexe -stderr stop 2>$null; ''hello''; $error' | Should -BeExactly 'hello'
pwsh -noprofile -command '$ErrorActionPreference = ''Stop''; testexe -stderr stop 2>$null; ''hello''; $error; $?' | Should -BeExactly 'hello','True'
}
}