korg/mmc-utils
0
0
Fork 0
mirror of https://git.kernel.org/pub/scm/utils/mmc/mmc-utils.git synced 2024-11-23 09:57:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

mmc-utils: Fix for Firmware Version string printing

Browse Source 
Added a local buffer to create a NULL terminated string to print the
Firmware Version instead of attempting to print directly from
ext_csd buffer. The last byte of the Firmware Version field may not
be NULL and the next field may also not be which may cause it to
print garbage.

Tested on x86 platform.

Signed-off-by: Kimito Sakata <kimito.sakata@oracle.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Fixes: 89cd01ed86 (mmc_utils: add ffu support)
Link: https://lore.kernel.org/r/20210713053458.1441-1-oracleks043021@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Kimito Sakata 2021-07-12 23:34:58 -06:00 committed by Ulf Hansson
parent 43282e80e1
commit 0eea71e4f2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mmc_cmds.c
View File

@ -1392,6 +1392,7 @@ int do_read_extcsd(int nargs, char **argv)
__u32 regl;
int fd, ret;
char *device;
char lbuf[10];
const char *str;
if (nargs != 2) {
@ -1833,8 +1834,9 @@ int do_read_extcsd(int nargs, char **argv)
}
if (ext_csd_rev >= 7) {
printf("eMMC Firmware Version: %s\n",
(char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]);
memset(lbuf, 0, sizeof(lbuf));
strncpy(lbuf, (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION], 8);
printf("eMMC Firmware Version: %s\n", lbuf);
printf("eMMC Life Time Estimation A [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]: 0x%02x\n",
ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]);
printf("eMMC Life Time Estimation B [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B]: 0x%02x\n",