mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-16 15:34:48 +08:00
00d0f31a1e
SET_COALESCE may change operation mode and parameters in one call. Changing operation mode may cause the driver to reset the parameter values to what is a reasonable default for new operation mode. Since driver does not know which parameters come from user and which are echoed back from ->get, driver may ignore the parameters when switching operation modes. This used to be inevitable for ioctl() but in netlink we know which parameters are actually specified by the user. We could inform which parameters were set by the user but this would lead to a lot of code duplication in the drivers. Instead try to call the drivers twice if both mode and params are changed. The set method already checks if any params need updating so in case the driver did the right thing the first time around - there will be no second call to it's ->set method (only an extra call to ->get()). For mlx5 for example before this patch we'd see: # ethtool -C eth0 adaptive-rx on adaptive-tx on # ethtool -C eth0 adaptive-rx off adaptive-tx off \ tx-usecs 123 rx-usecs 123 Adaptive RX: off TX: off rx-usecs: 3 rx-frames: 32 tx-usecs: 16 tx-frames: 32 [...] After the change: # ethtool -C eth0 adaptive-rx on adaptive-tx on # ethtool -C eth0 adaptive-rx off adaptive-tx off \ tx-usecs 123 rx-usecs 123 Adaptive RX: off TX: off rx-usecs: 123 rx-frames: 32 tx-usecs: 123 tx-frames: 32 [...] This only works for netlink, so it's a small discrepancy between netlink and ioctl(). Since we anticipate most users to move to netlink I believe it's worth making their lives easier. Link: https://lore.kernel.org/r/20230420233302.944382-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
380 lines
15 KiB
C
380 lines
15 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
#include "netlink.h"
|
|
#include "common.h"
|
|
|
|
struct coalesce_req_info {
|
|
struct ethnl_req_info base;
|
|
};
|
|
|
|
struct coalesce_reply_data {
|
|
struct ethnl_reply_data base;
|
|
struct ethtool_coalesce coalesce;
|
|
struct kernel_ethtool_coalesce kernel_coalesce;
|
|
u32 supported_params;
|
|
};
|
|
|
|
#define COALESCE_REPDATA(__reply_base) \
|
|
container_of(__reply_base, struct coalesce_reply_data, base)
|
|
|
|
#define __SUPPORTED_OFFSET ETHTOOL_A_COALESCE_RX_USECS
|
|
static u32 attr_to_mask(unsigned int attr_type)
|
|
{
|
|
return BIT(attr_type - __SUPPORTED_OFFSET);
|
|
}
|
|
|
|
/* build time check that indices in ethtool_ops::supported_coalesce_params
|
|
* match corresponding attribute types with an offset
|
|
*/
|
|
#define __CHECK_SUPPORTED_OFFSET(x) \
|
|
static_assert((ETHTOOL_ ## x) == \
|
|
BIT((ETHTOOL_A_ ## x) - __SUPPORTED_OFFSET))
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_USECS);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_MAX_FRAMES);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_USECS_IRQ);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_MAX_FRAMES_IRQ);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_USECS);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_MAX_FRAMES);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_USECS_IRQ);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_MAX_FRAMES_IRQ);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_STATS_BLOCK_USECS);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_USE_ADAPTIVE_RX);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_USE_ADAPTIVE_TX);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_PKT_RATE_LOW);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_USECS_LOW);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_MAX_FRAMES_LOW);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_USECS_LOW);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_MAX_FRAMES_LOW);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_PKT_RATE_HIGH);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_USECS_HIGH);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RX_MAX_FRAMES_HIGH);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_USECS_HIGH);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_TX_MAX_FRAMES_HIGH);
|
|
__CHECK_SUPPORTED_OFFSET(COALESCE_RATE_SAMPLE_INTERVAL);
|
|
|
|
const struct nla_policy ethnl_coalesce_get_policy[] = {
|
|
[ETHTOOL_A_COALESCE_HEADER] =
|
|
NLA_POLICY_NESTED(ethnl_header_policy),
|
|
};
|
|
|
|
static int coalesce_prepare_data(const struct ethnl_req_info *req_base,
|
|
struct ethnl_reply_data *reply_base,
|
|
struct genl_info *info)
|
|
{
|
|
struct coalesce_reply_data *data = COALESCE_REPDATA(reply_base);
|
|
struct netlink_ext_ack *extack = info ? info->extack : NULL;
|
|
struct net_device *dev = reply_base->dev;
|
|
int ret;
|
|
|
|
if (!dev->ethtool_ops->get_coalesce)
|
|
return -EOPNOTSUPP;
|
|
data->supported_params = dev->ethtool_ops->supported_coalesce_params;
|
|
ret = ethnl_ops_begin(dev);
|
|
if (ret < 0)
|
|
return ret;
|
|
ret = dev->ethtool_ops->get_coalesce(dev, &data->coalesce,
|
|
&data->kernel_coalesce, extack);
|
|
ethnl_ops_complete(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int coalesce_reply_size(const struct ethnl_req_info *req_base,
|
|
const struct ethnl_reply_data *reply_base)
|
|
{
|
|
return nla_total_size(sizeof(u32)) + /* _RX_USECS */
|
|
nla_total_size(sizeof(u32)) + /* _RX_MAX_FRAMES */
|
|
nla_total_size(sizeof(u32)) + /* _RX_USECS_IRQ */
|
|
nla_total_size(sizeof(u32)) + /* _RX_MAX_FRAMES_IRQ */
|
|
nla_total_size(sizeof(u32)) + /* _TX_USECS */
|
|
nla_total_size(sizeof(u32)) + /* _TX_MAX_FRAMES */
|
|
nla_total_size(sizeof(u32)) + /* _TX_USECS_IRQ */
|
|
nla_total_size(sizeof(u32)) + /* _TX_MAX_FRAMES_IRQ */
|
|
nla_total_size(sizeof(u32)) + /* _STATS_BLOCK_USECS */
|
|
nla_total_size(sizeof(u8)) + /* _USE_ADAPTIVE_RX */
|
|
nla_total_size(sizeof(u8)) + /* _USE_ADAPTIVE_TX */
|
|
nla_total_size(sizeof(u32)) + /* _PKT_RATE_LOW */
|
|
nla_total_size(sizeof(u32)) + /* _RX_USECS_LOW */
|
|
nla_total_size(sizeof(u32)) + /* _RX_MAX_FRAMES_LOW */
|
|
nla_total_size(sizeof(u32)) + /* _TX_USECS_LOW */
|
|
nla_total_size(sizeof(u32)) + /* _TX_MAX_FRAMES_LOW */
|
|
nla_total_size(sizeof(u32)) + /* _PKT_RATE_HIGH */
|
|
nla_total_size(sizeof(u32)) + /* _RX_USECS_HIGH */
|
|
nla_total_size(sizeof(u32)) + /* _RX_MAX_FRAMES_HIGH */
|
|
nla_total_size(sizeof(u32)) + /* _TX_USECS_HIGH */
|
|
nla_total_size(sizeof(u32)) + /* _TX_MAX_FRAMES_HIGH */
|
|
nla_total_size(sizeof(u32)) + /* _RATE_SAMPLE_INTERVAL */
|
|
nla_total_size(sizeof(u8)) + /* _USE_CQE_MODE_TX */
|
|
nla_total_size(sizeof(u8)) + /* _USE_CQE_MODE_RX */
|
|
nla_total_size(sizeof(u32)) + /* _TX_AGGR_MAX_BYTES */
|
|
nla_total_size(sizeof(u32)) + /* _TX_AGGR_MAX_FRAMES */
|
|
nla_total_size(sizeof(u32)); /* _TX_AGGR_TIME_USECS */
|
|
}
|
|
|
|
static bool coalesce_put_u32(struct sk_buff *skb, u16 attr_type, u32 val,
|
|
u32 supported_params)
|
|
{
|
|
if (!val && !(supported_params & attr_to_mask(attr_type)))
|
|
return false;
|
|
return nla_put_u32(skb, attr_type, val);
|
|
}
|
|
|
|
static bool coalesce_put_bool(struct sk_buff *skb, u16 attr_type, u32 val,
|
|
u32 supported_params)
|
|
{
|
|
if (!val && !(supported_params & attr_to_mask(attr_type)))
|
|
return false;
|
|
return nla_put_u8(skb, attr_type, !!val);
|
|
}
|
|
|
|
static int coalesce_fill_reply(struct sk_buff *skb,
|
|
const struct ethnl_req_info *req_base,
|
|
const struct ethnl_reply_data *reply_base)
|
|
{
|
|
const struct coalesce_reply_data *data = COALESCE_REPDATA(reply_base);
|
|
const struct kernel_ethtool_coalesce *kcoal = &data->kernel_coalesce;
|
|
const struct ethtool_coalesce *coal = &data->coalesce;
|
|
u32 supported = data->supported_params;
|
|
|
|
if (coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_USECS,
|
|
coal->rx_coalesce_usecs, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_MAX_FRAMES,
|
|
coal->rx_max_coalesced_frames, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_USECS_IRQ,
|
|
coal->rx_coalesce_usecs_irq, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_MAX_FRAMES_IRQ,
|
|
coal->rx_max_coalesced_frames_irq, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_USECS,
|
|
coal->tx_coalesce_usecs, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_MAX_FRAMES,
|
|
coal->tx_max_coalesced_frames, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_USECS_IRQ,
|
|
coal->tx_coalesce_usecs_irq, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_MAX_FRAMES_IRQ,
|
|
coal->tx_max_coalesced_frames_irq, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_STATS_BLOCK_USECS,
|
|
coal->stats_block_coalesce_usecs, supported) ||
|
|
coalesce_put_bool(skb, ETHTOOL_A_COALESCE_USE_ADAPTIVE_RX,
|
|
coal->use_adaptive_rx_coalesce, supported) ||
|
|
coalesce_put_bool(skb, ETHTOOL_A_COALESCE_USE_ADAPTIVE_TX,
|
|
coal->use_adaptive_tx_coalesce, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_PKT_RATE_LOW,
|
|
coal->pkt_rate_low, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_USECS_LOW,
|
|
coal->rx_coalesce_usecs_low, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_MAX_FRAMES_LOW,
|
|
coal->rx_max_coalesced_frames_low, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_USECS_LOW,
|
|
coal->tx_coalesce_usecs_low, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_MAX_FRAMES_LOW,
|
|
coal->tx_max_coalesced_frames_low, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_PKT_RATE_HIGH,
|
|
coal->pkt_rate_high, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_USECS_HIGH,
|
|
coal->rx_coalesce_usecs_high, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RX_MAX_FRAMES_HIGH,
|
|
coal->rx_max_coalesced_frames_high, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_USECS_HIGH,
|
|
coal->tx_coalesce_usecs_high, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_MAX_FRAMES_HIGH,
|
|
coal->tx_max_coalesced_frames_high, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_RATE_SAMPLE_INTERVAL,
|
|
coal->rate_sample_interval, supported) ||
|
|
coalesce_put_bool(skb, ETHTOOL_A_COALESCE_USE_CQE_MODE_TX,
|
|
kcoal->use_cqe_mode_tx, supported) ||
|
|
coalesce_put_bool(skb, ETHTOOL_A_COALESCE_USE_CQE_MODE_RX,
|
|
kcoal->use_cqe_mode_rx, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES,
|
|
kcoal->tx_aggr_max_bytes, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES,
|
|
kcoal->tx_aggr_max_frames, supported) ||
|
|
coalesce_put_u32(skb, ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS,
|
|
kcoal->tx_aggr_time_usecs, supported))
|
|
return -EMSGSIZE;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* COALESCE_SET */
|
|
|
|
const struct nla_policy ethnl_coalesce_set_policy[] = {
|
|
[ETHTOOL_A_COALESCE_HEADER] =
|
|
NLA_POLICY_NESTED(ethnl_header_policy),
|
|
[ETHTOOL_A_COALESCE_RX_USECS] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_MAX_FRAMES] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_USECS_IRQ] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_MAX_FRAMES_IRQ] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_USECS] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_MAX_FRAMES] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_USECS_IRQ] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_IRQ] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_STATS_BLOCK_USECS] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_USE_ADAPTIVE_RX] = { .type = NLA_U8 },
|
|
[ETHTOOL_A_COALESCE_USE_ADAPTIVE_TX] = { .type = NLA_U8 },
|
|
[ETHTOOL_A_COALESCE_PKT_RATE_LOW] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_USECS_LOW] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_MAX_FRAMES_LOW] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_USECS_LOW] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_LOW] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_PKT_RATE_HIGH] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_USECS_HIGH] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RX_MAX_FRAMES_HIGH] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_USECS_HIGH] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_HIGH] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_RATE_SAMPLE_INTERVAL] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_USE_CQE_MODE_TX] = NLA_POLICY_MAX(NLA_U8, 1),
|
|
[ETHTOOL_A_COALESCE_USE_CQE_MODE_RX] = NLA_POLICY_MAX(NLA_U8, 1),
|
|
[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES] = { .type = NLA_U32 },
|
|
[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS] = { .type = NLA_U32 },
|
|
};
|
|
|
|
static int
|
|
ethnl_set_coalesce_validate(struct ethnl_req_info *req_info,
|
|
struct genl_info *info)
|
|
{
|
|
const struct ethtool_ops *ops = req_info->dev->ethtool_ops;
|
|
struct nlattr **tb = info->attrs;
|
|
u32 supported_params;
|
|
u16 a;
|
|
|
|
if (!ops->get_coalesce || !ops->set_coalesce)
|
|
return -EOPNOTSUPP;
|
|
|
|
/* make sure that only supported parameters are present */
|
|
supported_params = ops->supported_coalesce_params;
|
|
for (a = ETHTOOL_A_COALESCE_RX_USECS; a < __ETHTOOL_A_COALESCE_CNT; a++)
|
|
if (tb[a] && !(supported_params & attr_to_mask(a))) {
|
|
NL_SET_ERR_MSG_ATTR(info->extack, tb[a],
|
|
"cannot modify an unsupported parameter");
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
__ethnl_set_coalesce(struct ethnl_req_info *req_info, struct genl_info *info,
|
|
bool *dual_change)
|
|
{
|
|
struct kernel_ethtool_coalesce kernel_coalesce = {};
|
|
struct net_device *dev = req_info->dev;
|
|
struct ethtool_coalesce coalesce = {};
|
|
bool mod_mode = false, mod = false;
|
|
struct nlattr **tb = info->attrs;
|
|
int ret;
|
|
|
|
ret = dev->ethtool_ops->get_coalesce(dev, &coalesce, &kernel_coalesce,
|
|
info->extack);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
/* Update values */
|
|
ethnl_update_u32(&coalesce.rx_coalesce_usecs,
|
|
tb[ETHTOOL_A_COALESCE_RX_USECS], &mod);
|
|
ethnl_update_u32(&coalesce.rx_max_coalesced_frames,
|
|
tb[ETHTOOL_A_COALESCE_RX_MAX_FRAMES], &mod);
|
|
ethnl_update_u32(&coalesce.rx_coalesce_usecs_irq,
|
|
tb[ETHTOOL_A_COALESCE_RX_USECS_IRQ], &mod);
|
|
ethnl_update_u32(&coalesce.rx_max_coalesced_frames_irq,
|
|
tb[ETHTOOL_A_COALESCE_RX_MAX_FRAMES_IRQ], &mod);
|
|
ethnl_update_u32(&coalesce.tx_coalesce_usecs,
|
|
tb[ETHTOOL_A_COALESCE_TX_USECS], &mod);
|
|
ethnl_update_u32(&coalesce.tx_max_coalesced_frames,
|
|
tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES], &mod);
|
|
ethnl_update_u32(&coalesce.tx_coalesce_usecs_irq,
|
|
tb[ETHTOOL_A_COALESCE_TX_USECS_IRQ], &mod);
|
|
ethnl_update_u32(&coalesce.tx_max_coalesced_frames_irq,
|
|
tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_IRQ], &mod);
|
|
ethnl_update_u32(&coalesce.stats_block_coalesce_usecs,
|
|
tb[ETHTOOL_A_COALESCE_STATS_BLOCK_USECS], &mod);
|
|
ethnl_update_u32(&coalesce.pkt_rate_low,
|
|
tb[ETHTOOL_A_COALESCE_PKT_RATE_LOW], &mod);
|
|
ethnl_update_u32(&coalesce.rx_coalesce_usecs_low,
|
|
tb[ETHTOOL_A_COALESCE_RX_USECS_LOW], &mod);
|
|
ethnl_update_u32(&coalesce.rx_max_coalesced_frames_low,
|
|
tb[ETHTOOL_A_COALESCE_RX_MAX_FRAMES_LOW], &mod);
|
|
ethnl_update_u32(&coalesce.tx_coalesce_usecs_low,
|
|
tb[ETHTOOL_A_COALESCE_TX_USECS_LOW], &mod);
|
|
ethnl_update_u32(&coalesce.tx_max_coalesced_frames_low,
|
|
tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_LOW], &mod);
|
|
ethnl_update_u32(&coalesce.pkt_rate_high,
|
|
tb[ETHTOOL_A_COALESCE_PKT_RATE_HIGH], &mod);
|
|
ethnl_update_u32(&coalesce.rx_coalesce_usecs_high,
|
|
tb[ETHTOOL_A_COALESCE_RX_USECS_HIGH], &mod);
|
|
ethnl_update_u32(&coalesce.rx_max_coalesced_frames_high,
|
|
tb[ETHTOOL_A_COALESCE_RX_MAX_FRAMES_HIGH], &mod);
|
|
ethnl_update_u32(&coalesce.tx_coalesce_usecs_high,
|
|
tb[ETHTOOL_A_COALESCE_TX_USECS_HIGH], &mod);
|
|
ethnl_update_u32(&coalesce.tx_max_coalesced_frames_high,
|
|
tb[ETHTOOL_A_COALESCE_TX_MAX_FRAMES_HIGH], &mod);
|
|
ethnl_update_u32(&coalesce.rate_sample_interval,
|
|
tb[ETHTOOL_A_COALESCE_RATE_SAMPLE_INTERVAL], &mod);
|
|
ethnl_update_u32(&kernel_coalesce.tx_aggr_max_bytes,
|
|
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES], &mod);
|
|
ethnl_update_u32(&kernel_coalesce.tx_aggr_max_frames,
|
|
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES], &mod);
|
|
ethnl_update_u32(&kernel_coalesce.tx_aggr_time_usecs,
|
|
tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS], &mod);
|
|
|
|
/* Update operation modes */
|
|
ethnl_update_bool32(&coalesce.use_adaptive_rx_coalesce,
|
|
tb[ETHTOOL_A_COALESCE_USE_ADAPTIVE_RX], &mod_mode);
|
|
ethnl_update_bool32(&coalesce.use_adaptive_tx_coalesce,
|
|
tb[ETHTOOL_A_COALESCE_USE_ADAPTIVE_TX], &mod_mode);
|
|
ethnl_update_u8(&kernel_coalesce.use_cqe_mode_tx,
|
|
tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_TX], &mod_mode);
|
|
ethnl_update_u8(&kernel_coalesce.use_cqe_mode_rx,
|
|
tb[ETHTOOL_A_COALESCE_USE_CQE_MODE_RX], &mod_mode);
|
|
|
|
*dual_change = mod && mod_mode;
|
|
if (!mod && !mod_mode)
|
|
return 0;
|
|
|
|
ret = dev->ethtool_ops->set_coalesce(dev, &coalesce, &kernel_coalesce,
|
|
info->extack);
|
|
return ret < 0 ? ret : 1;
|
|
}
|
|
|
|
static int
|
|
ethnl_set_coalesce(struct ethnl_req_info *req_info, struct genl_info *info)
|
|
{
|
|
bool dual_change;
|
|
int err, ret;
|
|
|
|
/* SET_COALESCE may change operation mode and parameters in one call.
|
|
* Changing operation mode may cause the driver to reset the parameter
|
|
* values, and therefore ignore user input (driver does not know which
|
|
* parameters come from user and which are echoed back from ->get).
|
|
* To not complicate the drivers if user tries to change both the mode
|
|
* and parameters at once - call the driver twice.
|
|
*/
|
|
err = __ethnl_set_coalesce(req_info, info, &dual_change);
|
|
if (err < 0)
|
|
return err;
|
|
ret = err;
|
|
|
|
if (ret && dual_change) {
|
|
err = __ethnl_set_coalesce(req_info, info, &dual_change);
|
|
if (err < 0)
|
|
return err;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
const struct ethnl_request_ops ethnl_coalesce_request_ops = {
|
|
.request_cmd = ETHTOOL_MSG_COALESCE_GET,
|
|
.reply_cmd = ETHTOOL_MSG_COALESCE_GET_REPLY,
|
|
.hdr_attr = ETHTOOL_A_COALESCE_HEADER,
|
|
.req_info_size = sizeof(struct coalesce_req_info),
|
|
.reply_data_size = sizeof(struct coalesce_reply_data),
|
|
|
|
.prepare_data = coalesce_prepare_data,
|
|
.reply_size = coalesce_reply_size,
|
|
.fill_reply = coalesce_fill_reply,
|
|
|
|
.set_validate = ethnl_set_coalesce_validate,
|
|
.set = ethnl_set_coalesce,
|
|
.set_ntf_cmd = ETHTOOL_MSG_COALESCE_NTF,
|
|
};
|