Nathan Chancellor f7d5bcd35d selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn ... After commit 6d029c25b7 ("selftests/timers/posix_timers: Reimplement check_timer_distribution()"), clang warns: tools/testing/selftests/timers/../kselftest.h:398:6: warning: variable 'major' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized] 398 | if (uname(&info) || sscanf(info.release, "%u.%u.", &major, &minor) != 2) | ^~~~~~~~~~~~ tools/testing/selftests/timers/../kselftest.h:401:9: note: uninitialized use occurs here 401 | return major > min_major || (major == min_major && minor >= min_minor); | ^~~~~ tools/testing/selftests/timers/../kselftest.h:398:6: note: remove the '||' if its condition is always false 398 | if (uname(&info) || sscanf(info.release, "%u.%u.", &major, &minor) != 2) | ^~~~~~~~~~~~~~~ tools/testing/selftests/timers/../kselftest.h:395:20: note: initialize the variable 'major' to silence this warning 395 | unsigned int major, minor; | ^ | = 0 This is a false positive because if uname() fails, ksft_exit_fail_msg() will be called, which unconditionally calls exit(), a noreturn function. However, clang does not know that ksft_exit_fail_msg() will call exit() at the point in the pipeline that the warning is emitted because inlining has not occurred, so it assumes control flow will resume normally after ksft_exit_fail_msg() is called. Make it clear to clang that all of the functions that call exit() unconditionally in kselftest.h are noreturn transitively by marking them explicitly with '__attribute__((__noreturn__))', which clears up the warning above and any future warnings that may appear for the same reason. Fixes: 6d029c25b7 ("selftests/timers/posix_timers: Reimplement check_timer_distribution()") Reported-by: John Stultz <jstultz@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Shuah Khan <skhan@linuxfoundation.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20240411-mark-kselftest-exit-funcs-noreturn-v1-1-b027c948f586@kernel.org Closes: https://lore.kernel.org/all/20240410232637.4135564-2-jstultz@google.com/		2024-04-12 14:11:15 +02:00
..
accounting
arch	LoongArch changes for v6.9	2024-03-22 10:22:45 -07:00
bootconfig
bpf	libbpf, selftests/bpf: Adjust libbpf, bpftool, selftests to match LLVM	2024-03-15 14:24:00 -07:00
build	perf: build: introduce the libcapstone	2024-02-20 18:06:25 -08:00
certs
cgroup
counter	tools/counter: Remove unneeded semicolon	2023-12-20 11:43:31 -05:00
crypto	crypto: ccp - Update return values for some unit tests	2024-02-24 08:41:20 +08:00
debugging
firewire
firmware
gpio
hv
iio	tools: iio: replace seekdir() in iio_generic_buffer	2024-01-23 22:06:56 +00:00
include	tools/resolve_btfids: fix build with musl libc	2024-03-28 18:58:29 -07:00
kvm/kvm_stat
laptop
leds
lib	bpf-for-netdev	2024-03-26 12:55:18 +01:00
memory-model
mm	tools/mm: add thpmaps script to dump THP usage info	2024-02-22 10:24:38 -08:00
net/ynl	tools: ynl: fix setting presence bits in simple nests	2024-03-22 17:54:38 -07:00
objtool	objtool: Fix compile failure when using the x32 compiler	2024-03-30 22:12:37 +01:00
pci
pcmcia
perf	RISC-V Patches for the 6.9 Merge Window	2024-03-22 10:41:13 -07:00
power	linux-cpupower-6.9-rc1	2024-03-07 21:02:51 +01:00
rcu
scripts	treewide: remove meaningless assignments in Makefiles	2024-02-23 14:19:07 -08:00
spi
testing	selftests: kselftest: Mark functions that unconditionally call exit() as __noreturn	2024-04-12 14:11:15 +02:00
thermal	tools/thermal/tmon: Fix compilation warning for wrong format	2024-01-02 09:33:19 +01:00
time
tracing	tools/rtla: Add -U/--user-load option to timerlat	2024-03-20 05:39:06 +01:00
usb
verification	tools/verification: Use tools/build makefiles on rv	2024-03-20 05:39:06 +01:00
virtio	tools: virtio: introduce vhost_net_test	2024-03-05 11:38:14 +01:00
wmi
workqueue	workqueue: Implement BH workqueues to eventually replace tasklets	2024-02-04 11:28:06 -10:00
Makefile	tools/Makefile: remove cgroup target	2024-03-26 11:07:21 -07:00