Brian Foster f65e6fad29 xfs: use iomap new flag for newly allocated delalloc blocks ... Commit fa7f138 ("xfs: clear delalloc and cache on buffered write failure") fixed one regression in the iomap error handling code and exposed another. The fundamental problem is that if a buffered write is a rewrite of preexisting delalloc blocks and the write fails, the failure handling code can punch out preexisting blocks with valid file data. This was reproduced directly by sub-block writes in the LTP kernel/syscalls/write/write03 test. A first 100 byte write allocates a single block in a file. A subsequent 100 byte write fails and punches out the block, including the data successfully written by the previous write. To address this problem, update the ->iomap_begin() handler to distinguish newly allocated delalloc blocks from preexisting delalloc blocks via the IOMAP_F_NEW flag. Use this flag in the ->iomap_end() handler to decide when a failed or short write should punch out delalloc blocks. This introduces the subtle requirement that ->iomap_begin() should never combine newly allocated delalloc blocks with existing blocks in the resulting iomap descriptor. This can occur when a new delalloc reservation merges with a neighboring extent that is part of the current write, for example. Therefore, drop the post-allocation extent lookup from xfs_bmapi_reserve_delalloc() and just return the record inserted into the fork. This ensures only new blocks are returned and thus that preexisting delalloc blocks are always handled as "found" blocks and not punched out on a failed rewrite. Reported-by: Xiong Zhou <xzhou@redhat.com> Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>		2017-03-08 09:58:08 -08:00
..
libxfs	xfs: use iomap new flag for newly allocated delalloc blocks	2017-03-08 09:58:08 -08:00
Kconfig	xfs: implement iomap based buffered write path	2016-06-21 09:53:44 +10:00
kmem.c	xfs: remove kmem_zalloc_greedy	2017-03-07 20:10:50 -08:00
kmem.h	xfs: remove kmem_zalloc_greedy	2017-03-07 20:10:50 -08:00
Makefile	xfs: introduce the CoW fork	2016-10-04 18:06:40 -07:00
mrlock.h
uuid.c
uuid.h
xfs_acl.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
xfs_acl.h
xfs_aops.c	xfs: fix and streamline error handling in xfs_end_io	2017-03-07 20:10:50 -08:00
xfs_aops.h	xfs: use iomap_dio_rw	2016-11-30 14:37:15 +11:00
xfs_attr_inactive.c	xfs: make several functions static	2016-06-01 17:38:15 +10:00
xfs_attr_list.c	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs_attr.h	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs_bmap_item.c	xfs: when replaying bmap operations, don't let unlinked inodes get reaped	2016-10-04 11:05:44 -07:00
xfs_bmap_item.h	xfs: log bmap intent items	2016-10-04 11:05:44 -07:00
xfs_bmap_util.c	xfs: simplify xfs_rtallocate_extent	2017-02-17 16:52:52 -08:00
xfs_bmap_util.h	xfs: remove unused full argument from bmap	2017-01-30 16:32:25 -08:00
xfs_buf_item.c	xfs: reset b_first_retry_time when clear the retry status of xfs_buf_t	2017-02-03 14:39:07 -08:00
xfs_buf_item.h
xfs_buf.c	sched/headers: Prepare to move the memalloc_noio_*() APIs to <linux/sched/mm.h>	2017-03-02 08:42:33 +01:00
xfs_buf.h	block: Get rid of blk_get_backing_dev_info()	2017-02-02 08:21:32 -07:00
xfs_dir2_readdir.c	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_discard.c	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_discard.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_dquot_item.c	xfs: allocate log vector buffers outside CIL context lock	2016-07-22 09:52:35 +10:00
xfs_dquot_item.h
xfs_dquot.c	xfs: don't wrap ID in xfs_dq_get_next_id	2017-01-17 11:43:38 -08:00
xfs_dquot.h
xfs_error.c	Merge branch 'xfs-4.8-misc-fixes-3' into for-next	2016-07-20 11:51:08 +10:00
xfs_error.h	xfs: simulate per-AG reservations being critically low	2016-10-05 16:26:31 -07:00
xfs_export.c	xfs: abstract block export operations from nfsd layouts	2016-07-15 15:31:29 -04:00
xfs_export.h
xfs_extent_busy.c	xfs: fix len comparison in xfs_extent_busy_trim	2017-02-16 17:20:12 -08:00
xfs_extent_busy.h	xfs: improve handling of busy extents in the low-level allocator	2017-02-09 10:50:25 -08:00
xfs_extfree_item.c	xfs: remove unnecessary parentheses from log redo item recovery functions	2016-08-03 12:29:32 +10:00
xfs_extfree_item.h	xfs: refactor redo intent item processing	2016-08-03 11:23:49 +10:00
xfs_file.c	fs: add i_blocksize()	2017-02-27 18:43:46 -08:00
xfs_filestream.c	Merge branch 'xfs-4.9-log-recovery-fixes' into for-next	2016-10-03 09:56:28 +11:00
xfs_filestream.h
xfs_fsops.c	xfs: remove boilerplate around xfs_btree_init_block	2017-01-30 16:32:24 -08:00
xfs_fsops.h	xfs: preallocate blocks for worst-case btree expansion	2016-10-05 16:26:27 -07:00
xfs_globals.c	xfs: garbage collect old cowextsz reservations	2016-10-05 16:26:28 -07:00
xfs_icache.c	xfs: only reclaim unwritten COW extents periodically	2017-03-07 16:45:58 -08:00
xfs_icache.h	xfs: sync eofblocks scans under iolock are livelock prone	2017-01-30 16:32:25 -08:00
xfs_icreate_item.c	fs: xfs: xfs_icreate_item: constify xfs_item_ops structure	2016-11-28 14:57:42 +11:00
xfs_icreate_item.h
xfs_inode_item.c	xfs: provide helper for counting extents from if_bytes	2016-11-08 12:59:42 +11:00
xfs_inode_item.h
xfs_inode.c	xfs: only reclaim unwritten COW extents periodically	2017-03-07 16:45:58 -08:00
xfs_inode.h	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_ioctl32.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
xfs_ioctl32.h
xfs_ioctl.c	sched/headers: Prepare to remove <linux/cred.h> inclusion from <linux/sched.h>	2017-03-02 08:42:31 +01:00
xfs_ioctl.h	xfs: don't pass ioflags around in the ioctl path	2016-07-20 11:29:35 +10:00
xfs_iomap.c	xfs: use iomap new flag for newly allocated delalloc blocks	2017-03-08 09:58:08 -08:00
xfs_iomap.h	xfs: introduce xfs_aligned_fsb_count	2017-02-06 17:47:46 -08:00
xfs_iops.c	statx: Add a system call to make enhanced file info available	2017-03-02 20:51:15 -05:00
xfs_iops.h	xfs: Propagate dentry down to inode_change_ok()	2016-09-22 10:56:19 +02:00
xfs_itable.c	xfs: remove kmem_zalloc_greedy	2017-03-07 20:10:50 -08:00
xfs_itable.h
xfs_linux.h	sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h>	2017-03-02 08:42:32 +01:00
xfs_log_cil.c	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_log_priv.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_log_recover.c	Merge branch 'xfs-4.10-misc-fixes-3' into for-next	2016-12-07 17:42:30 +11:00
xfs_log.c	xfs: don't print warnings when xfs_log_force fails	2017-01-09 13:45:01 -08:00
xfs_log.h	xfs: remove unused struct declarations	2017-01-30 16:32:25 -08:00
xfs_message.c
xfs_message.h
xfs_mount.c	xfs: Use xfs_icluster_size_fsb() to calculate inode alignment mask	2017-03-07 20:10:50 -08:00
xfs_mount.h	xfs: resurrect debug mode drop buffered writes mechanism	2017-02-16 17:19:15 -08:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_ondisk.h	xfs: define the on-disk refcount btree format	2016-10-03 09:11:18 -07:00
xfs_pnfs.c	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_pnfs.h	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_qm_bhv.c
xfs_qm_syscalls.c	xfs: better xfs_trans_alloc interface	2016-04-06 09:19:55 +10:00
xfs_qm.c	xfs: prevent quotacheck from overloading inode lru	2017-01-27 09:32:30 -08:00
xfs_qm.h
xfs_quota.h
xfs_quotaops.c
xfs_refcount_item.c	xfs: fix double-cleanup when CUI recovery fails	2017-01-03 18:39:32 -08:00
xfs_refcount_item.h	xfs: log refcount intent items	2016-10-03 09:11:21 -07:00
xfs_reflink.c	xfs: only reclaim unwritten COW extents periodically	2017-03-07 16:45:58 -08:00
xfs_reflink.h	xfs: only reclaim unwritten COW extents periodically	2017-03-07 16:45:58 -08:00
xfs_rmap_item.c	xfs: convert unwritten status of reverse mappings for shared files	2016-10-05 16:26:29 -07:00
xfs_rmap_item.h	xfs: convert RUI log formats to use variable length arrays	2016-09-19 10:24:27 +10:00
xfs_rtalloc.c	xfs: simplify xfs_rtallocate_extent	2017-02-17 16:52:52 -08:00
xfs_rtalloc.h	xfs: simplify xfs_rtallocate_extent	2017-02-17 16:52:52 -08:00
xfs_stats.c	xfs: make xfs btree stats less huge	2016-12-05 14:38:58 +11:00
xfs_stats.h	xfs: make xfs btree stats less huge	2016-12-05 14:38:58 +11:00
xfs_super.c	xfs: only reclaim unwritten COW extents periodically	2017-03-07 16:45:58 -08:00
xfs_super.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_symlink.c	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_symlink.h
xfs_sysctl.c	xfs: garbage collect old cowextsz reservations	2016-10-05 16:26:28 -07:00
xfs_sysctl.h	xfs: garbage collect old cowextsz reservations	2016-10-05 16:26:28 -07:00
xfs_sysfs.c	xfs: resurrect debug mode drop buffered writes mechanism	2017-02-16 17:19:15 -08:00
xfs_sysfs.h	xfs: configurable error behavior via sysfs	2016-05-18 10:58:51 +10:00
xfs_trace.c	xfs: rework xfs_bmap_free callers to use xfs_defer_ops	2016-08-03 11:15:38 +10:00
xfs_trace.h	mm,fs,dax: change ->pmd_fault to ->huge_fault	2017-02-24 17:46:54 -08:00
xfs_trans_ail.c
xfs_trans_bmap.c	xfs: implement deferred bmbt map/unmap operations	2016-10-04 11:05:44 -07:00
xfs_trans_buf.c
xfs_trans_dquot.c
xfs_trans_extfree.c	xfs: set up per-AG free space reservations	2016-09-19 10:30:52 +10:00
xfs_trans_inode.c	fs: Replace current_fs_time() with current_time()	2016-09-27 21:06:22 -04:00
xfs_trans_priv.h
xfs_trans_refcount.c	xfs: connect refcount adjust functions to upper layers	2016-10-03 09:11:22 -07:00
xfs_trans_rmap.c	xfs: add shared rmap map/unmap/convert log item types	2016-10-05 16:26:29 -07:00
xfs_trans.c	Merge branch 'xfs-4.9-reflink-prep' into for-next	2016-10-03 09:52:31 +11:00
xfs_trans.h	xfs: remove unused struct declarations	2017-01-30 16:32:25 -08:00
xfs_xattr.c	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs.h