linux/drivers/net/can/c_can
AnilKumar Ch f461f27a44 can: c_can: fix race condition in c_can_open()
Fix the issue of C_CAN interrupts getting disabled forever when canconfig
utility is used multiple times. According to NAPI usage we disable all
the hardware interrupts in ISR and re-enable them in poll(). Current
implementation calls napi_enable() after hardware interrupts are enabled.
If we get any interrupts between these two steps then we do not process
those interrupts because napi is not enabled. Mostly these interrupts
come because of STATUS is not 0x7 or ERROR interrupts. If napi_enable()
happens before HW interrupts enabled then c_can_poll() function will be
called eventual re-enabling.

This patch moves the napi_enable() call before interrupts enabled.

Cc: stable@kernel.org # 2.6.39+
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2012-06-03 18:59:20 +02:00
..
c_can_platform.c net/can: convert drivers/net/can/* to use module_platform_driver() 2011-11-29 00:25:05 -05:00
c_can.c can: c_can: fix race condition in c_can_open() 2012-06-03 18:59:20 +02:00
c_can.h can: c_can: fix an interrupt thrash issue with c_can driver 2012-06-03 18:59:19 +02:00
Kconfig can: c_can: Added support for Bosch C_CAN controller 2011-02-13 22:51:44 -08:00
Makefile can: c_can: Added support for Bosch C_CAN controller 2011-02-13 22:51:44 -08:00