linux/fs/erofs
Gao Xiang 47467e0481 erofs: fix inconsistent per-file compression format
commit 118a8cf504 upstream.

EROFS can select compression algorithms on a per-file basis, and each
per-file compression algorithm needs to be marked in the on-disk
superblock for initialization.

However, syzkaller can generate inconsistent crafted images that use
an unsupported algorithmtype for specific inodes, e.g. use MicroLZMA
algorithmtype even it's not set in `sbi->available_compr_algs`.  This
can lead to an unexpected "BUG: kernel NULL pointer dereference" if
the corresponding decompressor isn't built-in.

Fix this by checking against `sbi->available_compr_algs` for each
m_algorithmformat request.  Incorrect !erofs_sb_has_compr_cfgs preset
bitmap is now fixed together since it was harmless previously.

Reported-by: <bugreport@ubisectech.com>
Fixes: 8f89926290 ("erofs: get compression algorithms directly on mapping")
Fixes: 622ceaddb7 ("erofs: lzma compression support")
Reviewed-by: Yue Hu <huyue2@coolpad.com>
Link: https://lore.kernel.org/r/20240113150602.1471050-1-hsiangkao@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Yue Hu <huyue2@coolpad.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-03-01 13:26:39 +01:00
..
compress.h erofs: simplify compression configuration parser 2024-03-01 13:26:38 +01:00
data.c erofs: simplify iloc() 2023-07-19 16:20:59 +02:00
decompressor_lzma.c erofs: simplify compression configuration parser 2024-03-01 13:26:38 +01:00
decompressor.c erofs: fix inconsistent per-file compression format 2024-03-01 13:26:39 +01:00
dir.c erofs: update ctx->pos for every emitted dirent 2022-07-31 22:26:29 +08:00
erofs_fs.h erofs: introduce partial-referenced pclusters 2022-09-26 23:55:43 +08:00
fscache.c erofs: relinquish volume with mutex held 2023-03-10 09:32:46 +01:00
inode.c erofs: fix fsdax unavailability for chunk-based regular files 2023-07-23 13:49:26 +02:00
internal.h erofs: simplify compression configuration parser 2024-03-01 13:26:38 +01:00
Kconfig erofs: register fscache volume 2022-05-18 00:11:19 +08:00
Makefile erofs: register fscache volume 2022-05-18 00:11:19 +08:00
namei.c erofs: fix refcount on the metabuf used for inode lookup 2024-03-01 13:26:33 +01:00
pcpubuf.c erofs: get rid of ->lru usage 2021-10-25 08:22:59 +08:00
super.c erofs: simplify compression configuration parser 2024-03-01 13:26:38 +01:00
sysfs.c erofs: fix use-after-free of fsid and domain_id string 2022-11-10 09:53:20 +08:00
utils.c mm: shrinkers: provide shrinkers with names 2022-07-03 18:08:40 -07:00
xattr.c erofs: simplify iloc() 2023-07-19 16:20:59 +02:00
xattr.h erofs: clean up unnecessary code and comments 2022-09-27 17:27:25 +08:00
zdata.c erofs: fix ztailpacking for subpage compressed blocks 2024-02-05 20:12:48 +00:00
zmap.c erofs: fix inconsistent per-file compression format 2024-03-01 13:26:39 +01:00