Linus Torvalds c03098d4b9 gfs2: Fix mmap + page fault deadlocks ... Functions gfs2_file_read_iter and gfs2_file_write_iter are both accessing the user buffer to write to or read from while holding the inode glock. In the most basic scenario, that buffer will not be resident and it will be mapped to the same file. Accessing the buffer will trigger a page fault, and gfs2 will deadlock trying to take the same inode glock again while trying to handle that fault. Fix that and similar, more complex scenarios by disabling page faults while accessing user buffers. To make this work, introduce a small amount of new infrastructure and fix some bugs that didn't trigger so far, with page faults enabled. -----BEGIN PGP SIGNATURE----- iQJIBAABCAAyFiEEJZs3krPW0xkhLMTc1b+f6wMTZToFAmGBPisUHGFncnVlbmJh QHJlZGhhdC5jb20ACgkQ1b+f6wMTZTpE6A/7BezUnGuNJxJrR8pC+vcLYA7xAgUU 6STQ6IN7w5UHRlSkNzZxZ2XPxW4uVQ4SxSEeaLqBsHZihepjcLNFZ/8MhQ6UPSD0 8noHOi7CoIcp6IuWQtCpxRM/xjjm2SlMt2XbVJZaiJcdzCV9gB6TU9EkBRq7Zm/X 9WFBbv1xZF0skn9ISCJvNtiiI+VyWKgMDUKxJUiTQjmJcklyyqHcVGmQi9BjqPz4 4s3F+WH6CoGbDKlmNk/6Y9wZ/2+sbvGswVscUxPwJVPoZWsR1xBBUdAeAmEMD1P4 BgE/Y1J8JXyVPYtyvZKq70XUhKdQkxB7RfX87YasOk9mY4Kjd5rIIGEykh+o2vC9 kDhCHvf2Mnw5I6Rum3B7UXyB1vemY+fECIHsXhgBnS+ztabRtcAdpCuWoqb43ymw yEX1KwXyU4FpRYbrRvdZT42Fmh6ty8TW+N4swg8S2TrffirvgAi5yrcHZ4mPupYv lyzvsCW7Wv8hPXn/twNObX+okRgJnsxcCdBXARdCnRXfA8tH23xmu88u8RA1Vdxh nzTvv6Dx2EowwojuDWMx29Mw3fA2IqIfbOV+4FaRU7NZ2ZKtknL8yGl27qQUsMoJ vYsHTmagasjQr+NDJ3vQRLCw+JQ6B1hENpdkmixFD9moo7X1ZFW3HBi/UL973Bv6 5CmgeXto8FRUFjI= =WeNd -----END PGP SIGNATURE----- Merge tag 'gfs2-v5.15-rc5-mmap-fault' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 Pull gfs2 mmap + page fault deadlocks fixes from Andreas Gruenbacher: "Functions gfs2_file_read_iter and gfs2_file_write_iter are both accessing the user buffer to write to or read from while holding the inode glock. In the most basic deadlock scenario, that buffer will not be resident and it will be mapped to the same file. Accessing the buffer will trigger a page fault, and gfs2 will deadlock trying to take the same inode glock again while trying to handle that fault. Fix that and similar, more complex scenarios by disabling page faults while accessing user buffers. To make this work, introduce a small amount of new infrastructure and fix some bugs that didn't trigger so far, with page faults enabled" * tag 'gfs2-v5.15-rc5-mmap-fault' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2: gfs2: Fix mmap + page fault deadlocks for direct I/O iov_iter: Introduce nofault flag to disable page faults gup: Introduce FOLL_NOFAULT flag to disable page faults iomap: Add done_before argument to iomap_dio_rw iomap: Support partial direct I/O on user copy failures iomap: Fix iomap_dio_rw return value for user copies gfs2: Fix mmap + page fault deadlocks for buffered I/O gfs2: Eliminate ip->i_gh gfs2: Move the inode glock locking to gfs2_file_buffered_write gfs2: Introduce flag for glock holder auto-demotion gfs2: Clean up function may_grant gfs2: Add wrapper for iomap_file_buffered_write iov_iter: Introduce fault_in_iov_iter_writeable iov_iter: Turn iov_iter_fault_in_readable into fault_in_iov_iter_readable gup: Turn fault_in_pages_{readable,writeable} into fault_in_{readable,writeable} powerpc/kvm: Fix kvm_use_magic_page iov_iter: Fix iov_iter_get_pages{,_alloc} page fault return value		2021-11-02 12:25:03 -07:00
..
compress.h	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
data.c	gfs2: Fix mmap + page fault deadlocks	2021-11-02 12:25:03 -07:00
decompressor_lzma.c	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
decompressor.c	erofs: don't trigger WARN() when decompression fails	2021-10-31 21:00:28 +08:00
dir.c	erofs: clean up file headers & footers	2021-06-08 00:41:24 +08:00
erofs_fs.h	erofs: lzma compression support	2021-10-19 23:44:30 +08:00
inode.c	erofs: decouple basic mount options from fs_context	2021-10-17 23:57:15 +08:00
internal.h	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
Kconfig	erofs: lzma compression support	2021-10-19 23:44:30 +08:00
Makefile	erofs: lzma compression support	2021-10-19 23:44:30 +08:00
namei.c	erofs: add fiemap support with iomap	2021-08-19 00:13:43 +08:00
pcpubuf.c	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
super.c	erofs: lzma compression support	2021-10-19 23:44:30 +08:00
tagptr.h	erofs: clean up file headers & footers	2021-06-08 00:41:24 +08:00
utils.c	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
xattr.c	erofs: decouple basic mount options from fs_context	2021-10-17 23:57:15 +08:00
xattr.h	vfs: add rcu argument to ->get_acl() callback	2021-08-18 22:08:24 +02:00
zdata.c	erofs: get rid of ->lru usage	2021-10-25 08:22:59 +08:00
zdata.h	erofs: lzma compression support	2021-10-19 23:44:30 +08:00
zmap.c	erofs: lzma compression support	2021-10-19 23:44:30 +08:00
zpvec.h	erofs: clean up file headers & footers	2021-06-08 00:41:24 +08:00