Jason A. Donenfeld fef0035c0f netlink: do not proceed if dump's start() errs ... Drivers that use the start method for netlink dumping rely on dumpit not being called if start fails. For example, ila_xlat.c allocates memory and assigns it to cb->args[0] in its start() function. It might fail to do that and return -ENOMEM instead. However, even when returning an error, dumpit will be called, which, in the example above, quickly dereferences the memory in cb->args[0], which will OOPS the kernel. This is but one example of how this goes wrong. Since start() has always been a function with an int return type, it therefore makes sense to use it properly, rather than ignoring it. This patch thus returns early and does not call dumpit() when start() fails. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Cc: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-30 16:13:31 +01:00
..
af_netlink.c	netlink: do not proceed if dump's start() errs	2017-09-30 16:13:31 +01:00
af_netlink.h	netlink: extended ACK reporting	2017-04-13 13:58:20 -04:00
diag.c	netlink/diag: report flags for netlink sockets	2017-04-05 07:13:56 -07:00
genetlink.c	netlink: pass extended ACK struct where available	2017-04-13 13:58:22 -04:00
Kconfig	netlink: remove mmapped netlink support	2016-02-18 11:42:18 -05:00
Makefile	netlink: Diag core and basic socket info dumping (v2)	2013-03-21 12:38:03 -04:00