Rafael J. Wysocki 7b301750f7 ACPI: EC: PM: Avoid premature returns from acpi_s2idle_wake() ... If the EC GPE status is not set after checking all of the other GPEs, acpi_s2idle_wake() returns 'false', to indicate that the SCI event that has just triggered is not a system wakeup one, but it does that without canceling the pending wakeup and re-arming the SCI for system wakeup which is a mistake, because it may cause s2idle_loop() to busy spin until the next valid wakeup event. [If that happens, the first spurious wakeup is still pending after acpi_s2idle_wake() has returned, so s2idle_enter() does nothing, acpi_s2idle_wake() is called again and it sees that the SCI has triggered, but no GPEs are active, so 'false' is returned again, and so on.] Fix that by moving all of the GPE checking logic from acpi_s2idle_wake() to acpi_ec_dispatch_gpe() and making the latter return 'true' only if a non-EC GPE has triggered and 'false' otherwise, which will cause acpi_s2idle_wake() to cancel the pending SCI wakeup and re-arm the SCI for system wakeup regardless of the EC GPE status. This also addresses a lockup observed on an Elitegroup EF20EA laptop after attempting to wake it up from suspend-to-idle by a key press. Fixes: d5406284ff ("ACPI: PM: s2idle: Refine active GPEs check") Link: https://bugzilla.kernel.org/show_bug.cgi?id=207603 Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com> Fixes: fdde0ff859 ("ACPI: PM: s2idle: Prevent spurious SCIs from waking up the system") Link: https://lore.kernel.org/linux-acpi/CAB4CAwdqo7=MvyG_PE+PGVfeA17AHF5i5JucgaKqqMX6mjArbQ@mail.gmail.com/ Reported-by: Chris Chiu <chiu@endlessm.com> Tested-by: Chris Chiu <chiu@endlessm.com> Cc: 5.4+ <stable@vger.kernel.org> # 5.4+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>		2020-05-11 10:11:38 +02:00
..
acpica	Merge branch 'acpica'	2020-04-06 16:23:31 +02:00
apei	x86/mm: split vmalloc_sync_all()	2020-03-21 18:56:06 -07:00
arm64	ACPI/IORT: Remove direct access of dev->iommu_fwspec	2020-03-27 11:12:19 +01:00
dptf	ACPI: Update Tiger Lake ACPI device IDs	2020-04-01 13:20:21 +02:00
nfit	Merge branch 'for-5.7/libnvdimm' into libnvdimm-for-next	2020-04-02 19:55:17 -07:00
numa	ACPI: NUMA: Up-level "map to online node" functionality	2020-02-17 10:49:06 -08:00
pmic	ACPI / PMIC: Add Cherry Trail Crystal Cove PMIC OpRegion driver	2019-10-25 11:43:08 +02:00
x86	ACPI: Convert to new X86 CPU match macros	2020-03-24 21:30:50 +01:00
ac.c	ACPI / AC: Cleanup DMI quirk table	2020-03-04 10:32:50 +01:00
acpi_adxl.c	ACPI/ADXL: Add address translation interface using an ACPI DSM	2018-10-16 10:03:00 +02:00
acpi_amba.c	Merge 5.2-rc6 into char-misc-next	2019-06-23 09:23:33 +02:00
acpi_apd.c	ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller	2020-02-03 12:03:18 +01:00
acpi_cmos_rtc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
acpi_configfs.c	ACPICA: make acpi_load_table() return table index	2019-10-28 22:12:46 +01:00
acpi_dbg.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
acpi_extlog.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 437	2019-06-05 17:37:17 +02:00
acpi_ipmi.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
acpi_lpat.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
acpi_lpit.c	remove ioremap_nocache and devm_ioremap_nocache	2020-01-06 09:45:59 +01:00
acpi_lpss.c	ACPI: Convert to new X86 CPU match macros	2020-03-24 21:30:50 +01:00
acpi_memhotplug.c	mm/memory_hotplug: rename walk_memory_range() and pass start+size instead of pfns	2019-07-18 17:08:06 -07:00
acpi_pad.c	ACPI, x86: Add Zhaoxin processors support for NONSTOP TSC	2019-06-22 11:45:57 +02:00
acpi_platform.c	ACPI: platform: Unregister stale platform devices	2019-10-17 23:48:39 +02:00
acpi_pnp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
acpi_processor.c	ACPI: processor: Export acpi_processor_evaluate_cst()	2019-12-27 11:02:07 +01:00
acpi_tad.c	ACPI: TAD: Add low-level support for real time capability	2018-10-18 09:11:53 +02:00
acpi_video.c	ACPI: video: remove redundant assignments to variable result	2020-03-04 10:43:04 +01:00
acpi_watchdog.c	ACPI: watchdog: Fix gas->access_width usage	2020-02-13 23:51:30 +01:00
battery.c	ACPI / battery: Cleanup Lenovo Ideapad Miix 320 DMI table entry	2020-03-04 10:32:50 +01:00
bgrt.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
blacklist.c	ACPI: blacklist: fix clang warning for unused DMI table	2019-07-11 22:45:00 +02:00
bus.c	ACPI: bus: Fix NULL pointer check in acpi_bus_get_private_data()	2019-11-29 11:42:10 +01:00
button.c	ACPI: button: Drop no longer necessary Asus T200TA lid_init_state quirk	2020-04-20 10:37:15 +02:00
cm_sbs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
container.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
cppc_acpi.c	ACPI: CPPC: clean up acpi_get_psd_map()	2020-03-28 13:25:41 +01:00
custom_method.c	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
debugfs.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
device_pm.c	PM: ACPI: Output correct message on target power state	2020-04-27 10:33:40 +02:00
device_sysfs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
dock.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
ec_sys.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482	2019-06-19 17:09:52 +02:00
ec.c	ACPI: EC: PM: Avoid premature returns from acpi_s2idle_wake()	2020-05-11 10:11:38 +02:00
event.c	ACPI: event: replace strcpy() by strscpy()	2019-04-23 10:54:26 +02:00
evged.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284	2019-06-05 17:36:37 +02:00
fan.c	ACPI: fan: Use scnprintf() for avoiding potential buffer overflow	2020-03-14 11:11:58 +01:00
glue.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428	2019-06-05 17:37:16 +02:00
hed.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
internal.h	ACPI: EC: PM: Avoid premature returns from acpi_s2idle_wake()	2020-05-11 10:11:38 +02:00
ioapic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
irq.c	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:01:13 -07:00
Kconfig	ACPI: Add new tiny-power-button driver to directly signal init	2020-02-13 23:36:23 +01:00
Makefile	ACPI: Add new tiny-power-button driver to directly signal init	2020-02-13 23:36:23 +01:00
nvs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428	2019-06-05 17:37:16 +02:00
osi.c	ACPI: OSI: Shoot duplicate word	2019-11-13 11:12:08 +01:00
osl.c	ACPI: OSL: Add missing __acquires/__releases annotations	2020-03-04 10:40:48 +01:00
pci_irq.c	ACPI / PCI: fix acpi_pci_irq_enable() memory leak	2019-09-03 09:41:25 +02:00
pci_link.c	ACPI/PCI: pci_link: use extended_irq union member when setting ext-irq shareable	2020-04-20 10:36:22 +02:00
pci_mcfg.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 459	2019-06-19 17:09:09 +02:00
pci_root.c	pci-v5.7-changes	2020-04-03 14:25:02 -07:00
pci_slot.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 491	2019-06-19 17:09:52 +02:00
power.c	ACPI / PM: Introduce concept of a _PR0 dependent device	2019-06-27 12:31:57 +02:00
pptt.c	ACPI: PPTT: Consistently use unsigned int as parameter type	2020-01-07 11:46:36 +01:00
proc.c	ACPI: list_for_each_safe() -> list_for_each_entry_safe()	2020-03-04 10:48:00 +01:00
processor_core.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
processor_driver.c	cpufreq: Use per-policy frequency QoS	2019-10-21 02:05:21 +02:00
processor_idle.c	ACPI: processor: Export acpi_processor_evaluate_cst()	2019-12-27 11:02:07 +01:00
processor_pdc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
processor_perflib.c	ACPI: processor: Add QoS requests for all CPUs	2019-10-25 11:33:48 +02:00
processor_thermal.c	ACPI: processor: Add QoS requests for all CPUs	2019-10-25 11:33:48 +02:00
processor_throttling.c	x86: ACPI: fix CPU hotplug deadlock	2020-04-04 16:28:24 +02:00
property.c	device property: Add a function to obtain a node's prefix	2019-10-11 11:26:55 +02:00
reboot.c	ACPI: Allow CONFIG_PCI to be unset for reboot	2018-12-20 10:19:49 +01:00
resource.c	acpi: Use pr_warn instead of pr_warning	2019-10-18 15:00:19 +02:00
sbs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
sbshc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372	2019-06-05 17:37:10 +02:00
sbshc.h	ACPI: SBS: remove unused const variable 'SMBUS_PEC'	2019-08-23 12:55:09 +02:00
scan.c	treewide: remove redundant IS_ERR() before error code check	2020-02-04 03:05:27 +00:00
sleep.c	ACPI: EC: PM: Avoid premature returns from acpi_s2idle_wake()	2020-05-11 10:11:38 +02:00
sleep.h	ACPI: PM: Add acpi_[un]register_wakeup_handler()	2020-04-04 19:45:18 +02:00
spcr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sysfs.c	ACPI: sysfs: Change ACPI_MASKABLE_GPE_MAX to 0x100	2019-11-19 09:40:16 +01:00
tables.c	ACPICA: Add NHLT table signature	2020-03-30 14:52:33 +02:00
thermal.c	ACPI: thermal: switch to use <linux/units.h> helpers	2020-01-31 10:30:39 -08:00
tiny-power-button.c	ACPI: Add new tiny-power-button driver to directly signal init	2020-02-13 23:36:23 +01:00
utils.c	ACPI / utils: Introduce acpi_dev_hid_uid_match() helper	2019-10-15 12:06:23 +02:00
video_detect.c	ACPI: video: Use native backlight on Acer Aspire 5783z	2020-04-01 11:18:31 +02:00
wakeup.c	ACPI: PM: Add acpi_[un]register_wakeup_handler()	2020-04-04 19:45:18 +02:00