Mathias Krause ecd7918745 xfrm_user: ensure user supplied esn replay window is valid ... The current code fails to ensure that the netlink message actually contains as many bytes as the header indicates. If a user creates a new state or updates an existing one but does not supply the bytes for the whole ESN replay window, the kernel copies random heap bytes into the replay bitmap, the ones happen to follow the XFRMA_REPLAY_ESN_VAL netlink attribute. This leads to following issues: 1. The replay window has random bits set confusing the replay handling code later on. 2. A malicious user could use this flaw to leak up to ~3.5kB of heap memory when she has access to the XFRM netlink interface (requires CAP_NET_ADMIN). Known users of the ESN replay window are strongSwan and Steffen's iproute2 patch (<http://patchwork.ozlabs.org/patch/85962/>). The latter uses the interface with a bitmap supplied while the former does not. strongSwan is therefore prone to run into issue 1. To fix both issues without breaking existing userland allow using the XFRMA_REPLAY_ESN_VAL netlink attribute with either an empty bitmap or a fully specified one. For the former case we initialize the in-kernel bitmap with zero, for the latter we copy the user supplied bitmap. For state updates the full bitmap must be supplied. To prevent overflows in the bitmap length calculation the maximum size of bmp_len is limited to 128 by this patch -- resulting in a maximum replay window of 4096 packets. This should be sufficient for all real life scenarios (RFC 4303 recommends a default replay window size of 64). Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: Martin Willi <martin@revosec.ch> Cc: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2012-09-20 18:08:40 -04:00
..
Kconfig	xfrm: make xfrm_algo.c a module	2012-05-15 13:13:34 -04:00
Makefile	xfrm: make xfrm_algo.c a module	2012-05-15 13:13:34 -04:00
xfrm_algo.c	xfrm_algo: drop an unnecessary inclusion	2012-05-15 13:13:34 -04:00
xfrm_hash.c	net: allow GFP_HIGHMEM in __vmalloc()	2010-11-21 10:04:04 -08:00
xfrm_hash.h	net: cleanup unsigned to unsigned int	2012-04-15 12:44:40 -04:00
xfrm_input.c	xfrm: Workaround incompatibility of ESN and async crypto	2012-09-04 14:09:45 -04:00
xfrm_ipcomp.c	net: add skb frag size accessors	2011-10-19 03:10:46 -04:00
xfrm_output.c	xfrm: Remove unused xfrm_state from xfrm_state_check_space	2012-03-22 19:29:58 -04:00
xfrm_policy.c	xfrm: fix a read lock imbalance in make_blackhole	2012-09-18 16:30:15 -04:00
xfrm_proc.c	net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules	2011-10-31 19:30:30 -04:00
xfrm_replay.c	xfrm: Workaround incompatibility of ESN and async crypto	2012-09-04 14:09:45 -04:00
xfrm_state.c	net/xfrm/xfrm_state.c: fix error return code	2012-08-31 16:27:48 -04:00
xfrm_sysctl.c	net: Convert all sysctl registrations to register_net_sysctl	2012-04-20 21:22:30 -04:00
xfrm_user.c	xfrm_user: ensure user supplied esn replay window is valid	2012-09-20 18:08:40 -04:00