korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-20 17:44:33 +08:00
Code Issues Packages Projects Releases Wiki Activity
e3c9b0ddfd
linux/drivers/net/ethernet/aquantia/atlantic
History
Chia-Lin Kao (AceLan) 2ba5e47fb7 net: atlantic: fix aq_vec index out of range error 
The final update statement of the for loop exceeds the array range, the
dereference of self->aq_vec[i] is not checked and then leads to the
index out of range error.
Also fixed this kind of coding style in other for loop.

[   97.937604] UBSAN: array-index-out-of-bounds in drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1404:48
[   97.937607] index 8 is out of range for type 'aq_vec_s *[8]'
[   97.937608] CPU: 38 PID: 3767 Comm: kworker/u256:18 Not tainted 5.19.0+ #2
[   97.937610] Hardware name: Dell Inc. Precision 7865 Tower/, BIOS 1.0.0 06/12/2022
[   97.937611] Workqueue: events_unbound async_run_entry_fn
[   97.937616] Call Trace:
[   97.937617]  <TASK>
[   97.937619]  dump_stack_lvl+0x49/0x63
[   97.937624]  dump_stack+0x10/0x16
[   97.937626]  ubsan_epilogue+0x9/0x3f
[   97.937627]  __ubsan_handle_out_of_bounds.cold+0x44/0x49
[   97.937629]  ? __scm_send+0x348/0x440
[   97.937632]  ? aq_vec_stop+0x72/0x80 [atlantic]
[   97.937639]  aq_nic_stop+0x1b6/0x1c0 [atlantic]
[   97.937644]  aq_suspend_common+0x88/0x90 [atlantic]
[   97.937648]  aq_pm_suspend_poweroff+0xe/0x20 [atlantic]
[   97.937653]  pci_pm_suspend+0x7e/0x1a0
[   97.937655]  ? pci_pm_suspend_noirq+0x2b0/0x2b0
[   97.937657]  dpm_run_callback+0x54/0x190
[   97.937660]  __device_suspend+0x14c/0x4d0
[   97.937661]  async_suspend+0x23/0x70
[   97.937663]  async_run_entry_fn+0x33/0x120
[   97.937664]  process_one_work+0x21f/0x3f0
[   97.937666]  worker_thread+0x4a/0x3c0
[   97.937668]  ? process_one_work+0x3f0/0x3f0
[   97.937669]  kthread+0xf0/0x120
[   97.937671]  ? kthread_complete_and_exit+0x20/0x20
[   97.937672]  ret_from_fork+0x22/0x30
[   97.937676]  </TASK>

v2. fixed "warning: variable 'aq_vec' set but not used"

v3. simplified a for loop

Fixes: 97bde5c4f9 ("net: ethernet: aquantia: Support for NIC-specific code")
Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Acked-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Link: https://lore.kernel.org/r/20220808081845.42005-1-acelan.kao@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2022-08-09 22:17:11 -07:00
..
hw_atl Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2022-05-12 16:15:30 -07:00
hw_atl2 atlantic: Fix statistics logic for production hardware 2021-11-29 14:24:22 +00:00
macsec net: atlantic:fix repeated words in comments 2022-06-27 22:06:18 -07:00
aq_cfg.h eth: atlantic: remove a copy of the NAPI_POLL_WEIGHT define 2022-04-29 11:56:41 +01:00
aq_common.h atlantic: Add missing DIDs and fix 115c. 2021-11-29 14:24:21 +00:00
aq_drvinfo.c net: atlantic: add hwmon getter for MAC temperature 2020-07-20 18:07:39 -07:00
aq_drvinfo.h net: atlantic: add hwmon getter for MAC temperature 2020-07-20 18:07:39 -07:00
aq_ethtool.c net: atlantic: Implement xdp data plane 2022-04-20 10:42:57 +01:00
aq_ethtool.h net: atlantic: loopback tests via private flags 2019-11-07 19:54:43 -08:00
aq_filters.c net: atlantic: Use the bitmap API instead of hand-writing it 2022-01-24 12:57:01 +00:00
aq_filters.h
aq_hw_utils.c net: atlantic: use U32_MAX in aq_hw_utils.c 2020-07-20 18:07:38 -07:00
aq_hw_utils.h net: atlantic: add support for 64-bit reads/writes 2020-07-20 18:07:38 -07:00
aq_hw.h atlantic: Fix statistics logic for production hardware 2021-11-29 14:24:22 +00:00
aq_macsec.c ethernet: constify references to netdev->dev_addr in drivers 2021-10-14 09:22:11 -07:00
aq_macsec.h net: atlantic: fix the macsec key length 2021-06-24 12:41:13 -07:00
aq_main.c net: atlantic: Implement .ndo_xdp_xmit handler 2022-04-20 10:42:57 +01:00
aq_main.h net: atlantic: Implement xdp control plane 2022-04-20 10:42:57 +01:00
aq_nic.c net: atlantic: fix aq_vec index out of range error 2022-08-09 22:17:11 -07:00
aq_nic.h net: atlantic: Implement xdp data plane 2022-04-20 10:42:57 +01:00
aq_pci_func.c net: atlantic: remove aq_nic_deinit() when resume 2022-07-14 13:03:21 +02:00
aq_pci_func.h net: atlantic: make aq_pci_func_init static 2020-06-26 16:32:50 -07:00
aq_phy.c net: atlantic: disable PTP on AQC111, AQC112 2020-07-17 18:24:32 -07:00
aq_phy.h net: atlantic: disable PTP on AQC111, AQC112 2020-07-17 18:24:32 -07:00
aq_ptp.c eth: atlantic: remove a copy of the NAPI_POLL_WEIGHT define 2022-04-29 11:56:41 +01:00
aq_ptp.h net: atlantic: PTP statistics 2020-07-20 18:07:38 -07:00
aq_ring.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2022-05-12 16:15:30 -07:00
aq_ring.h net: atlantic: Implement .ndo_xdp_xmit handler 2022-04-20 10:42:57 +01:00
aq_rss.h
aq_utils.h
aq_vec.c eth: atlantic: remove a copy of the NAPI_POLL_WEIGHT define 2022-04-29 11:56:41 +01:00
aq_vec.h net: atlantic: Implement xdp control plane 2022-04-20 10:42:57 +01:00
Makefile net: atlantic: fix build when object tree is separate 2020-09-25 17:19:14 -07:00