0
0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-14 06:24:53 +08:00
linux/drivers/net/ipa
Alex Elder e11ec2b868 net: ipa: only reset hashed tables when supported
Last year, the code that manages GSI channel transactions switched
from using spinlock-protected linked lists to using indexes into the
ring buffer used for a channel.  Recently, Google reported seeing
transaction reference count underflows occasionally during shutdown.

Doug Anderson found a way to reproduce the issue reliably, and
bisected the issue to the commit that eliminated the linked lists
and the lock.  The root cause was ultimately determined to be
related to unused transactions being committed as part of the modem
shutdown cleanup activity.  Unused transactions are not normally
expected (except in error cases).

The modem uses some ranges of IPA-resident memory, and whenever it
shuts down we zero those ranges.  In ipa_filter_reset_table() a
transaction is allocated to zero modem filter table entries.  If
hashing is not supported, hashed table memory should not be zeroed.
But currently nothing prevents that, and the result is an unused
transaction.  Something similar occurs when we zero routing table
entries for the modem.

By preventing any attempt to clear hashed tables when hashing is not
supported, the reference count underflow is avoided in this case.

Note that there likely remains an issue with properly freeing unused
transactions (if they occur due to errors).  This patch addresses
only the underflows that Google originally reported.

Cc: <stable@vger.kernel.org> # 6.1.x
Fixes: d338ae28d8 ("net: ipa: kill all other transaction lists")
Tested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20230724224055.1688854-1-elder@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-07-25 20:34:20 -07:00
..
data net: ipa: add IPA v5.0 configuration data 2023-03-22 22:44:00 -07:00
reg net: ipa: add IPA v5.0 GSI register definitions 2023-03-22 22:44:00 -07:00
gsi_private.h net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
gsi_reg.c net: ipa: add IPA v5.0 GSI register definitions 2023-03-22 22:44:00 -07:00
gsi_reg.h net: ipa: add IPA v5.0 GSI register definitions 2023-03-22 22:44:00 -07:00
gsi_trans.c net: ipa: compute DMA pool size properly 2023-03-29 21:27:40 -07:00
gsi_trans.h net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
gsi.c net: ipa: add HW_PARAM_4 GSI register 2023-02-20 08:14:20 +01:00
gsi.h net: ipa: add IPA v5.0 GSI register definitions 2023-03-22 22:44:00 -07:00
ipa_cmd.c net: ipa: generalize register offset functions 2023-02-10 08:06:32 +00:00
ipa_cmd.h net: ipa: introduce ipa_cmd_init() 2022-10-25 11:15:19 +02:00
ipa_data.h net: ipa: add IPA v5.0 configuration data 2023-03-22 22:44:00 -07:00
ipa_endpoint.c net: ipa: Use correct value for IPA_STATUS_SIZE 2023-06-01 13:29:18 +02:00
ipa_endpoint.h net: ipa: support more endpoints 2023-01-31 21:45:51 -08:00
ipa_gsi.c
ipa_gsi.h net: ipa: fix kerneldoc comments 2020-07-13 17:11:53 -07:00
ipa_interrupt.c net: ipa: generalize register offset functions 2023-02-10 08:06:32 +00:00
ipa_interrupt.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-01-20 12:28:23 -08:00
ipa_main.c net: ipa: add IPA v5.0 configuration data 2023-03-22 22:44:00 -07:00
ipa_mem.c IOMMU Updates for Linux v6.3: 2023-02-24 13:40:13 -08:00
ipa_mem.h net: ipa: define two new memory regions 2023-01-31 21:45:52 -08:00
ipa_modem.c net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
ipa_modem.h net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
ipa_power.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-01-20 12:28:23 -08:00
ipa_power.h net: ipa: register IPA interrupt handlers directly 2023-01-05 22:03:14 -08:00
ipa_qmi_msg.c net: ipa: Make QMI message rules const 2022-10-21 12:39:16 +01:00
ipa_qmi_msg.h net: ipa: Make QMI message rules const 2022-10-21 12:39:16 +01:00
ipa_qmi.c net: ipa: don't assume 8 modem routing table entries 2022-10-27 13:38:13 +02:00
ipa_qmi.h net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
ipa_reg.c net: ipa: add IPA v5.0 register definitions 2023-03-22 22:44:00 -07:00
ipa_reg.h net: ipa: add IPA v5.0 register definitions 2023-03-22 22:44:00 -07:00
ipa_resource.c net: ipa: generalize register field functions 2023-02-10 08:06:32 +00:00
ipa_resource.h net: ipa: get rid of empty IPA functions 2021-04-09 20:57:25 -07:00
ipa_smp2p.c net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
ipa_smp2p.h net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
ipa_sysfs.c net: ipa: add IPA v5.0 to ipa_version_string() 2023-03-23 21:48:32 -07:00
ipa_sysfs.h net: ipa: update copyrights 2022-10-03 16:49:20 -07:00
ipa_table.c net: ipa: only reset hashed tables when supported 2023-07-25 20:34:20 -07:00
ipa_table.h net: ipa: support more filtering endpoints 2022-11-04 10:16:53 +00:00
ipa_uc.c net: ipa: generalize register field functions 2023-02-10 08:06:32 +00:00
ipa_uc.h net: ipa: register IPA interrupt handlers directly 2023-01-05 22:03:14 -08:00
ipa_version.h net: ipa: add some new IPA versions 2023-02-10 08:06:31 +00:00
ipa.h net: ipa: start generalizing "ipa_reg" 2023-02-10 08:06:32 +00:00
Kconfig net: ipa: add an interconnect dependency 2022-03-02 22:14:05 -08:00
Makefile net: ipa: add IPA v5.0 configuration data 2023-03-22 22:44:00 -07:00
reg.h net: ipa: reg: include <linux/bug.h> 2023-03-16 21:33:18 -07:00