mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-16 16:54:20 +08:00
b1b3f49ce4
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
|
||
|---|---|---|
| .. | ||
| include/mach | ||
| avila-pci.c | ||
| avila-setup.c | ||
| common-pci.c | ||
| common.c | ||
| coyote-pci.c | ||
| coyote-setup.c | ||
| dsmg600-pci.c | ||
| dsmg600-setup.c | ||
| fsg-pci.c | ||
| fsg-setup.c | ||
| gateway7001-pci.c | ||
| gateway7001-setup.c | ||
| goramo_mlr.c | ||
| gtwx5715-pci.c | ||
| gtwx5715-setup.c | ||
| ixdp425-pci.c | ||
| ixdp425-setup.c | ||
| ixdpg425-pci.c | ||
| ixp4xx_npe.c | ||
| ixp4xx_qmgr.c | ||
| Kconfig | ||
| Makefile | ||
| Makefile.boot | ||
| miccpt-pci.c | ||
| nas100d-pci.c | ||
| nas100d-setup.c | ||
| nslu2-pci.c | ||
| nslu2-setup.c | ||
| omixp-setup.c | ||
| vulcan-pci.c | ||
| vulcan-setup.c | ||
| wg302v2-pci.c | ||
| wg302v2-setup.c | ||