mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2025-01-20 12:54:36 +08:00
dfbafa70bd
One of the "legitimate" uses of strncpy() is copying a NUL-terminated
string into a fixed-size non-NUL-terminated character array. To avoid
the weaknesses and ambiguity of intent when using strncpy(), provide
replacement functions that explicitly distinguish between trailing
padding and not, and require the destination buffer size be discoverable
by the compiler.
For example:
struct obj {
int foo;
char small[4] __nonstring;
char big[8] __nonstring;
int bar;
};
struct obj p;
/* This will truncate to 4 chars with no trailing NUL */
strncpy(p.small, "hello", sizeof(p.small));
/* p.small contains 'h', 'e', 'l', 'l' */
/* This will NUL pad to 8 chars. */
strncpy(p.big, "hello", sizeof(p.big));
/* p.big contains 'h', 'e', 'l', 'l', 'o', '\0', '\0', '\0' */
When the "__nonstring" attributes are missing, the intent of the
programmer becomes ambiguous for whether the lack of a trailing NUL
in the p.small copy is a bug. Additionally, it's not clear whether
the trailing padding in the p.big copy is _needed_. Both cases
become unambiguous with:
strtomem(p.small, "hello");
strtomem_pad(p.big, "hello", 0);
See also https://github.com/KSPP/linux/issues/90
Expand the memcpy KUnit tests to include these functions.
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Kees Cook <keescook@chromium.org>
|
||
|---|---|---|
| .. | ||
| 1.Intro.rst | ||
| 2.Process.rst | ||
| 3.Early-stage.rst | ||
| 4.Coding.rst | ||
| 5.Posting.rst | ||
| 6.Followthrough.rst | ||
| 7.AdvancedTopics.rst | ||
| 8.Conclusion.rst | ||
| adding-syscalls.rst | ||
| applying-patches.rst | ||
| botching-up-ioctls.rst | ||
| changes.rst | ||
| clang-format.rst | ||
| code-of-conduct-interpretation.rst | ||
| code-of-conduct.rst | ||
| coding-style.rst | ||
| deprecated.rst | ||
| development-process.rst | ||
| email-clients.rst | ||
| embargoed-hardware-issues.rst | ||
| handling-regressions.rst | ||
| howto.rst | ||
| index.rst | ||
| kernel-docs.rst | ||
| kernel-driver-statement.rst | ||
| kernel-enforcement-statement.rst | ||
| license-rules.rst | ||
| magic-number.rst | ||
| maintainer-handbooks.rst | ||
| maintainer-netdev.rst | ||
| maintainer-pgp-guide.rst | ||
| maintainer-tip.rst | ||
| maintainers.rst | ||
| management-style.rst | ||
| programming-language.rst | ||
| researcher-guidelines.rst | ||
| stable-api-nonsense.rst | ||
| stable-kernel-rules.rst | ||
| submit-checklist.rst | ||
| submitting-patches.rst | ||
| volatile-considered-harmful.rst | ||