Junxiao Bi 6bba4471f0 ocfs2: fix data corruption by fallocate ... When fallocate punches holes out of inode size, if original isize is in the middle of last cluster, then the part from isize to the end of the cluster will be zeroed with buffer write, at that time isize is not yet updated to match the new size, if writeback is kicked in, it will invoke ocfs2_writepage()->block_write_full_page() where the pages out of inode size will be dropped. That will cause file corruption. Fix this by zero out eof blocks when extending the inode size. Running the following command with qemu-image 4.2.1 can get a corrupted coverted image file easily. qemu-img convert -p -t none -T none -f qcow2 $qcow_image \ -O qcow2 -o compat=1.1 $qcow_image.conv The usage of fallocate in qemu is like this, it first punches holes out of inode size, then extend the inode size. fallocate(11, FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE, 2276196352, 65536) = 0 fallocate(11, 0, 2276196352, 65536) = 0 v1: https://www.spinics.net/lists/linux-fsdevel/msg193999.html v2: https://lore.kernel.org/linux-fsdevel/20210525093034.GB4112@quack2.suse.cz/T/ Link: https://lkml.kernel.org/r/20210528210648.9124-1-junxiao.bi@oracle.com Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Jan Kara <jack@suse.cz> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Changwei Ge <gechangwei@live.cn> Cc: Gang He <ghe@suse.com> Cc: Jun Piao <piaojun@huawei.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2021-06-05 08:58:12 -07:00
..
cluster	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dlm	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dlmfs	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
acl.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
acl.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
alloc.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
alloc.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
aops.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
aops.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
blockcheck.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
blockcheck.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
buffer_head_io.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
buffer_head_io.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dcache.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dcache.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dir.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dir.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dlmglue.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dlmglue.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
export.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
export.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
extent_map.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
extent_map.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
file.c	ocfs2: fix data corruption by fallocate	2021-06-05 08:58:12 -07:00
file.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
filecheck.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
filecheck.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
heartbeat.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
heartbeat.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
inode.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
inode.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ioctl.c	ocfs2: convert to fileattr	2021-04-12 15:04:30 +02:00
ioctl.h	ocfs2: convert to fileattr	2021-04-12 15:04:30 +02:00
journal.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
journal.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
Kconfig	ocfs2: replace HTTP links with HTTPS ones	2020-08-07 11:33:22 -07:00
localalloc.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
localalloc.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
locks.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
locks.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
Makefile	ocfs2: improve ocfs2 Makefile	2018-12-28 12:11:45 -08:00
mmap.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
mmap.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
move_extents.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
move_extents.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
namei.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
namei.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ocfs1_fs_compat.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ocfs2_fs.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ocfs2_ioctl.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ocfs2_lockid.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ocfs2_lockingver.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
ocfs2_trace.h	ocfs2: fix the application IO timeout when fstrim is running	2019-03-05 21:07:13 -08:00
ocfs2.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
quota_global.c	quota: Check that quota is not dirty before release	2019-10-31 19:07:42 +01:00
quota_local.c	ocfs2: return -EROFS when filesystem becomes read-only	2018-08-17 16:20:27 -07:00
quota.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
refcounttree.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
refcounttree.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
reservations.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
reservations.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
resize.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
resize.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
slot_map.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
slot_map.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
stack_o2cb.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
stack_user.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
stackglue.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
stackglue.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
suballoc.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
suballoc.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
super.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
super.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
symlink.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
symlink.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
sysfile.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
sysfile.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
uptodate.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
uptodate.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
xattr.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
xattr.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00