mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-11 21:38:32 +08:00
03ee318391
The SSAM_DEFINE_SYNC_REQUEST_x() macros are intended to reduce
boiler-plate code for SSAM request definitions by defining a wrapper
function for the specified request. The client device variants of those
macros, i.e. SSAM_DEFINE_SYNC_REQUEST_CL_x() in particular rely on the
multi-device (MD) variants, e.g.:
#define SSAM_DEFINE_SYNC_REQUEST_CL_R(name, rtype, spec...) \
SSAM_DEFINE_SYNC_REQUEST_MD_R(__raw_##name, rtype, spec) \
int name(struct ssam_device *sdev, rtype *ret) \
{ \
return __raw_##name(sdev->ctrl, sdev->uid.target, \
sdev->uid.instance, ret); \
}
This now creates the problem that it is not possible to declare the
generated functions static via
static SSAM_DEFINE_SYNC_REQUEST_CL_R(...)
as this will only apply to the function defined by the multi-device
macro, i.e. SSAM_DEFINE_SYNC_REQUEST_MD_R(). Thus compiling with
`-Wmissing-prototypes' rightfully complains that there is a 'static'
keyword missing.
To solve this, make all SSAM_DEFINE_SYNC_REQUEST_x() macros define
static functions. Non-client-device macros are also changed for
consistency. In general, we expect those functions to be only used
locally in the respective drivers for the corresponding interfaces, so
having to define a wrapper function to be able to export this should be
the odd case out.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: b78b4982d7
("platform/surface: Add platform profile driver")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210304190524.1172197-1-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
191 lines
4.8 KiB
C
191 lines
4.8 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Surface Platform Profile / Performance Mode driver for Surface System
|
|
* Aggregator Module (thermal subsystem).
|
|
*
|
|
* Copyright (C) 2021 Maximilian Luz <luzmaximilian@gmail.com>
|
|
*/
|
|
|
|
#include <asm/unaligned.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_profile.h>
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/surface_aggregator/device.h>
|
|
|
|
enum ssam_tmp_profile {
|
|
SSAM_TMP_PROFILE_NORMAL = 1,
|
|
SSAM_TMP_PROFILE_BATTERY_SAVER = 2,
|
|
SSAM_TMP_PROFILE_BETTER_PERFORMANCE = 3,
|
|
SSAM_TMP_PROFILE_BEST_PERFORMANCE = 4,
|
|
};
|
|
|
|
struct ssam_tmp_profile_info {
|
|
__le32 profile;
|
|
__le16 unknown1;
|
|
__le16 unknown2;
|
|
} __packed;
|
|
|
|
struct ssam_tmp_profile_device {
|
|
struct ssam_device *sdev;
|
|
struct platform_profile_handler handler;
|
|
};
|
|
|
|
SSAM_DEFINE_SYNC_REQUEST_CL_R(__ssam_tmp_profile_get, struct ssam_tmp_profile_info, {
|
|
.target_category = SSAM_SSH_TC_TMP,
|
|
.command_id = 0x02,
|
|
});
|
|
|
|
SSAM_DEFINE_SYNC_REQUEST_CL_W(__ssam_tmp_profile_set, __le32, {
|
|
.target_category = SSAM_SSH_TC_TMP,
|
|
.command_id = 0x03,
|
|
});
|
|
|
|
static int ssam_tmp_profile_get(struct ssam_device *sdev, enum ssam_tmp_profile *p)
|
|
{
|
|
struct ssam_tmp_profile_info info;
|
|
int status;
|
|
|
|
status = ssam_retry(__ssam_tmp_profile_get, sdev, &info);
|
|
if (status < 0)
|
|
return status;
|
|
|
|
*p = le32_to_cpu(info.profile);
|
|
return 0;
|
|
}
|
|
|
|
static int ssam_tmp_profile_set(struct ssam_device *sdev, enum ssam_tmp_profile p)
|
|
{
|
|
__le32 profile_le = cpu_to_le32(p);
|
|
|
|
return ssam_retry(__ssam_tmp_profile_set, sdev, &profile_le);
|
|
}
|
|
|
|
static int convert_ssam_to_profile(struct ssam_device *sdev, enum ssam_tmp_profile p)
|
|
{
|
|
switch (p) {
|
|
case SSAM_TMP_PROFILE_NORMAL:
|
|
return PLATFORM_PROFILE_BALANCED;
|
|
|
|
case SSAM_TMP_PROFILE_BATTERY_SAVER:
|
|
return PLATFORM_PROFILE_LOW_POWER;
|
|
|
|
case SSAM_TMP_PROFILE_BETTER_PERFORMANCE:
|
|
return PLATFORM_PROFILE_BALANCED_PERFORMANCE;
|
|
|
|
case SSAM_TMP_PROFILE_BEST_PERFORMANCE:
|
|
return PLATFORM_PROFILE_PERFORMANCE;
|
|
|
|
default:
|
|
dev_err(&sdev->dev, "invalid performance profile: %d", p);
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
static int convert_profile_to_ssam(struct ssam_device *sdev, enum platform_profile_option p)
|
|
{
|
|
switch (p) {
|
|
case PLATFORM_PROFILE_LOW_POWER:
|
|
return SSAM_TMP_PROFILE_BATTERY_SAVER;
|
|
|
|
case PLATFORM_PROFILE_BALANCED:
|
|
return SSAM_TMP_PROFILE_NORMAL;
|
|
|
|
case PLATFORM_PROFILE_BALANCED_PERFORMANCE:
|
|
return SSAM_TMP_PROFILE_BETTER_PERFORMANCE;
|
|
|
|
case PLATFORM_PROFILE_PERFORMANCE:
|
|
return SSAM_TMP_PROFILE_BEST_PERFORMANCE;
|
|
|
|
default:
|
|
/* This should have already been caught by platform_profile_store(). */
|
|
WARN(true, "unsupported platform profile");
|
|
return -EOPNOTSUPP;
|
|
}
|
|
}
|
|
|
|
static int ssam_platform_profile_get(struct platform_profile_handler *pprof,
|
|
enum platform_profile_option *profile)
|
|
{
|
|
struct ssam_tmp_profile_device *tpd;
|
|
enum ssam_tmp_profile tp;
|
|
int status;
|
|
|
|
tpd = container_of(pprof, struct ssam_tmp_profile_device, handler);
|
|
|
|
status = ssam_tmp_profile_get(tpd->sdev, &tp);
|
|
if (status)
|
|
return status;
|
|
|
|
status = convert_ssam_to_profile(tpd->sdev, tp);
|
|
if (status < 0)
|
|
return status;
|
|
|
|
*profile = status;
|
|
return 0;
|
|
}
|
|
|
|
static int ssam_platform_profile_set(struct platform_profile_handler *pprof,
|
|
enum platform_profile_option profile)
|
|
{
|
|
struct ssam_tmp_profile_device *tpd;
|
|
int tp;
|
|
|
|
tpd = container_of(pprof, struct ssam_tmp_profile_device, handler);
|
|
|
|
tp = convert_profile_to_ssam(tpd->sdev, profile);
|
|
if (tp < 0)
|
|
return tp;
|
|
|
|
return ssam_tmp_profile_set(tpd->sdev, tp);
|
|
}
|
|
|
|
static int surface_platform_profile_probe(struct ssam_device *sdev)
|
|
{
|
|
struct ssam_tmp_profile_device *tpd;
|
|
|
|
tpd = devm_kzalloc(&sdev->dev, sizeof(*tpd), GFP_KERNEL);
|
|
if (!tpd)
|
|
return -ENOMEM;
|
|
|
|
tpd->sdev = sdev;
|
|
|
|
tpd->handler.profile_get = ssam_platform_profile_get;
|
|
tpd->handler.profile_set = ssam_platform_profile_set;
|
|
|
|
set_bit(PLATFORM_PROFILE_LOW_POWER, tpd->handler.choices);
|
|
set_bit(PLATFORM_PROFILE_BALANCED, tpd->handler.choices);
|
|
set_bit(PLATFORM_PROFILE_BALANCED_PERFORMANCE, tpd->handler.choices);
|
|
set_bit(PLATFORM_PROFILE_PERFORMANCE, tpd->handler.choices);
|
|
|
|
platform_profile_register(&tpd->handler);
|
|
return 0;
|
|
}
|
|
|
|
static void surface_platform_profile_remove(struct ssam_device *sdev)
|
|
{
|
|
platform_profile_remove();
|
|
}
|
|
|
|
static const struct ssam_device_id ssam_platform_profile_match[] = {
|
|
{ SSAM_SDEV(TMP, 0x01, 0x00, 0x01) },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(ssam, ssam_platform_profile_match);
|
|
|
|
static struct ssam_device_driver surface_platform_profile = {
|
|
.probe = surface_platform_profile_probe,
|
|
.remove = surface_platform_profile_remove,
|
|
.match_table = ssam_platform_profile_match,
|
|
.driver = {
|
|
.name = "surface_platform_profile",
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
|
},
|
|
};
|
|
module_ssam_device_driver(surface_platform_profile);
|
|
|
|
MODULE_AUTHOR("Maximilian Luz <luzmaximilian@gmail.com>");
|
|
MODULE_DESCRIPTION("Platform Profile Support for Surface System Aggregator Module");
|
|
MODULE_LICENSE("GPL");
|