Eric W. Biederman b5a53485dd ptrace: Reimplement PTRACE_KILL by always sending SIGKILL ... commit 6a2d90ba02 upstream. The current implementation of PTRACE_KILL is buggy and has been for many years as it assumes it's target has stopped in ptrace_stop. At a quick skim it looks like this assumption has existed since ptrace support was added in linux v1.0. While PTRACE_KILL has been deprecated we can not remove it as a quick search with google code search reveals many existing programs calling it. When the ptracee is not stopped at ptrace_stop some fields would be set that are ignored except in ptrace_stop. Making the userspace visible behavior of PTRACE_KILL a noop in those case. As the usual rules are not obeyed it is not clear what the consequences are of calling PTRACE_KILL on a running process. Presumably userspace does not do this as it achieves nothing. Replace the implementation of PTRACE_KILL with a simple send_sig_info(SIGKILL) followed by a return 0. This changes the observable user space behavior only in that PTRACE_KILL on a process not stopped in ptrace_stop will also kill it. As that has always been the intent of the code this seems like a reasonable change. Cc: stable@vger.kernel.org Reported-by: Al Viro <viro@zeniv.linux.org.uk> Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Tested-by: Kees Cook <keescook@chromium.org> Reviewed-by: Oleg Nesterov <oleg@redhat.com> Link: https://lkml.kernel.org/r/20220505182645.497868-7-ebiederm@xmission.com Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-06-14 16:53:43 +02:00
..
bpf	bpf: Add kconfig knob for disabling unpriv bpf by default	2022-02-16 12:44:50 +01:00
cgroup	cgroup/cpuset: Remove cpus_allowed/mems_allowed setup in cpuset_init_smp()	2022-05-18 09:18:08 +02:00
configs
debug	kdb: Make memory allocations more robust	2021-03-03 18:22:36 +01:00
events	perf: Fix sys_perf_event_open() race against self	2022-05-25 08:41:19 +02:00
gcov	gcov: add support for GCC 10.1	2020-09-23 10:46:32 +02:00
irq	genirq: Disable interrupts for force threaded handlers	2021-03-24 11:05:06 +01:00
livepatch	livepatch: Nullify obj->mod in klp_module_coming()'s error path	2019-10-07 18:55:09 +02:00
locking	locking/lockdep: Avoid RCU-induced noinstr fail	2021-11-26 11:40:26 +01:00
power	PM: suspend: fix return value of __setup handler	2022-04-20 09:08:13 +02:00
printk	printk: fix return value of printk.devkmsg __setup handler	2022-04-20 09:08:15 +02:00
rcu	rcu: Fix missed wakeup of exp_wq waiters	2021-09-26 13:37:28 +02:00
sched	sched/debug: Remove mpol_get/put and task_lock/unlock from sched_show_numa	2022-04-20 09:08:13 +02:00
time	timekeeping: Really make sure wall_to_monotonic isn't positive	2021-12-22 09:18:00 +01:00
trace	tracing: Dump stacktrace trigger to the corresponding instance	2022-04-27 13:15:29 +02:00
.gitignore
acct.c	kernel/acct.c: fix the acct->needcheck check in check_free_space()	2018-01-10 09:31:17 +01:00
async.c	Revert "module, async: async_synchronize_full() on module init iff async is used"	2022-02-23 11:57:33 +01:00
audit_fsnotify.c
audit_tree.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
audit_watch.c	audit: CONFIG_CHANGE don't log internal bookkeeping as an event	2020-10-01 13:12:33 +02:00
audit.c	audit: improve audit queue handling when "audit=1" on cmdline	2022-02-08 18:16:28 +01:00
audit.h	audit: fix a net reference leak in audit_list_rules_send()	2020-06-20 10:25:10 +02:00
auditfilter.c	audit: fix a net reference leak in audit_list_rules_send()	2020-06-20 10:25:10 +02:00
auditsc.c	audit: print empty EXECVE args	2019-12-01 09:14:03 +01:00
backtracetest.c
bounds.c	kbuild: fix kernel/bounds.c 'W=1' warning	2018-11-13 11:15:08 -08:00
capability.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat.c	make 'user_access_begin()' do 'access_ok()'	2020-06-20 10:24:58 +02:00
configs.c
context_tracking.c
cpu_pm.c	kernel/cpu_pm: Fix uninitted local in cpu_pm	2020-06-20 10:25:19 +02:00
cpu.c	cpu/hotplug: Cure the cpusets trainwreck	2021-07-20 16:17:46 +02:00
crash_core.c	kdump: write correct address of mem_section into vmcoreinfo	2018-01-17 09:45:27 +01:00
crash_dump.c
cred.c	memcg: account security cred as well to kmemcg	2020-01-09 10:17:54 +01:00
delayacct.c	delayacct: Use raw_spinlocks	2018-08-03 07:50:38 +02:00
dma.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
exec_domain.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
exit.c	don't dump the threads that had been already exiting when zapped.	2020-11-18 18:27:58 +01:00
extable.c
fork.c	mm/hugetlb: initialize hugetlb_usage in mm_init	2021-09-22 11:45:32 +02:00
freezer.c
futex.c	mm, futex: fix shared futex pgoff on shmem huge page	2021-07-11 12:48:12 +02:00
groups.c	kernel: make groups_sort calling a responsibility group_info allocators	2017-12-20 10:10:18 +01:00
hung_task.c	kernel: hung_task.c: disable on suspend	2019-04-20 09:15:05 +02:00
irq_work.c
jump_label.c	sched/core: Fix cpu.max vs. cpuhotplug deadlock	2018-12-05 19:41:17 +01:00
kallsyms.c	kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol	2019-09-21 07:15:38 +02:00
kcmp.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	kcov: ensure irq code sees a valid area	2018-08-03 07:50:22 +02:00
kexec_core.c	kexec: Allocate decrypted control pages for kdump if SME is enabled	2019-11-24 08:23:15 +01:00
kexec_file.c	kernel: kexec_file: fix error return code of kexec_calculate_store_digests()	2021-05-22 10:57:39 +02:00
kexec_internal.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
kexec.c
kmod.c	kmod: make request_module() return an error when autoloading is disabled	2020-04-24 08:00:44 +02:00
kprobes.c	kprobes: Limit max data_size of the kretprobe instances	2021-12-08 08:46:54 +01:00
ksysfs.c
kthread.c	kthread: prevent deadlock when kthread_mod_delayed_work() races with kthread_cancel_delayed_work_sync()	2021-07-11 12:48:13 +02:00
latencytop.c
Makefile	elfcore: fix building with clang	2021-02-10 09:12:08 +01:00
memremap.c	mm, devm_memremap_pages: kill mapping "System RAM" support	2019-01-13 10:01:02 +01:00
module_signing.c
module-internal.h
module.c	Revert "module, async: async_synchronize_full() on module init iff async is used"	2022-02-23 11:57:33 +01:00
notifier.c	x86/mm: split vmalloc_sync_all()	2020-04-02 16:34:20 +02:00
nsproxy.c
padata.c	padata: purge get_cpu and reorder_via_wq from padata_do_serial	2020-05-27 16:43:05 +02:00
panic.c	panic: ensure preemption is disabled during panic()	2019-10-17 13:43:19 -07:00
params.c	kernel/params.c: improve STANDARD_PARAM_DEF readability	2017-10-03 17:54:26 -07:00
pid_namespace.c	memcg: enable accounting for pids in nested pid namespaces	2021-09-22 11:45:32 +02:00
pid.c
profile.c	profiling: fix shift-out-of-bounds bugs	2021-09-26 13:37:28 +02:00
ptrace.c	ptrace: Reimplement PTRACE_KILL by always sending SIGKILL	2022-06-14 16:53:43 +02:00
range.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
reboot.c	reboot: fix overflow parsing reboot cpu number	2020-11-18 18:28:02 +01:00
relay.c	kernel/relay.c: fix memleak on destroy relay channel	2020-08-26 10:29:54 +02:00
resource.c	resource: fix integer overflow at reallocation	2018-04-24 09:36:22 +02:00
seccomp.c	seccomp: Invalidate seccomp mode to catch death failures	2022-02-16 12:44:52 +01:00
signal.c	signal: Remove the bogus sigkill_pending in ptrace_stop	2021-11-26 11:40:24 +01:00
smp.c	smp: Fix offline cpu check in flush_smp_call_function_queue()	2022-04-20 09:08:33 +02:00
smpboot.c	kthread: Extract KTHREAD_IS_PER_CPU	2021-02-07 14:47:41 +01:00
smpboot.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
softirq.c	Mark HI and TASKLET softirq synchronous	2018-08-15 18:12:47 +02:00
stacktrace.c
stop_machine.c	stop_machine: Atomically queue and wake stopper threads	2018-09-05 09:26:36 +02:00
sys_ni.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sys.c	prctl: allow to setup brk for et_dyn executables	2021-09-26 13:37:28 +02:00
sysctl_binary.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sysctl.c	x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting	2022-03-11 10:13:28 +01:00
task_work.c	locking/barriers: Convert users of lockless_dereference() to READ_ONCE()	2017-12-25 14:26:21 +01:00
taskstats.c	taskstats: fix data-race	2020-01-09 10:17:53 +01:00
test_kprobes.c
torture.c
tracepoint.c	tracepoint: Do not fail unregistering a probe due to memory failure	2021-03-03 18:22:47 +01:00
tsacct.c	taskstats: Cleanup the use of task->exit_code	2022-02-23 11:57:34 +01:00
ucount.c
uid16.c	kernel: make groups_sort calling a responsibility group_info allocators	2017-12-20 10:10:18 +01:00
umh.c	usermodehelper: reset umask to default before executing user process	2020-10-14 09:51:10 +02:00
up.c	smp: Fix smp_call_function_single_async prototype	2021-05-22 10:57:35 +02:00
user_namespace.c	userns: move user access out of the mutex	2018-09-09 19:56:00 +02:00
user-return-notifier.c
user.c
utsname_sysctl.c	sys: don't hold uts_sem while accessing userspace memory	2018-09-09 19:56:00 +02:00
utsname.c
watchdog_hld.c	watchdog: Mark watchdog touch functions as notrace	2018-09-05 09:26:42 +02:00
watchdog.c	watchdog/softlockup: Enforce that timestamp is valid on boot	2020-02-28 16:36:05 +01:00
workqueue_internal.h	Merge branch 'for-4.14-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq	2017-11-06 12:26:49 -08:00
workqueue.c	workqueue: fix UAF in pwq_unbound_release_workfn()	2021-08-04 12:22:14 +02:00