mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-16 00:34:20 +08:00
d6365d0f0a
In cases where both rx and tx lrck are synced to the same source, the resets for rx and tx need to be triggered simultaneously, according to the downstream driver. As there is no reset API to atomically bulk (de)assert two resets at once, what the driver did was implement half a reset controller specific to Rockchip, which tried to write the registers for the resets within one write ideally or several writes within an irqsave section. This of course violates abstractions quite badly. The driver should not write to the CRU's registers directly. In practice, for the cases I tested the driver with, which is audio playback, replacing the synchronised asserts with just individual ones does not seem to make any difference. If it turns out that this breaks something in the future, it should be fixed through the specification and implementation of an atomic bulk reset API, not with a CRU hack. Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Message-Id: <20211016105354.116513-2-frattaroli.nicolas@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| rk3288_hdmi_analog.c | ||
| rk3399_gru_sound.c | ||
| rockchip_i2s_tdm.c | ||
| rockchip_i2s_tdm.h | ||
| rockchip_i2s.c | ||
| rockchip_i2s.h | ||
| rockchip_max98090.c | ||
| rockchip_pcm.c | ||
| rockchip_pcm.h | ||
| rockchip_pdm.c | ||
| rockchip_pdm.h | ||
| rockchip_rt5645.c | ||
| rockchip_spdif.c | ||
| rockchip_spdif.h | ||