linux/drivers/net/ethernet/freescale/enetc
Vladimir Oltean 325fd36ae7 net: enetc: fix the incorrect clearing of IF_MODE bits
The enetc phylink .mac_config handler intends to clear the IFMODE field
(bits 1:0) of the PM0_IF_MODE register, but incorrectly clears all the
other fields instead.

For normal operation, the bug was inconsequential, due to the fact that
we write the PM0_IF_MODE register in two stages, first in
phylink .mac_config (which incorrectly cleared out a bunch of stuff),
then we update the speed and duplex to the correct values in
phylink .mac_link_up.

Judging by the code (not tested), it looks like maybe loopback mode was
broken, since this is one of the settings in PM0_IF_MODE which is
incorrectly cleared.

Fixes: c76a97218d ("net: enetc: force the RGMII speed and duplex instead of operating in inband mode")
Reported-by: Pavel Machek (CIP) <pavel@denx.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-09-24 14:03:04 +01:00
..
enetc_cbdr.c net: enetc: pass bd_count as an argument to enetc_setup_cbdr 2021-03-10 13:14:15 -08:00
enetc_ethtool.c ethtool: extend coalesce setting uAPI with CQE mode 2021-08-24 07:38:29 -07:00
enetc_hw.h net: enetc: add support for flow control 2021-04-19 15:31:45 -07:00
enetc_ierb.c net: update NXP copyright text 2021-09-17 13:52:17 +01:00
enetc_ierb.h net: update NXP copyright text 2021-09-17 13:52:17 +01:00
enetc_mdio.c enetc: reorder macros and functions 2021-01-05 15:19:19 -08:00
enetc_msg.c enetc: Add vf to pf messaging support 2019-01-24 21:55:53 -08:00
enetc_pci_mdio.c net: enetc: fix an issue about leak system resources 2020-05-04 10:51:20 -07:00
enetc_pf.c net: enetc: fix the incorrect clearing of IF_MODE bits 2021-09-24 14:03:04 +01:00
enetc_pf.h enetc: Migrate to PHYLINK and PCS_LYNX 2020-10-11 11:04:42 -07:00
enetc_ptp.c enetc: Add missing call to 'pci_free_irq_vectors()' in probe and remove functions 2019-08-31 23:53:17 -07:00
enetc_qos.c net: enetc: catch negative return code from enetc_pf_to_port() 2021-06-01 15:16:33 -07:00
enetc_vf.c dev_ioctl: split out ndo_eth_ioctl 2021-07-27 20:11:45 +01:00
enetc.c enetc: Fix uninitialized struct dim_sample field usage 2021-09-19 12:10:26 +01:00
enetc.h net: enetc: create a common enetc_pf_to_port helper 2021-04-19 15:31:45 -07:00
Kconfig net: enetc: automatically select IERB module 2021-04-20 16:56:32 -07:00
Makefile net: enetc: add a mini driver for the Integrated Endpoint Register Block 2021-04-19 15:31:45 -07:00