linux/sound/soc/qcom/qdsp6
Stephan Gerhold 0c824ec094
ASoC: q6dsp6: q6afe-dai: add missing channels to MI2S DAIs
For some reason, the MI2S DAIs do not have channels_min/max defined.
This means that snd_soc_dai_stream_valid() returns false,
i.e. the DAIs have neither valid playback nor capture stream.

It's quite surprising that this ever worked correctly,
but in 5.7-rc1 this is now failing badly: :)

Commit 0e9cf4c452 ("ASoC: pcm: check if cpu-dai supports a given stream")
introduced a check for snd_soc_dai_stream_valid() before calling
hw_params(), which means that the q6i2s_hw_params() function
was never called, eventually resulting in:

    qcom-q6afe aprsvc:q6afe:4:4: no line is assigned

... even though "qcom,sd-lines" is set in the device tree.

Commit 9b5db05936 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
now even avoids creating PCM devices if the stream is not supported,
which means that it is failing even earlier with e.g.:

    Primary MI2S: ASoC: no backend playback stream

Avoid all that trouble by adding channels_min/max for the MI2S DAIs.

Fixes: 24c4cbcfac ("ASoC: qdsp6: q6afe: Add q6afe dai driver")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200415150050.616392-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
2020-04-15 17:58:59 +01:00
..
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
q6adm.c ASoC: qcom: qdsp6: remove duplicated include from q6adm.c 2018-09-21 09:22:10 -07:00
q6adm.h ASoC: qdsp6: q6adm: Add q6adm driver 2018-05-21 16:40:24 +01:00
q6afe-dai.c ASoC: q6dsp6: q6afe-dai: add missing channels to MI2S DAIs 2020-04-15 17:58:59 +01:00
q6afe.c ASoC: qdsp6: qdafe: add support for display_port_rx 2018-12-14 12:48:51 +00:00
q6afe.h ASoC: qdsp6: qdafe: add support to tdm ports 2018-05-29 15:34:23 +01:00
q6asm-dai.c ASoC: qcom: q6asm-dai: Add SNDRV_PCM_INFO_BATCH flag 2020-03-31 19:23:54 +01:00
q6asm.c ASoC: qcom: q6asm: add support for alac and ape configs 2020-03-16 17:52:10 +00:00
q6asm.h ASoC: qcom: q6asm: add support for alac and ape configs 2020-03-16 17:52:10 +00:00
q6core.c ASoC: qdsp6: q6core: Use struct_size() in kmemdup() 2019-05-24 13:01:57 +01:00
q6core.h
q6dsp-common.c
q6dsp-common.h
q6dsp-errno.h
q6routing.c ASoC: qcom: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:44 +00:00
q6routing.h ASoC: qdsp6: q6routing: Add q6routing driver 2018-05-21 16:41:48 +01:00