mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-18 17:54:13 +08:00
b430acbd7c
acpi_hw_set_mode() double checks its effectiveness by calling acpi_hw_get_mode() -- polling up to 3 seconds. It would be more logical for its caller, acpi_enable() acpi_enable() to do the double-checking. (lets assume that acpi_disable() isn't interesting) The ACPI specification is unclear on this point. Some parts say that the BIOS sets SCI_EN and then returns to the OS, but one part says "OSPM polls the SCI_EN bit until it is sampled SET". The systems I have on hand do the former, SCI_EN is observed to be set upon return from the BIOS. So we move the check up out of acpi_hw_set_mode() up into acpi_enable() where it makes logical sense. Then we replace the 3-second polling loop with a single check. If this check fails, we'll see: "Hardware did not enter ACPI mode" and the system will bail out of ACPI initialization and likely fail to boot. If we see that in practice, we can restore the polling, but put it into acpi_enable. This patch is important if acpi_enable() is used in the resume from S3 path. Many systems today are seen coming back from S3 with SCI_EN off, and then failing to set SCI_EN in response to acpi_enable(). Those systems will take 3 seconds longer to resume due to this loop. However, it is possible that we will not use acpi_enable() in the S3 resume path, and bang SCI_EN directly, which would make the loop harmless, as it would be invisible to all systems except those that need it. Signed-off-by: Len Brown <len.brown@intel.com>
169 lines
5.2 KiB
C
169 lines
5.2 KiB
C
|
|
/******************************************************************************
|
|
*
|
|
* Module Name: hwacpi - ACPI Hardware Initialization/Mode Interface
|
|
*
|
|
*****************************************************************************/
|
|
|
|
/*
|
|
* Copyright (C) 2000 - 2010, Intel Corp.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions, and the following disclaimer,
|
|
* without modification.
|
|
* 2. Redistributions in binary form must reproduce at minimum a disclaimer
|
|
* substantially similar to the "NO WARRANTY" disclaimer below
|
|
* ("Disclaimer") and any redistribution must be conditioned upon
|
|
* including a substantially similar Disclaimer requirement for further
|
|
* binary redistribution.
|
|
* 3. Neither the names of the above-listed copyright holders nor the names
|
|
* of any contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
* Software Foundation.
|
|
*
|
|
* NO WARRANTY
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* HOLDERS OR CONTRIBUTORS BE LIABLE FOR SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
|
|
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
|
|
* IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGES.
|
|
*/
|
|
|
|
#include <acpi/acpi.h>
|
|
#include "accommon.h"
|
|
|
|
#define _COMPONENT ACPI_HARDWARE
|
|
ACPI_MODULE_NAME("hwacpi")
|
|
|
|
/******************************************************************************
|
|
*
|
|
* FUNCTION: acpi_hw_set_mode
|
|
*
|
|
* PARAMETERS: Mode - SYS_MODE_ACPI or SYS_MODE_LEGACY
|
|
*
|
|
* RETURN: Status
|
|
*
|
|
* DESCRIPTION: Transitions the system into the requested mode.
|
|
*
|
|
******************************************************************************/
|
|
acpi_status acpi_hw_set_mode(u32 mode)
|
|
{
|
|
|
|
acpi_status status;
|
|
|
|
ACPI_FUNCTION_TRACE(hw_set_mode);
|
|
|
|
/*
|
|
* ACPI 2.0 clarified that if SMI_CMD in FADT is zero,
|
|
* system does not support mode transition.
|
|
*/
|
|
if (!acpi_gbl_FADT.smi_command) {
|
|
ACPI_ERROR((AE_INFO,
|
|
"No SMI_CMD in FADT, mode transition failed"));
|
|
return_ACPI_STATUS(AE_NO_HARDWARE_RESPONSE);
|
|
}
|
|
|
|
/*
|
|
* ACPI 2.0 clarified the meaning of ACPI_ENABLE and ACPI_DISABLE
|
|
* in FADT: If it is zero, enabling or disabling is not supported.
|
|
* As old systems may have used zero for mode transition,
|
|
* we make sure both the numbers are zero to determine these
|
|
* transitions are not supported.
|
|
*/
|
|
if (!acpi_gbl_FADT.acpi_enable && !acpi_gbl_FADT.acpi_disable) {
|
|
ACPI_ERROR((AE_INFO,
|
|
"No ACPI mode transition supported in this system "
|
|
"(enable/disable both zero)"));
|
|
return_ACPI_STATUS(AE_OK);
|
|
}
|
|
|
|
switch (mode) {
|
|
case ACPI_SYS_MODE_ACPI:
|
|
|
|
/* BIOS should have disabled ALL fixed and GP events */
|
|
|
|
status = acpi_hw_write_port(acpi_gbl_FADT.smi_command,
|
|
(u32) acpi_gbl_FADT.acpi_enable, 8);
|
|
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
|
|
"Attempting to enable ACPI mode\n"));
|
|
break;
|
|
|
|
case ACPI_SYS_MODE_LEGACY:
|
|
|
|
/*
|
|
* BIOS should clear all fixed status bits and restore fixed event
|
|
* enable bits to default
|
|
*/
|
|
status = acpi_hw_write_port(acpi_gbl_FADT.smi_command,
|
|
(u32) acpi_gbl_FADT.acpi_disable,
|
|
8);
|
|
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
|
|
"Attempting to enable Legacy (non-ACPI) mode\n"));
|
|
break;
|
|
|
|
default:
|
|
return_ACPI_STATUS(AE_BAD_PARAMETER);
|
|
}
|
|
|
|
if (ACPI_FAILURE(status)) {
|
|
ACPI_EXCEPTION((AE_INFO, status,
|
|
"Could not write ACPI mode change"));
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
return_ACPI_STATUS(AE_OK);
|
|
}
|
|
|
|
/*******************************************************************************
|
|
*
|
|
* FUNCTION: acpi_hw_get_mode
|
|
*
|
|
* PARAMETERS: none
|
|
*
|
|
* RETURN: SYS_MODE_ACPI or SYS_MODE_LEGACY
|
|
*
|
|
* DESCRIPTION: Return current operating state of system. Determined by
|
|
* querying the SCI_EN bit.
|
|
*
|
|
******************************************************************************/
|
|
|
|
u32 acpi_hw_get_mode(void)
|
|
{
|
|
acpi_status status;
|
|
u32 value;
|
|
|
|
ACPI_FUNCTION_TRACE(hw_get_mode);
|
|
|
|
/*
|
|
* ACPI 2.0 clarified that if SMI_CMD in FADT is zero,
|
|
* system does not support mode transition.
|
|
*/
|
|
if (!acpi_gbl_FADT.smi_command) {
|
|
return_UINT32(ACPI_SYS_MODE_ACPI);
|
|
}
|
|
|
|
status = acpi_read_bit_register(ACPI_BITREG_SCI_ENABLE, &value);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_UINT32(ACPI_SYS_MODE_LEGACY);
|
|
}
|
|
|
|
if (value) {
|
|
return_UINT32(ACPI_SYS_MODE_ACPI);
|
|
} else {
|
|
return_UINT32(ACPI_SYS_MODE_LEGACY);
|
|
}
|
|
}
|