korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-15 16:24:13 +08:00
Code Issues Packages Projects Releases Wiki Activity
cb1bc12239
linux/sound/pci
History
Kuninori Morimoto cb1bc12239 ALSA: asihpi: check pao in control_message() 
[ Upstream commit 9026c0bf23 ]

control_message() might be called with pao = NULL.
Here indicates control_message() as sample.

(B)	static void control_message(struct hpi_adapter_obj *pao, ...)
	{                                                   ^^^
		struct hpi_hw_obj *phw = pao->priv;
		...                      ^^^
	}

(A)	void _HPI_6205(struct hpi_adapter_obj *pao, ...)
	{                                      ^^^
		...
		case HPI_OBJ_CONTROL:
(B)			control_message(pao, phm, phr);
			break;          ^^^
		...
	}

	void HPI_6205(...)
	{
		...
(A)		_HPI_6205(NULL, phm, phr);
		...       ^^^^
	}

Therefore, We will get too many warning via cppcheck, like below

	sound/pci/asihpi/hpi6205.c:238:27: warning: Possible null pointer dereference: pao [nullPointer]
		 struct hpi_hw_obj *phw = pao->priv;
		                          ^
	sound/pci/asihpi/hpi6205.c:433:13: note: Calling function '_HPI_6205', 1st argument 'NULL' value is 0
		  _HPI_6205(NULL, phm, phr);
		            ^
	sound/pci/asihpi/hpi6205.c:401:20: note: Calling function 'control_message', 1st argument 'pao' value is 0
	   control_message(pao, phm, phr);
	                   ^
Set phr->error like many functions doing, and don't call _HPI_6205()
with NULL.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ttypeaqz.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-05 11:24:53 +02:00
..
ac97 ALSA: ac97: fix possible memory leak in snd_ac97_dev_register() 2022-11-03 23:59:15 +09:00
ali5451 ALSA: ali5451: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:05 +02:00
asihpi ALSA: asihpi: check pao in control_message() 2023-04-05 11:24:53 +02:00
au88x0 ALSA: au88x0: use explicitly signed char 2022-11-03 23:59:10 +09:00
aw2 ALSA: aw2: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:05 +02:00
ca0106 ALSA: ca0106: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
cs46xx ALSA: cs46xx: Fix missing snd_card_free() call at probe error 2022-07-12 16:34:48 +02:00
cs5535audio ALSA: cs5535audio: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
ctxfi ALSA: ctxfi: Add SB046x PCI ID 2022-05-30 09:29:18 +02:00
echoaudio ALSA: echoaudio: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
emu10k1 ALSA: emu10k1: Fix out of bounds access in snd_emu10k1_pcm_channel_alloc() 2022-09-15 11:30:02 +02:00
hda ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book2 Pro 2023-03-22 13:31:33 +01:00
ice1712 ALSA: ice1712: Do not left ice->gpio_mutex locked in aureon_add_controls() 2023-03-10 09:40:04 +01:00
korg1212 ALSA: korg1212: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
lola ALSA: lola: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
lx6464es ALSA: pci: lx6464es: fix a debug loop 2023-02-14 19:18:01 +01:00
mixart ALSA: mixart: Fix assignment in if condition 2021-06-09 17:30:15 +02:00
nm256 ALSA: nm256: Don't call card private_free at probe error path 2022-04-20 09:34:09 +02:00
oxygen ALSA: oxygen: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
pcxhr ALSA: pcxhr: "fix" PCXHR_REG_TO_PORT definition 2021-09-16 11:09:04 +02:00
riptide ALSA: riptide: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
rme9652 ALSA: rme9652: use explicitly signed char 2022-11-03 23:59:11 +09:00
trident ALSA: trident: Allocate resources with device-managed APIs 2021-07-19 16:17:08 +02:00
vx222 ALSA: vx222: fix null-ptr-deref 2021-09-07 07:13:19 +02:00
ymfpci ALSA: ymfpci: Allocate resources with device-managed APIs 2021-07-19 16:17:11 +02:00
ad1889.c ALSA: ad1889: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:12 +02:00
ad1889.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ak4531_codec.c ALSA: ak4531: Fix assignment in if condition 2021-06-09 17:29:49 +02:00
als300.c ALSA: als300: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:05 +02:00
als4000.c ALSA: als4000: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:05 +02:00
atiixp_modem.c ALSA: atiixp: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:05 +02:00
atiixp.c ALSA: atiixp: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:05 +02:00
azt3328.c ALSA: azt3328: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
azt3328.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
bt87x.c ALSA: bt87x: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
cmipci.c ALSA: cmipci: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
cs4281.c ALSA: cs4281: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
cs5530.c ALSA: cs5530: Allocate resources with device-managed APIs 2021-07-19 16:16:43 +02:00
ens1370.c ALSA: ens137x: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
ens1371.c
es1938.c ALSA: es1938: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:06 +02:00
es1968.c ALSA: es1968: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
fm801.c ALSA: fm801: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
intel8x0.c ALSA: intel8x0: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
intel8x0m.c ALSA: intel8x0: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
Kconfig ALSA: ISA: not for M68K 2021-11-25 09:48:28 +01:00
maestro3.c ALSA: maestro3: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
rme32.c ALSA: rme32: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
rme96.c ALSA: rme96: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
sis7019.c ALSA: sis7019: Fix the missing error handling 2022-04-20 09:34:05 +02:00
sis7019.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 274 2019-06-05 17:30:30 +02:00
sonicvibes.c ALSA: sonicvibes: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
via82xx_modem.c ALSA: via82xx: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00
via82xx.c ALSA: via82xx: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:08 +02:00