Tejun Heo e8c8d1bc06 idr: remove MAX_IDR_MASK and move left MAX_IDR_* into idr.c ... MAX_IDR_MASK is another weirdness in the idr interface. As idr covers whole positive integer range, it's defined as 0x7fffffff or INT_MAX. Its usage in idr_find(), idr_replace() and idr_remove() is bizarre. They basically mask off the sign bit and operate on the rest, so if the caller, by accident, passes in a negative number, the sign bit will be masked off and the remaining part will be used as if that was the input, which is worse than crashing. The constant is visible in idr.h and there are several users in the kernel. * drivers/i2c/i2c-core.c:i2c_add_numbered_adapter() Basically used to test if adap->nr is a negative number which isn't -1 and returns -EINVAL if so. idr_alloc() already has negative @start checking (w/ WARN_ON_ONCE), so this can go away. * drivers/infiniband/core/cm.c:cm_alloc_id() drivers/infiniband/hw/mlx4/cm.c:id_map_alloc() Used to wrap cyclic @start. Can be replaced with max(next, 0). Note that this type of cyclic allocation using idr is buggy. These are prone to spurious -ENOSPC failure after the first wraparound. * fs/super.c:get_anon_bdev() The ID allocated from ida is masked off before being tested whether it's inside valid range. ida allocated ID can never be a negative number and the masking is unnecessary. Update idr_*() functions to fail with -EINVAL when negative @id is specified and update other MAX_IDR_MASK users as described above. This leaves MAX_IDR_MASK without any user, remove it and relocate other MAX_IDR_* constants to lib/idr.c. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Jean Delvare <khali@linux-fr.org> Cc: Roland Dreier <roland@kernel.org> Cc: Sean Hefty <sean.hefty@intel.com> Cc: Hal Rosenstock <hal.rosenstock@gmail.com> Cc: "Marciniszyn, Mike" <mike.marciniszyn@intel.com> Cc: Jack Morgenstein <jackm@dev.mellanox.co.il> Cc: Or Gerlitz <ogerlitz@mellanox.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Wolfram Sang <wolfram@the-dreams.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2013-02-27 19:10:20 -08:00
..
9p	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
adfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
affs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
afs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
autofs4	fs: change return values from -EACCES to -EPERM	2013-02-26 02:46:14 -05:00
befs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
bfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
btrfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
cachefiles	FS-Cache: Mark cancellation of in-progress operation	2012-12-20 22:34:00 +00:00
ceph	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
cifs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
coda	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
configfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
cramfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
debugfs	Merge 3.9-rc4 into driver-core-next	2013-01-17 19:48:18 -08:00
devpts	userns: Allow the userns root to mount of devpts	2013-01-26 22:22:21 -08:00
dlm	dlm: convert to idr_alloc()	2013-02-27 19:10:19 -08:00
ecryptfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
efs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
exofs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
exportfs	Merge branch 'for-3.8' of git://linux-nfs.org/~bfields/linux	2012-12-20 14:04:11 -08:00
ext2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
ext3	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
ext4	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
f2fs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
fat	fat: mark fs as dirty on mount and clean on umount	2013-02-27 19:10:11 -08:00
freevxfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
fscache	FS-Cache: Clear remaining page count on retrieval cancellation	2012-12-20 22:35:15 +00:00
fuse	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
gfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
hfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
hfsplus	hfsplus: fix issue with unzeroed unused b-tree nodes	2013-02-27 19:10:10 -08:00
hostfs	hostfs: directory methods have no business in non-directory inode_operations	2013-02-22 23:31:37 -05:00
hpfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
hppfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
hugetlbfs	hugetlb_file_setup(): use d_alloc_pseudo()	2013-02-26 02:45:52 -05:00
isofs	fs: encode_fh: return FILEID_INVALID if invalid fid_type	2013-02-26 02:46:10 -05:00
jbd	jbd: don't wake kjournald unnecessarily	2013-01-14 22:50:45 +01:00
jbd2	jbd2: use module parameters instead of debugfs for jbd_debug	2013-02-09 16:29:20 -05:00
jffs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
jfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
lockd	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
logfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
minix	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
ncpfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
nfs	nfs4client: convert to idr_alloc()	2013-02-27 19:10:20 -08:00
nfs_common	nfs_common: Update the translation between nfsv3 acls linux posix acls	2013-02-13 06:15:14 -08:00
nfsd	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
nilfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
nls
notify	inotify: convert to idr_alloc()	2013-02-27 19:10:19 -08:00
ntfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
ocfs2	ocfs2: convert to idr_alloc()	2013-02-27 19:10:19 -08:00
omfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
openpromfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
proc	fs/proc/vmcore.c: put if tests in the top of the while loop to reduce duplication	2013-02-27 19:10:11 -08:00
pstore	A few fixes to reduce places where pstore might hang	2013-02-21 09:38:18 -08:00
qnx4	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
qnx6	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
quota	quota: Use the pre-processor to compile out quotactl_cmd_write when !CONFIG_BLOCK	2012-12-13 16:33:24 +01:00
ramfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
reiserfs	fs: encode_fh: return FILEID_INVALID if invalid fid_type	2013-02-26 02:46:10 -05:00
romfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
squashfs	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
sysfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
sysv	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
ubifs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
udf	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
ufs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
xfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
aio.c	mm: make do_mmap_pgoff return populate as a size in bytes, not as a bool	2013-02-23 17:50:11 -08:00
anon_inodes.c	get_empty_filp()/alloc_file() leave both ->f_pos and ->f_version zero	2013-02-26 02:46:11 -05:00
attr.c	userns: Allow chown and setgid preservation	2012-11-20 04:17:24 -08:00
bad_inode.c	lseek: the "whence" argument is called "whence"	2012-12-17 17:15:12 -08:00
binfmt_aout.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
binfmt_elf_fdpic.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
binfmt_elf.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
binfmt_em86.c	exec: use -ELOOP for max recursion depth	2012-12-17 17:15:23 -08:00
binfmt_flat.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
binfmt_misc.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
binfmt_script.c	exec: do not leave bprm->interp on stack	2012-12-20 17:40:19 -08:00
binfmt_som.c	get rid of pt_regs argument of ->load_binary()	2012-11-28 21:53:38 -05:00
bio-integrity.c
bio.c	vfs: fix: don't increase bio_slab_max if krealloc() fails	2012-10-22 22:00:26 +02:00
block_dev.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
buffer.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-02-26 20:16:07 -08:00
char_dev.c	char_dev: pin parent kobject	2012-10-22 08:50:37 +03:00
compat_binfmt_elf.c	coredump: extend core dump note section to contain file names of mapped files	2012-10-06 03:05:17 +09:00
compat_ioctl.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
compat.c	switch timerfd compat syscalls to COMPAT_SYSCALL_DEFINE	2013-02-03 15:09:25 -05:00
coredump.c	coredump: remove redundant defines for dumpable states	2013-02-27 19:10:11 -08:00
coredump.h	coredump: update coredump-related headers	2012-10-06 03:05:15 +09:00
dcache.c	vfs: kill FS_REVAL_DOT by adding a d_weak_revalidate dentry op	2013-02-26 02:46:09 -05:00
dcookies.c
direct-io.c	fs: Fix possible use-after-free with AIO	2013-02-22 23:31:36 -05:00
drop_caches.c
eventfd.c	fs, eventfd: add procfs fdinfo helper	2012-12-17 17:15:27 -08:00
eventpoll.c	epoll: prevent missed events on EPOLL_CTL_MOD	2013-01-02 09:16:43 -08:00
exec.c	coredump: remove redundant defines for dumpable states	2013-02-27 19:10:11 -08:00
fcntl.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
fhandle.c	Merge branch 'for-3.8' of git://linux-nfs.org/~bfields/linux	2012-12-20 14:04:11 -08:00
fifo.c
file_table.c	fs: Preserve error code in get_empty_filp(), part 2	2013-02-22 23:31:32 -05:00
file.c	locking: Various static lock initializer fixes	2013-02-19 08:42:45 +01:00
filesystems.c	vfs: define struct filename and have getname() return it	2012-10-12 20:14:55 -04:00
fs_struct.c	kill daemonize()	2012-11-28 21:49:02 -05:00
fs-writeback.c	writeback: fix a typo in comment	2012-12-12 17:38:34 -08:00
generic_acl.c
inode.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
internal.h	writeback: put unused inodes to LRU after writeback completion	2012-11-26 17:41:24 -08:00
ioctl.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
ioprio.c
Kconfig	fuse: Move CUSE Kconfig entry from fs/Kconfig into fs/fuse/Kconfig	2013-01-17 13:08:45 +01:00
Kconfig.binfmt
libfs.c	vfs: drop vmtruncate	2012-12-20 18:46:29 -05:00
locks.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
Makefile	f2fs: update Kconfig and Makefile	2012-12-11 13:43:42 +09:00
mbcache.c
mount.h	proc: Usable inode numbers for the namespace file descriptors.	2012-11-20 04:19:49 -08:00
mpage.c
namei.c	vfs: kill FS_REVAL_DOT by adding a d_weak_revalidate dentry op	2013-02-26 02:46:09 -05:00
namespace.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
no-block.c
open.c	get_empty_filp()/alloc_file() leave both ->f_pos and ->f_version zero	2013-02-26 02:46:11 -05:00
pipe.c	fs: Preserve error code in get_empty_filp(), part 2	2013-02-22 23:31:32 -05:00
pnode.c
pnode.h	vfs: Only support slave subtrees across different user namespaces	2012-11-19 05:59:20 -08:00
posix_acl.c
proc_namespace.c
read_write.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
read_write.h
readdir.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
select.c	sched/rt: Move rt specific bits into new header file	2013-02-07 20:51:08 +01:00
seq_file.c	fs/seq_file.c:seq_lseek(): fix switch statement indenting	2013-02-27 19:10:12 -08:00
signalfd.c	fs, epoll: add procfs fdinfo helper	2012-12-17 17:15:27 -08:00
splice.c	export kernel_write(), convert open-coded instances	2013-02-26 02:46:11 -05:00
stack.c
stat.c	switch vfs_getattr() to struct path	2013-02-26 02:46:08 -05:00
statfs.c	vfs: fix user_statfs to retry once on ESTALE errors	2012-12-20 18:50:07 -05:00
super.c	idr: remove MAX_IDR_MASK and move left MAX_IDR_* into idr.c	2013-02-27 19:10:20 -08:00
sync.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
timerfd.c	switch timerfd compat syscalls to COMPAT_SYSCALL_DEFINE	2013-02-03 15:09:25 -05:00
utimes.c	vfs: allow utimensat() calls to retry once on an ESTALE error	2012-12-20 18:50:08 -05:00
xattr_acl.c	userns: Fix posix_acl_file_xattr_userns gid conversion	2012-10-12 13:16:48 -07:00
xattr.c	vfs: make lremovexattr retry once on ESTALE error	2012-12-20 18:50:11 -05:00