mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-22 18:44:44 +08:00
ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
131 lines
2.5 KiB
C
131 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Allegro A8293 SEC driver
|
|
*
|
|
* Copyright (C) 2011 Antti Palosaari <crope@iki.fi>
|
|
*/
|
|
|
|
#include "a8293.h"
|
|
|
|
struct a8293_dev {
|
|
struct i2c_client *client;
|
|
u8 reg[2];
|
|
};
|
|
|
|
static int a8293_set_voltage(struct dvb_frontend *fe,
|
|
enum fe_sec_voltage fe_sec_voltage)
|
|
{
|
|
struct a8293_dev *dev = fe->sec_priv;
|
|
struct i2c_client *client = dev->client;
|
|
int ret;
|
|
u8 reg0, reg1;
|
|
|
|
dev_dbg(&client->dev, "fe_sec_voltage=%d\n", fe_sec_voltage);
|
|
|
|
switch (fe_sec_voltage) {
|
|
case SEC_VOLTAGE_OFF:
|
|
/* ENB=0 */
|
|
reg0 = 0x10;
|
|
break;
|
|
case SEC_VOLTAGE_13:
|
|
/* VSEL0=1, VSEL1=0, VSEL2=0, VSEL3=0, ENB=1*/
|
|
reg0 = 0x31;
|
|
break;
|
|
case SEC_VOLTAGE_18:
|
|
/* VSEL0=0, VSEL1=0, VSEL2=0, VSEL3=1, ENB=1*/
|
|
reg0 = 0x38;
|
|
break;
|
|
default:
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
if (reg0 != dev->reg[0]) {
|
|
ret = i2c_master_send(client, ®0, 1);
|
|
if (ret < 0)
|
|
goto err;
|
|
dev->reg[0] = reg0;
|
|
}
|
|
|
|
/* TMODE=0, TGATE=1 */
|
|
reg1 = 0x82;
|
|
if (reg1 != dev->reg[1]) {
|
|
ret = i2c_master_send(client, ®1, 1);
|
|
if (ret < 0)
|
|
goto err;
|
|
dev->reg[1] = reg1;
|
|
}
|
|
|
|
usleep_range(1500, 50000);
|
|
return 0;
|
|
err:
|
|
dev_dbg(&client->dev, "failed=%d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
static int a8293_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct a8293_dev *dev;
|
|
struct a8293_platform_data *pdata = client->dev.platform_data;
|
|
struct dvb_frontend *fe = pdata->dvb_frontend;
|
|
int ret;
|
|
u8 buf[2];
|
|
|
|
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
|
|
if (!dev) {
|
|
ret = -ENOMEM;
|
|
goto err;
|
|
}
|
|
|
|
dev->client = client;
|
|
|
|
/* check if the SEC is there */
|
|
ret = i2c_master_recv(client, buf, 2);
|
|
if (ret < 0)
|
|
goto err_kfree;
|
|
|
|
/* override frontend ops */
|
|
fe->ops.set_voltage = a8293_set_voltage;
|
|
fe->sec_priv = dev;
|
|
i2c_set_clientdata(client, dev);
|
|
|
|
dev_info(&client->dev, "Allegro A8293 SEC successfully attached\n");
|
|
return 0;
|
|
err_kfree:
|
|
kfree(dev);
|
|
err:
|
|
dev_dbg(&client->dev, "failed=%d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
static void a8293_remove(struct i2c_client *client)
|
|
{
|
|
struct a8293_dev *dev = i2c_get_clientdata(client);
|
|
|
|
dev_dbg(&client->dev, "\n");
|
|
|
|
kfree(dev);
|
|
}
|
|
|
|
static const struct i2c_device_id a8293_id_table[] = {
|
|
{"a8293", 0},
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, a8293_id_table);
|
|
|
|
static struct i2c_driver a8293_driver = {
|
|
.driver = {
|
|
.name = "a8293",
|
|
.suppress_bind_attrs = true,
|
|
},
|
|
.probe = a8293_probe,
|
|
.remove = a8293_remove,
|
|
.id_table = a8293_id_table,
|
|
};
|
|
|
|
module_i2c_driver(a8293_driver);
|
|
|
|
MODULE_AUTHOR("Antti Palosaari <crope@iki.fi>");
|
|
MODULE_DESCRIPTION("Allegro A8293 SEC driver");
|
|
MODULE_LICENSE("GPL");
|