mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-29 22:14:41 +08:00
135f4b9e93
The ice_setup_pf_sw function can cause a memory leak if register_netdev
fails, due to accidentally failing to free the VSI rings. Fix the memory
leak by using ice_vsi_release, ensuring we actually go through the full
teardown process.
This should be safe even if the netdevice is not registered because we
will have set the netdev pointer to NULL, ensuring ice_vsi_release won't
call unregister_netdev.
An alternative fix would be moving management of the PF VSI netdev into
the main VSI setup code. This is complicated and likely requires
significant refactor in how we manage VSIs
Fixes: 3a858ba392 ("ice: Add support for VSI allocation and deallocation")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
111 lines
2.9 KiB
C
111 lines
2.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (c) 2018, Intel Corporation. */
|
|
|
|
#ifndef _ICE_LIB_H_
|
|
#define _ICE_LIB_H_
|
|
|
|
#include "ice.h"
|
|
|
|
const char *ice_vsi_type_str(enum ice_vsi_type vsi_type);
|
|
|
|
bool ice_pf_state_is_nominal(struct ice_pf *pf);
|
|
|
|
void ice_update_eth_stats(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_cfg_rxqs(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_cfg_lan_txqs(struct ice_vsi *vsi);
|
|
|
|
void ice_vsi_cfg_msix(struct ice_vsi *vsi);
|
|
|
|
int
|
|
ice_vsi_add_vlan(struct ice_vsi *vsi, u16 vid, enum ice_sw_fwd_act_type action);
|
|
|
|
int ice_vsi_kill_vlan(struct ice_vsi *vsi, u16 vid);
|
|
|
|
int ice_vsi_manage_vlan_insertion(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_manage_vlan_stripping(struct ice_vsi *vsi, bool ena);
|
|
|
|
int ice_vsi_start_all_rx_rings(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_stop_all_rx_rings(struct ice_vsi *vsi);
|
|
|
|
int
|
|
ice_vsi_stop_lan_tx_rings(struct ice_vsi *vsi, enum ice_disq_rst_src rst_src,
|
|
u16 rel_vmvf_num);
|
|
|
|
int ice_vsi_cfg_xdp_txqs(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_stop_xdp_tx_rings(struct ice_vsi *vsi);
|
|
|
|
bool ice_vsi_is_vlan_pruning_ena(struct ice_vsi *vsi);
|
|
|
|
int ice_cfg_vlan_pruning(struct ice_vsi *vsi, bool ena, bool vlan_promisc);
|
|
|
|
void ice_cfg_sw_lldp(struct ice_vsi *vsi, bool tx, bool create);
|
|
|
|
#ifdef CONFIG_DCB
|
|
int ice_vsi_cfg_tc(struct ice_vsi *vsi, u8 ena_tc);
|
|
#endif /* CONFIG_DCB */
|
|
|
|
struct ice_vsi *
|
|
ice_vsi_setup(struct ice_pf *pf, struct ice_port_info *pi,
|
|
enum ice_vsi_type vsi_type, u16 vf_id);
|
|
|
|
void ice_napi_del(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_release(struct ice_vsi *vsi);
|
|
|
|
void ice_vsi_close(struct ice_vsi *vsi);
|
|
|
|
int ice_ena_vsi(struct ice_vsi *vsi, bool locked);
|
|
|
|
void ice_dis_vsi(struct ice_vsi *vsi, bool locked);
|
|
|
|
int ice_free_res(struct ice_res_tracker *res, u16 index, u16 id);
|
|
|
|
int
|
|
ice_get_res(struct ice_pf *pf, struct ice_res_tracker *res, u16 needed, u16 id);
|
|
|
|
int ice_vsi_rebuild(struct ice_vsi *vsi, bool init_vsi);
|
|
|
|
bool ice_is_reset_in_progress(unsigned long *state);
|
|
|
|
void
|
|
ice_write_qrxflxp_cntxt(struct ice_hw *hw, u16 pf_q, u32 rxdid, u32 prio);
|
|
|
|
void ice_vsi_dis_irq(struct ice_vsi *vsi);
|
|
|
|
void ice_vsi_free_irq(struct ice_vsi *vsi);
|
|
|
|
void ice_vsi_free_rx_rings(struct ice_vsi *vsi);
|
|
|
|
void ice_vsi_free_tx_rings(struct ice_vsi *vsi);
|
|
|
|
int ice_vsi_manage_rss_lut(struct ice_vsi *vsi, bool ena);
|
|
|
|
void ice_update_tx_ring_stats(struct ice_ring *ring, u64 pkts, u64 bytes);
|
|
|
|
void ice_update_rx_ring_stats(struct ice_ring *ring, u64 pkts, u64 bytes);
|
|
|
|
void ice_vsi_cfg_frame_size(struct ice_vsi *vsi);
|
|
|
|
int ice_status_to_errno(enum ice_status err);
|
|
|
|
u32 ice_intrl_usec_to_reg(u8 intrl, u8 gran);
|
|
|
|
enum ice_status
|
|
ice_vsi_cfg_mac_fltr(struct ice_vsi *vsi, const u8 *macaddr, bool set);
|
|
|
|
bool ice_is_safe_mode(struct ice_pf *pf);
|
|
|
|
bool ice_is_dflt_vsi_in_use(struct ice_sw *sw);
|
|
|
|
bool ice_is_vsi_dflt_vsi(struct ice_sw *sw, struct ice_vsi *vsi);
|
|
|
|
int ice_set_dflt_vsi(struct ice_sw *sw, struct ice_vsi *vsi);
|
|
|
|
int ice_clear_dflt_vsi(struct ice_sw *sw);
|
|
#endif /* !_ICE_LIB_H_ */
|