Eric Dumazet ff999198ec net-timestamp: convert sk->sk_tskey to atomic_t ... [ Upstream commit a1cdec57e0 ] UDP sendmsg() can be lockless, this is causing all kinds of data races. This patch converts sk->sk_tskey to remove one of these races. BUG: KCSAN: data-race in __ip_append_data / __ip_append_data read to 0xffff8881035d4b6c of 4 bytes by task 8877 on cpu 1: __ip_append_data+0x1c1/0x1de0 net/ipv4/ip_output.c:994 ip_make_skb+0x13f/0x2d0 net/ipv4/ip_output.c:1636 udp_sendmsg+0x12bd/0x14c0 net/ipv4/udp.c:1249 inet_sendmsg+0x5f/0x80 net/ipv4/af_inet.c:819 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x39a/0x510 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmmsg+0x267/0x4c0 net/socket.c:2553 __do_sys_sendmmsg net/socket.c:2582 [inline] __se_sys_sendmmsg net/socket.c:2579 [inline] __x64_sys_sendmmsg+0x53/0x60 net/socket.c:2579 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae write to 0xffff8881035d4b6c of 4 bytes by task 8880 on cpu 0: __ip_append_data+0x1d8/0x1de0 net/ipv4/ip_output.c:994 ip_make_skb+0x13f/0x2d0 net/ipv4/ip_output.c:1636 udp_sendmsg+0x12bd/0x14c0 net/ipv4/udp.c:1249 inet_sendmsg+0x5f/0x80 net/ipv4/af_inet.c:819 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x39a/0x510 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmmsg+0x267/0x4c0 net/socket.c:2553 __do_sys_sendmmsg net/socket.c:2582 [inline] __se_sys_sendmmsg net/socket.c:2579 [inline] __x64_sys_sendmmsg+0x53/0x60 net/socket.c:2579 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae value changed: 0x0000054d -> 0x0000054e Reported by Kernel Concurrency Sanitizer on: CPU: 0 PID: 8880 Comm: syz-executor.5 Not tainted 5.17.0-rc2-syzkaller-00167-gdcb85f85fa6f-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Fixes: 09c2d251b7 ("net-timestamp: add key to disambiguate concurrent datagrams") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willem de Bruijn <willemb@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-02 11:48:01 +01:00
..
acpi	ACPICA: actypes.h: Expand the ACPI_ACCESS_ definitions	2022-01-27 11:04:49 +01:00
asm-generic	bitops: protect find_first_{,zero}_bit properly	2022-01-27 11:05:34 +01:00
clocksource
crypto
drm	drm/ttm: remove ttm_bo_vm_insert_huge()	2021-11-18 19:17:08 +01:00
dt-bindings	linux-watchdog 5.15-rc1 tag	2021-09-07 13:52:46 -07:00
keys
kunit	kunit: fix kernel-doc warnings due to mismatched arg names	2021-10-06 17:54:07 -06:00
kvm	KVM: arm64: Fix PMU probe ordering	2021-09-20 12:43:34 +01:00
linux	bpf: Fix a bpf_timer initialization issue	2022-03-02 11:47:55 +01:00
math-emu
media	media: cec: fix a deadlock situation	2022-01-27 11:02:53 +01:00
memory	memory: renesas-rpc-if: Correct QSPI data transfer in Manual mode	2021-11-18 19:16:01 +01:00
misc
net	net-timestamp: convert sk->sk_tskey to atomic_t	2022-03-02 11:48:01 +01:00
pcmcia
ras
rdma	RDMA/netlink: Add __maybe_unused to static inline in C file	2021-11-25 09:49:07 +01:00
scsi	scsi: core: Avoid leaving shost->last_reset with stale value if EH does not run	2021-11-18 19:15:51 +01:00
soc	net: dsa: tag_ocelot_8021q: break circular dependency with ocelot switch lib	2021-10-12 17:35:18 -07:00
sound	ALSA: hda: Fix potential deadlock at codec unbinding	2022-01-27 11:04:05 +01:00
target	scsi: target: Fix ordered tag handling	2021-11-25 09:48:29 +01:00
trace	SUNRPC: Don't dereference xprt->snd_task if it's a cookie	2022-02-01 17:27:09 +01:00
uapi	netfilter: ctnetlink: disable helper autoassign	2022-02-16 12:56:25 +01:00
vdso
video
xen	xen/console: harden hvc_xen against event channel storms	2021-12-22 09:32:52 +01:00