Amir Goldstein e6023ab8c7 fsnotify: fix fsnotify hooks in pseudo filesystems ... commit 29044dae2e upstream. Commit 49246466a9 ("fsnotify: move fsnotify_nameremove() hook out of d_delete()") moved the fsnotify delete hook before d_delete() so fsnotify will have access to a positive dentry. This allowed a race where opening the deleted file via cached dentry is now possible after receiving the IN_DELETE event. To fix the regression in pseudo filesystems, convert d_delete() calls to d_drop() (see commit 46c46f8df9 ("devpts_pty_kill(): don't bother with d_delete()") and move the fsnotify hook after d_drop(). Add a missing fsnotify_unlink() hook in nfsdfs that was found during the audit of fsnotify hooks in pseudo filesystems. Note that the fsnotify hooks in simple_recursive_removal() follow d_invalidate(), so they require no change. Link: https://lore.kernel.org/r/20220120215305.282577-2-amir73il@gmail.com Reported-by: Ivan Delalande <colona@arista.com> Link: https://lore.kernel.org/linux-fsdevel/YeNyzoDM5hP5LtGW@visor/ Fixes: 49246466a9 ("fsnotify: move fsnotify_nameremove() hook out of d_delete()") Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-02-01 17:27:01 +01:00
..
configfs_internal.h	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
dir.c	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:27:01 +01:00
file.c	configfs: restore the kernel v5.13 text attribute write behavior	2021-08-09 16:56:00 +02:00
inode.c	fs: move ramfs_aops to libfs	2021-06-29 10:53:48 -07:00
item.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
mount.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
symlink.c	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00