Breno Leitao cc7340f18e virtio_net: Fix napi_skb_cache_put warning ... commit f8321fa751 upstream. After the commit bdacf3e349 ("net: Use nested-BH locking for napi_alloc_cache.") was merged, the following warning began to appear: WARNING: CPU: 5 PID: 1 at net/core/skbuff.c:1451 napi_skb_cache_put+0x82/0x4b0 __warn+0x12f/0x340 napi_skb_cache_put+0x82/0x4b0 napi_skb_cache_put+0x82/0x4b0 report_bug+0x165/0x370 handle_bug+0x3d/0x80 exc_invalid_op+0x1a/0x50 asm_exc_invalid_op+0x1a/0x20 __free_old_xmit+0x1c8/0x510 napi_skb_cache_put+0x82/0x4b0 __free_old_xmit+0x1c8/0x510 __free_old_xmit+0x1c8/0x510 __pfx___free_old_xmit+0x10/0x10 The issue arises because virtio is assuming it's running in NAPI context even when it's not, such as in the netpoll case. To resolve this, modify virtnet_poll_tx() to only set NAPI when budget is available. Same for virtnet_poll_cleantx(), which always assumed that it was in a NAPI context. Fixes: df133f3f96 ("virtio_net: bulk free tx skbs") Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Jakub Kicinski <kuba@kernel.org> Acked-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Heng Qi <hengqi@linux.alibaba.com> Link: https://patch.msgid.link/20240712115325.54175-1-leitao@debian.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> [Shivani: Modified to apply on v6.6.y] Signed-off-by: Shivani Agarwal <shivani.agarwal@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-09-12 11:07:42 +02:00
..
accessibility	speakup: Fix sizeof() vs ARRAY_SIZE() bug	2024-06-16 13:39:11 +02:00
acpi	ACPI: SBS: manage alarm sysfs attribute through psy core	2024-08-19 05:45:37 +02:00
amba
android	binder: fix hang of unregistered readers	2024-08-19 05:45:16 +02:00
ata	ata: libata-core: Fix null pointer dereference on error	2024-09-04 13:23:38 +02:00
atm	atm: idt77252: prevent use after free in dequeue_rx()	2024-09-04 13:23:18 +02:00
auxdisplay
base	driver core: Fix uevent_show() vs driver detach race	2024-08-19 05:45:45 +02:00
bcma
block	rbd: don't assume RBD_LOCK_STATE_LOCKED for exclusive mappings	2024-08-19 05:45:22 +02:00
bluetooth	Bluetooth: hci_ldisc: check HCI_UART_PROTO_READY flag in HCIUARTGETPROTO	2024-09-04 13:23:37 +02:00
bus	bus: tegra-aconnect: Update dependency to ARCH_TEGRA	2024-03-26 18:21:19 -04:00
cdrom
char	char: xillybus: Check USB endpoints when probing device	2024-09-04 13:23:15 +02:00
clk	clk: davinci: da8xx-cfgchip: Initialize clk_init_data before use	2024-08-19 05:45:16 +02:00
clocksource	clocksource/drivers/arm_global_timer: Guard against division by zero	2024-09-04 13:23:25 +02:00
comedi	comedi: vmk80xx: fix incomplete endpoint checking	2024-04-27 17:05:26 +02:00
connector
counter
cpufreq	cpufreq: scmi: Avoid overflow of target_freq in fast switch	2024-09-12 11:07:41 +02:00
cpuidle	cpuidle: Avoid potential overflow in integer multiplication	2024-04-13 13:01:43 +02:00
crypto	crypto: hisilicon/sec - Fix memory leak for sec resource release	2024-07-05 09:14:24 +02:00
cxl
dax
dca
devfreq	PM / devfreq: Synchronize devfreq_monitor_[start/stop]	2024-02-23 08:54:38 +01:00
dio
dma	dmaengine: dw: Add memory bus width verification	2024-09-04 13:23:40 +02:00
dma-buf	dma-buf/sw-sync: don't enable IRQ from sync_print_obj()	2024-06-16 13:39:49 +02:00
edac	EDAC, i10nm: make skx_common.o a separate module	2024-08-19 05:44:49 +02:00
eisa
extcon	extcon: max8997: select IRQ_DOMAIN instead of depending on it	2024-06-16 13:39:39 +02:00
firewire	firewire: nosy: ensure user_length is taken into account when fetching packet contents	2024-05-17 11:51:01 +02:00
firmware	firmware: turris-mox-rwtm: Initialize completion before mailbox	2024-08-19 05:44:55 +02:00
fpga	fpga: region: add owner module and take its refcount	2024-06-16 13:39:38 +02:00
fsi
gnss
gpio	gpiolib: of: add polarity quirk for TSC2005	2024-07-18 13:07:32 +02:00
gpu	drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr	2024-09-12 11:07:42 +02:00
greybus	greybus: Fix use-after-free bug in gb_interface_release due to race condition.	2024-07-05 09:14:23 +02:00
hid	HID: microsoft: Add rumble support to latest xbox controllers	2024-09-04 13:23:36 +02:00
hsi
hv
hwmon	hwmon: (ltc2992) Fix memory leak in ltc2992_parse_dt()	2024-09-04 13:23:36 +02:00
hwspinlock	hwspinlock: Introduce hwspin_lock_bust()	2024-09-12 11:07:41 +02:00
hwtracing	coresight: Fix ref leak when of_coresight_parse_endpoint() fails	2024-08-19 05:45:04 +02:00
i2c	i2c: riic: avoid potential division by zero	2024-09-04 13:23:20 +02:00
i3c	i3c: mipi-i3c-hci: Do not unmap region not mapped for transfer	2024-09-04 13:23:21 +02:00
idle
iio	iio: chemical: bme680: Fix sensor data read operation	2024-07-05 09:14:46 +02:00
infiniband	RDMA/efa: Properly handle unexpected AQ completions	2024-09-12 11:07:41 +02:00
input	Input: MT - limit max slots	2024-09-04 13:23:37 +02:00
interconnect	Revert "interconnect: Teach lockdep about icc_bw_lock order"	2024-03-06 14:38:50 +00:00
iommu	iommu: sprd: Avoid NULL deref in sprd_iommu_hw_en	2024-08-19 05:45:26 +02:00
ipack
irqchip	irqchip/gic-v3-its: Remove BUG_ON in its_vpe_irq_domain_alloc	2024-09-04 13:23:28 +02:00
isdn	mISDN: Fix a use after free in hfcmulti_tx()	2024-08-19 05:45:25 +02:00
leds	leds: triggers: Flush pending brightness before activating trigger	2024-08-19 05:45:29 +02:00
macintosh	macintosh/therm_windtunnel: fix module unload.	2024-08-19 05:45:06 +02:00
mailbox	mailbox: arm_mhuv2: Fix a bug for mhuv2_sender_interrupt	2024-02-23 08:54:50 +01:00
mcb
md	dm suspend: return -ERESTARTSYS instead of -EINTR	2024-09-04 13:23:31 +02:00
media	media: uvcvideo: Enforce alignment of frame and interval	2024-09-12 11:07:42 +02:00
memory	memory: stm32-fmc2-ebi: check regmap_read return value	2024-09-04 13:23:25 +02:00
memstick
message
mfd	mfd: omap-usb-tll: Use struct_size to allocate tll	2024-08-19 05:45:03 +02:00
misc	mei: demote client disconnect warning on suspend to debug	2024-07-27 10:46:10 +02:00
mmc	mmc: dw_mmc: allow biu and ciu clocks to defer	2024-09-04 13:23:36 +02:00
most
mtd	ubi: eba: properly rollback inside self_check_eba	2024-08-19 05:45:16 +02:00
mux
net	virtio_net: Fix napi_skb_cache_put warning	2024-09-12 11:07:42 +02:00
nfc	nfc: pn533: Add poll mod list filling check	2024-09-04 13:23:40 +02:00
ntb	NTB: fix possible name leak in ntb_register_device()	2024-03-26 18:21:28 -04:00
nubus
nvdimm
nvme	nvmet-rdma: fix possible bad dereference when freeing rsps	2024-09-04 13:23:28 +02:00
nvmem	nvmem: core: only change name to fram for current attribute	2024-07-18 13:07:42 +02:00
of	cma: factor out minimum alignment requirement	2024-07-05 09:14:13 +02:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-03-26 18:21:23 -04:00
parisc
parport	dev/parport: fix the array out-of-bounds risk	2024-08-19 05:45:16 +02:00
pci	PCI: al: Check IORESOURCE_BUS existence during probe	2024-09-12 11:07:41 +02:00
pcmcia
perf
phy	phy: zynqmp: Enable reference clock correctly	2024-09-04 13:23:42 +02:00
pinctrl	pinctrl: single: fix potential NULL dereference in pcs_get_function()	2024-09-04 13:23:37 +02:00
platform	platform/surface: aggregator: Fix warning when controller is destroyed in probe	2024-09-04 13:23:31 +02:00
pnp	PNP: ACPI: fix fortify warning	2024-02-23 08:54:38 +01:00
power	power: supply: axp288_charger: Round constant_charge_voltage writes down	2024-08-19 05:45:46 +02:00
powercap
pps
ps3
ptp	ptp: fix integer overflow in max_vclocks_store	2024-07-05 09:14:31 +02:00
pwm	pwm: stm32: Always do lazy disabling	2024-08-19 05:44:51 +02:00
rapidio
ras
regulator	regulator: bd71815: fix ramp values	2024-07-05 09:14:33 +02:00
remoteproc	remoteproc: imx_rproc: Fix refcount mistake in imx_rproc_addr_init	2024-08-19 05:45:30 +02:00
reset	reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning	2024-01-25 14:52:30 -08:00
rpmsg	rpmsg: virtio: Free driver_override when rpmsg_remove()	2024-02-23 08:54:24 +01:00
rtc	rtc: isl1208: Fix return value of nvmem callbacks	2024-08-19 05:45:20 +02:00
s390	bitmap: introduce generic optimized bitmap_size()	2024-09-04 13:23:16 +02:00
sbus
scsi	scsi: aacraid: Fix double-free on probe failure	2024-09-04 13:23:42 +02:00
sh
siox
slimbus	slimbus: qcom-ngd-ctrl: Add timeout for wait operation	2024-05-17 11:51:04 +02:00
soc	soc: qcom: cmd-db: Map shared memory as WC, not WB	2024-09-04 13:23:40 +02:00
soundwire	soundwire: stream: fix programming slave ports for non-continous port maps	2024-09-04 13:23:39 +02:00
spi	spi: spi-fsl-lpspi: Fix scldiv calculation	2024-08-19 05:45:42 +02:00
spmi	spmi: hisi-spmi-controller: Do not override device identifier	2024-07-05 09:14:20 +02:00
ssb	ssb: Fix division by zero issue in ssb_calc_clock_rate	2024-09-04 13:23:20 +02:00
staging	staging: ks7010: disable bh on tx_dev_lock	2024-09-04 13:23:22 +02:00
target	scsi: target: Fix SELinux error when systemd-modules loads the target module	2024-05-17 11:50:54 +02:00
tc
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-04-10 16:18:46 +02:00
thermal	thermal/drivers/qcom/lmh: Check for SCM availability at probe	2024-06-16 13:39:55 +02:00
thunderbolt	thunderbolt: Mark XDomain as unplugged when router is removed	2024-09-04 13:23:15 +02:00
tty	serial: core: check uartclk for zero to avoid divide by zero	2024-08-19 05:45:46 +02:00
uio	uio: Fix use-after-free in uio_open	2024-01-25 14:52:31 -08:00
usb	usb: typec: ucsi: Fix null pointer dereference in trace	2024-09-12 11:07:41 +02:00
vdpa	vduse: Temporarily fail if control queue feature requested	2024-07-05 09:14:42 +02:00
vfio	vfio/fsl-mc: Block calling interrupt handler without trigger	2024-04-10 16:19:30 +02:00
vhost	vhost-vdpa: switch to use vmf_insert_pfn() in the fault handler	2024-08-19 05:45:44 +02:00
video	fbdev: savage: Handle err return when savagefb_check_var failed	2024-06-16 13:39:57 +02:00
virt	drivers/virt/acrn: fix PFNMAP PTE checks in acrn_vm_ram_map()	2024-06-16 13:39:32 +02:00
virtio	virtio: delete vq in vp_find_vqs_msix() when request_irq() fails	2024-06-16 13:39:47 +02:00
visorbus
vlynq
vme
w1
watchdog	watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin	2024-06-16 13:39:59 +02:00
xen	xen/events: close evtchn after mapping cleanup	2024-04-10 16:18:46 +02:00
zorro
Kconfig
Makefile