mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2025-01-15 02:05:16 +08:00
1e87068570
Using 'imply AMD_IOMMU_V2' does not guarantee that the driver can link
against the exported functions. If the GPU driver is built-in but the
IOMMU driver is a loadable module, the kfd_iommu.c file is indeed
built but does not work:
x86_64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_iommu.o: in function `kfd_iommu_bind_process_to_device':
kfd_iommu.c:(.text+0x516): undefined reference to `amd_iommu_bind_pasid'
x86_64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_iommu.o: in function `kfd_iommu_unbind_process':
kfd_iommu.c:(.text+0x691): undefined reference to `amd_iommu_unbind_pasid'
x86_64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_iommu.o: in function `kfd_iommu_suspend':
kfd_iommu.c:(.text+0x966): undefined reference to `amd_iommu_set_invalidate_ctx_cb'
x86_64-linux-ld: kfd_iommu.c:(.text+0x97f): undefined reference to `amd_iommu_set_invalid_ppr_cb'
x86_64-linux-ld: kfd_iommu.c:(.text+0x9a4): undefined reference to `amd_iommu_free_device'
x86_64-linux-ld: drivers/gpu/drm/amd/amdkfd/kfd_iommu.o: in function `kfd_iommu_resume':
kfd_iommu.c:(.text+0xa9a): undefined reference to `amd_iommu_init_device'
x86_64-linux-ld: kfd_iommu.c:(.text+0xadc): undefined reference to `amd_iommu_set_invalidate_ctx_cb'
x86_64-linux-ld: kfd_iommu.c:(.text+0xaff): undefined reference to `amd_iommu_set_invalid_ppr_cb'
x86_64-linux-ld: kfd_iommu.c:(.text+0xc72): undefined reference to `amd_iommu_bind_pasid'
x86_64-linux-ld: kfd_iommu.c:(.text+0xe08): undefined reference to `amd_iommu_set_invalidate_ctx_cb'
x86_64-linux-ld: kfd_iommu.c:(.text+0xe26): undefined reference to `amd_iommu_set_invalid_ppr_cb'
x86_64-linux-ld: kfd_iommu.c:(.text+0xe42): undefined reference to `amd_iommu_free_device'
Use IS_REACHABLE to only build IOMMU-V2 support if the amd_iommu symbols
are reachable by the amdkfd driver. Output a warning if they are not,
because that may not be what the user was expecting.
Fixes: 64d1c3a43a ("drm/amdkfd: Centralize IOMMUv2 code and make it conditional")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
84 lines
2.4 KiB
C
84 lines
2.4 KiB
C
/*
|
|
* Copyright 2018 Advanced Micro Devices, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef __KFD_IOMMU_H__
|
|
#define __KFD_IOMMU_H__
|
|
|
|
#include <linux/kconfig.h>
|
|
|
|
#if IS_REACHABLE(CONFIG_AMD_IOMMU_V2)
|
|
|
|
#define KFD_SUPPORT_IOMMU_V2
|
|
|
|
int kfd_iommu_check_device(struct kfd_dev *kfd);
|
|
int kfd_iommu_device_init(struct kfd_dev *kfd);
|
|
|
|
int kfd_iommu_bind_process_to_device(struct kfd_process_device *pdd);
|
|
void kfd_iommu_unbind_process(struct kfd_process *p);
|
|
|
|
void kfd_iommu_suspend(struct kfd_dev *kfd);
|
|
int kfd_iommu_resume(struct kfd_dev *kfd);
|
|
|
|
int kfd_iommu_add_perf_counters(struct kfd_topology_device *kdev);
|
|
|
|
#else
|
|
|
|
static inline int kfd_iommu_check_device(struct kfd_dev *kfd)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int kfd_iommu_device_init(struct kfd_dev *kfd)
|
|
{
|
|
#if IS_MODULE(CONFIG_AMD_IOMMU_V2)
|
|
WARN_ONCE(1, "iommu_v2 module is not usable by built-in KFD");
|
|
#endif
|
|
return 0;
|
|
}
|
|
|
|
static inline int kfd_iommu_bind_process_to_device(
|
|
struct kfd_process_device *pdd)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline void kfd_iommu_unbind_process(struct kfd_process *p)
|
|
{
|
|
/* empty */
|
|
}
|
|
|
|
static inline void kfd_iommu_suspend(struct kfd_dev *kfd)
|
|
{
|
|
/* empty */
|
|
}
|
|
static inline int kfd_iommu_resume(struct kfd_dev *kfd)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int kfd_iommu_add_perf_counters(struct kfd_topology_device *kdev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
#endif /* IS_REACHABLE(CONFIG_AMD_IOMMU_V2) */
|
|
|
|
#endif /* __KFD_IOMMU_H__ */
|