Liu Shixin 2a57d83c78 mm/hwpoison: clear MF_COUNT_INCREASED before retrying get_any_page() ... Hulk Robot reported a panic in put_page_testzero() when testing madvise() with MADV_SOFT_OFFLINE. The BUG() is triggered when retrying get_any_page(). This is because we keep MF_COUNT_INCREASED flag in second try but the refcnt is not increased. page dumped because: VM_BUG_ON_PAGE(page_ref_count(page) == 0) ------------[ cut here ]------------ kernel BUG at include/linux/mm.h:737! invalid opcode: 0000 [#1] PREEMPT SMP CPU: 5 PID: 2135 Comm: sshd Tainted: G B 5.16.0-rc6-dirty #373 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 RIP: release_pages+0x53f/0x840 Call Trace: free_pages_and_swap_cache+0x64/0x80 tlb_flush_mmu+0x6f/0x220 unmap_page_range+0xe6c/0x12c0 unmap_single_vma+0x90/0x170 unmap_vmas+0xc4/0x180 exit_mmap+0xde/0x3a0 mmput+0xa3/0x250 do_exit+0x564/0x1470 do_group_exit+0x3b/0x100 __do_sys_exit_group+0x13/0x20 __x64_sys_exit_group+0x16/0x20 do_syscall_64+0x34/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xae Modules linked in: ---[ end trace e99579b570fe0649 ]--- RIP: 0010:release_pages+0x53f/0x840 Link: https://lkml.kernel.org/r/20211221074908.3910286-1-liushixin2@huawei.com Fixes: b94e02822d ("mm,hwpoison: try to narrow window race for free pages") Signed-off-by: Liu Shixin <liushixin2@huawei.com> Reported-by: Hulk Robot <hulkci@huawei.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2021-12-25 12:20:56 -08:00
..
damon	mm/damon/dbgfs: protect targets destructions with kdamond_lock	2021-12-25 12:20:56 -08:00
kasan	kasan: add kasan mode messages when kasan init	2021-11-11 09:34:35 -08:00
kfence	kfence: fix memory leak when cat kfence objects	2021-12-25 12:20:55 -08:00
backing-dev.c	mm: bdi: initialize bdi_min_ratio when bdi is unregistered	2021-12-10 17:10:56 -08:00
balloon_compaction.c	mm: fix typos in comments	2021-05-07 00:26:35 -07:00
bootmem_info.c	mm/bootmem_info.c: mark __init on register_page_bootmem_info_section	2021-09-03 09:58:14 -07:00
cleancache.c
cma_debug.c	mm/cma: change cma mutex to irq safe spinlock	2021-05-05 11:27:21 -07:00
cma_sysfs.c	mm: cma: support sysfs	2021-05-05 11:27:24 -07:00
cma.c	memblock: rename memblock_free to memblock_phys_free	2021-11-06 13:30:41 -07:00
cma.h	mm: cma: support sysfs	2021-05-05 11:27:24 -07:00
compaction.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm: debug_vm_pgtable: don't use __P000 directly	2021-11-06 13:30:33 -07:00
debug.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
dmapool.c	mm/dmapool: use DEVICE_ATTR_RO macro	2021-06-29 10:53:52 -07:00
early_ioremap.c	mm/early_ioremap.c: remove redundant early_ioremap_shutdown()	2021-09-08 11:50:24 -07:00
fadvise.c
failslab.c
filemap.c	filemap: remove PageHWPoison check from next_uptodate_page()	2021-12-10 17:10:55 -08:00
folio-compat.c	mm/filemap: Add FGP_STABLE	2021-10-18 07:49:41 -04:00
frontswap.c	mm/mempool: minor coding style tweaks	2021-05-05 11:27:27 -07:00
gup_test.c	selftests/vm: gup_test: test faulting in kernel, and verify pinnable pages	2021-05-05 11:27:26 -07:00
gup_test.h	selftests/vm: gup_test: fix test flag	2021-05-05 11:27:26 -07:00
gup.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
highmem.c	Fixes for 5.16 folios:	2021-11-25 10:13:56 -08:00
hmm.c	mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled	2021-09-08 18:45:52 -07:00
huge_memory.c	Memory folios	2021-11-01 08:47:59 -07:00
hugetlb_cgroup.c	hugetlb_cgroup: remove unused hugetlb_cgroup_from_counter macro	2021-11-06 13:30:39 -07:00
hugetlb_vmemmap.c	mm: hugetlb: introduce CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON	2021-06-30 20:47:26 -07:00
hugetlb_vmemmap.h	mm: hugetlb: introduce nr_free_vmemmap_pages in the struct hstate	2021-06-30 20:47:25 -07:00
hugetlb.c	hugetlbfs: fix issue of preallocation of gigantic pages can't work	2021-12-10 17:10:56 -08:00
hwpoison-inject.c	mm: hwpoison: don't drop slab caches for offlining non-LRU page	2021-09-03 09:58:15 -07:00
init-mm.c	mm: add setup_initial_init_mm() helper	2021-07-08 11:48:21 -07:00
internal.h	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
interval_tree.c	mm/interval_tree: add comments to improve code readability	2021-04-30 11:20:38 -07:00
io-mapping.c	mm: add a io_mapping_map_user helper	2021-04-30 11:20:39 -07:00
ioremap.c	mm: move ioremap_page_range to vmalloc.c	2021-09-08 11:50:24 -07:00
Kconfig	percpu: km: ensure it is used with NOMMU (either UP or SMP)	2021-12-06 12:45:09 -05:00
Kconfig.debug	mm, page_poison: remove CONFIG_PAGE_POISONING_ZERO	2020-12-15 12:13:46 -08:00
khugepaged.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
kmemleak.c	mm/kmemleak: allow __GFP_NOLOCKDEP passed to kmemleak's gfp	2021-09-08 18:45:53 -07:00
ksm.c	mm/migrate: Add folio_migrate_flags()	2021-10-18 07:49:39 -04:00
list_lru.c	mm: list_lru: only add memcg-aware lrus to the global lru list	2021-11-06 13:30:35 -07:00
maccess.c	ARM: 9115/1: mm/maccess: fix unaligned copy_{from,to}_kernel_nofault	2021-08-20 11:39:25 +01:00
madvise.c	mm: use pidfd_get_task()	2021-10-14 13:29:22 +02:00
Makefile	mm/util: Add folio_mapping() and folio_file_mapping()	2021-09-27 09:27:30 -04:00
mapping_dirty_helpers.c	mm/mapping_dirty_helpers: remove double Note in kerneldoc	2021-07-01 11:06:02 -07:00
memblock.c	arm64 fixes for -rc1	2021-11-10 11:29:30 -08:00
memcontrol.c	mm/memcg: relocate mod_objcg_mlstate(), get_obj_stock() and put_obj_stock()	2021-12-10 17:10:56 -08:00
memfd.c	mm,hugetlb: remove mlock ulimit for SHM_HUGETLB	2021-11-09 10:02:48 -08:00
memory_hotplug.c	treewide: Add missing includes masked by cgroup -> bpf dependency	2021-12-03 10:58:13 -08:00
memory-failure.c	mm/hwpoison: clear MF_COUNT_INCREASED before retrying get_any_page()	2021-12-25 12:20:56 -08:00
memory.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
mempolicy.c	mm: mempolicy: fix THP allocations escaping mempolicy restrictions	2021-12-25 12:20:55 -08:00
mempool.c	mm: remove spurious blkdev.h includes	2021-10-18 06:17:01 -06:00
memremap.c	mm/memcg: Convert mem_cgroup_uncharge() to take a folio	2021-09-27 09:27:31 -04:00
memtest.c
migrate.c	mm/migrate.c: remove MIGRATE_PFN_LOCKED	2021-11-11 09:34:35 -08:00
mincore.c	inode: make init and permission helpers idmapped mount aware	2021-01-24 14:27:16 +01:00
mlock.c	mm/memcg: Add folio_lruvec_relock_irq() and folio_lruvec_relock_irqsave()	2021-09-27 09:27:31 -04:00
mm_init.c	include/linux/page-flags-layout.h: cleanups	2021-04-30 11:20:42 -07:00
mmap_lock.c	mm: mmap_lock: fix disabling preemption directly	2021-07-23 17:43:28 -07:00
mmap.c	mm,hugetlb: remove mlock ulimit for SHM_HUGETLB	2021-11-09 10:02:48 -08:00
mmu_gather.c	mm: eliminate "expecting prototype" kernel-doc warnings	2021-04-16 16:10:36 -07:00
mmu_notifier.c	mm/mmu_notifiers: ensure range_end() is paired with range_start()	2021-03-25 09:22:55 -07:00
mmzone.c	mm/lru: replace pgdat lru_lock with lruvec lock	2020-12-15 14:48:04 -08:00
mprotect.c	mm/mprotect.c: avoid repeated assignment in do_mprotect_pkey()	2021-11-06 13:30:36 -07:00
mremap.c	mm, hugepages: add mremap() support for hugepage backed vma	2021-11-06 13:30:39 -07:00
msync.c	mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start	2021-04-30 11:20:37 -07:00
nommu.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
oom_kill.c	pidfd.v5.16	2021-11-10 16:02:08 -08:00
page_alloc.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
page_counter.c	mm: page_counter: mitigate consequences of a page_counter underflow	2021-04-30 11:20:38 -07:00
page_ext.c	mm/page_ext.c: fix a comment	2021-11-06 13:30:34 -07:00
page_idle.c	mm/idle_page_tracking: make PG_idle reusable	2021-09-08 11:50:24 -07:00
page_io.c	for-5.16/block-2021-10-29	2021-11-01 09:19:50 -07:00
page_isolation.c	mm/page_isolation: guard against possible putback unisolated page	2021-11-06 13:30:40 -07:00
page_owner.c	mm/page_owner.c: modify the type of argument "order" in some functions	2021-11-11 09:34:35 -08:00
page_poison.c	mm: page_poison: print page info when corruption is caught	2021-04-30 11:20:36 -07:00
page_reporting.c	mm/page_reporting: allow driver to specify reporting order	2021-06-29 10:53:47 -07:00
page_reporting.h	mm/page_reporting: export reporting order as module parameter	2021-06-29 10:53:47 -07:00
page_vma_mapped.c	mm: device exclusive memory access	2021-07-01 11:06:03 -07:00
page-writeback.c	folio: Add a function to get the host inode for a folio	2021-11-10 21:16:52 +00:00
pagewalk.c	mm: pagewalk: fix walk for hugepage tables	2021-06-29 10:53:49 -07:00
percpu-internal.h	Merge branch 'for-5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu	2021-07-01 17:17:24 -07:00
percpu-km.c	percpu: flush tlb in pcpu_reclaim_populated()	2021-07-04 18:30:17 +00:00
percpu-stats.c	percpu: rework memcg accounting	2021-06-05 20:43:15 +00:00
percpu-vm.c	percpu: flush tlb in pcpu_reclaim_populated()	2021-07-04 18:30:17 +00:00
percpu.c	memblock: use memblock_free for freeing virtual pointers	2021-11-06 13:30:41 -07:00
pgalloc-track.h	mm: fix typos in comments	2021-05-07 00:26:35 -07:00
pgtable-generic.c	mm/thp: fix __split_huge_pmd_locked() on shmem migration entry	2021-06-16 09:24:42 -07:00
process_vm_access.c	mm/process_vm_access.c: remove duplicate include	2021-05-05 11:27:27 -07:00
ptdump.c	mm: ptdump: fix build failure	2021-04-16 16:10:37 -07:00
readahead.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
rmap.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
rodata_test.c
secretmem.c	mm/secretmem: avoid letting secretmem_users drop to zero	2021-10-28 17:18:55 -07:00
shmem.c	fs: Remove FS_THP_SUPPORT	2021-11-17 10:36:35 -05:00
shuffle.c	mm: eliminate "expecting prototype" kernel-doc warnings	2021-04-16 16:10:36 -07:00
shuffle.h	mm/shuffle: fix section mismatch warning	2021-05-22 15:09:07 -10:00
slab_common.c	mm: remove HARDENED_USERCOPY_FALLBACK	2021-11-06 13:30:43 -07:00
slab.c	mm: emit the "free" trace report before freeing memory in kmem_cache_free()	2021-11-20 10:35:54 -08:00
slab.h	mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag	2021-11-20 10:35:54 -08:00
slob.c	mm: emit the "free" trace report before freeing memory in kmem_cache_free()	2021-11-20 10:35:54 -08:00
slub.c	mm/slub: fix endianness bug for alloc/free_traces attributes	2021-12-10 17:10:56 -08:00
sparse-vmemmap.c	mm: remove redundant smp_wmb()	2021-11-06 13:30:36 -07:00
sparse.c	memblock: use memblock_free for freeing virtual pointers	2021-11-06 13:30:41 -07:00
swap_cgroup.c
swap_slots.c	treewide: Add missing includes masked by cgroup -> bpf dependency	2021-12-03 10:58:13 -08:00
swap_state.c	mm/workingset: Convert workingset_refault() to take a folio	2021-10-18 07:49:40 -04:00
swap.c	mm/swap.c:put_pages_list(): reinitialise the page list	2021-11-20 10:35:54 -08:00
swapfile.c	Merge branch 'akpm' (patches from Andrew)	2021-11-06 14:08:17 -07:00
truncate.c	vfs: keep inodes with page cache off the inode shrinker LRU	2021-11-09 10:02:48 -08:00
usercopy.c
userfaultfd.c	Revert "mm: shmem: don't truncate page if memory failure happens"	2021-11-13 12:03:03 -08:00
util.c	mm: Remove folio_test_single	2021-11-17 10:36:35 -05:00
vmacache.c
vmalloc.c	mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation	2021-11-06 13:30:37 -07:00
vmpressure.c	mm/vmpressure: fix data-race with memcg->socket_pressure	2021-11-06 13:30:40 -07:00
vmscan.c	Merge branch 'akpm' (patches from Andrew)	2021-11-09 10:11:53 -08:00
vmstat.c	mm: vmstat.c: make extfrag_index show more pretty	2021-11-06 13:30:42 -07:00
workingset.c	Merge branch 'akpm' (patches from Andrew)	2021-11-09 10:11:53 -08:00
z3fold.c	mm/z3fold: add kerneldoc fields for z3fold_pool	2021-07-01 11:06:03 -07:00
zbud.c	mm/zbud: add kerneldoc fields for zbud_pool	2021-07-01 11:06:03 -07:00
zpool.c	mm: fix typos in comments	2021-05-07 00:26:35 -07:00
zsmalloc.c	mm/zsmalloc.c: close race window between zs_pool_dec_isolated() and zs_unregister_migration()	2021-11-06 13:30:43 -07:00
zswap.c	mm/zswap.c: fix two bugs in zswap_writeback_entry()	2021-06-30 20:47:31 -07:00