Lin Ma da2d1d3627 vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING ... [ Upstream commit 6c21660fe2 ] In the vlan_changelink function, a loop is used to parse the nested attributes IFLA_VLAN_EGRESS_QOS and IFLA_VLAN_INGRESS_QOS in order to obtain the struct ifla_vlan_qos_mapping. These two nested attributes are checked in the vlan_validate_qos_map function, which calls nla_validate_nested_deprecated with the vlan_map_policy. However, this deprecated validator applies a LIBERAL strictness, allowing the presence of an attribute with the type IFLA_VLAN_QOS_UNSPEC. Consequently, the loop in vlan_changelink may parse an attribute of type IFLA_VLAN_QOS_UNSPEC and believe it carries a payload of struct ifla_vlan_qos_mapping, which is not necessarily true. To address this issue and ensure compatibility, this patch introduces two type checks that skip attributes whose type is not IFLA_VLAN_QOS_MAPPING. Fixes: 07b5b17e15 ("[VLAN]: Use rtnl_link API") Signed-off-by: Lin Ma <linma@zju.edu.cn> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240118130306.1644001-1-linma@zju.edu.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-01-31 16:19:01 -08:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
vlan_core.c	net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()	2024-01-01 12:42:32 +00:00
vlan_dev.c	net: vlan: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set()	2023-08-02 19:11:05 -07:00
vlan_gvrp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
vlan_mvrp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
vlan_netlink.c	vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING	2024-01-31 16:19:01 -08:00
vlan.c	Revert "vlan: Fix VLAN 0 memory leak"	2023-08-14 08:14:00 +01:00
vlan.h	vlan: introduce vlan_dev_free_egress_priority	2022-02-09 13:33:39 +00:00
vlanproc.c	vlan: use correct format characters	2022-03-17 16:34:49 -07:00
vlanproc.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00